[GitHub] nifi pull request #2051: NIFI-4224: Initial implementation of Process Group ...

2017-08-08 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2051#discussion_r131993623 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/FlowResource.java --- @@ -640,7

[GitHub] nifi pull request #2051: NIFI-4224: Initial implementation of Process Group ...

2017-08-08 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2051#discussion_r131996939 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java

[GitHub] nifi pull request #2051: NIFI-4224: Initial implementation of Process Group ...

2017-08-08 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2051#discussion_r131983295 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java

[GitHub] nifi pull request #2051: NIFI-4224: Initial implementation of Process Group ...

2017-08-08 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2051#discussion_r131983144 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java

[GitHub] nifi pull request #2051: NIFI-4224: Initial implementation of Process Group ...

2017-08-08 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2051#discussion_r131985592 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/dao/impl/StandardProcessGroupDAO.java

[GitHub] nifi pull request #2051: NIFI-4224: Initial implementation of Process Group ...

2017-08-08 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2051#discussion_r131979395 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/dto/ProcessGroupDTO.java

[GitHub] nifi pull request #2051: NIFI-4224: Initial implementation of Process Group ...

2017-08-08 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2051#discussion_r132005935 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java

[GitHub] nifi pull request #2051: NIFI-4224: Initial implementation of Process Group ...

2017-08-08 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2051#discussion_r131983043 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java

[GitHub] nifi pull request #2051: NIFI-4224: Initial implementation of Process Group ...

2017-08-08 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2051#discussion_r131998273 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java

[GitHub] nifi pull request #2051: NIFI-4224: Initial implementation of Process Group ...

2017-08-08 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2051#discussion_r131979744 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java

[GitHub] nifi pull request #2051: NIFI-4224: Initial implementation of Process Group ...

2017-08-08 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2051#discussion_r131999511 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java

[GitHub] nifi pull request #2051: NIFI-4224: Initial implementation of Process Group ...

2017-08-08 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2051#discussion_r131994112 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/FlowResource.java --- @@ -640,7

[GitHub] nifi pull request #2051: NIFI-4224: Initial implementation of Process Group ...

2017-08-08 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2051#discussion_r131983689 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java

[GitHub] nifi-registry issue #3: NIFIREG-6 Adding nifi-registry-bootstrap module

2017-08-07 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi-registry/pull/3 Thanks @bbende! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #2044: NIFI-4139 Extract key provider to framework-level service

2017-08-07 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2044 Thanks @alopresto! This has been merged to master. I accidentally forgot to add the 'This closes...' text to the commit message. Would you mind closing this PR out? Thanks! --- If your project

[GitHub] nifi issue #2044: NIFI-4139 Extract key provider to framework-level service

2017-08-04 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2044 @alopresto These refactorings look good. The backward compatibility support for legacy configurations is also solid. One minor thing I'd like to investigate further if we can remove the dependency

[GitHub] nifi issue #2051: NIFI-4224: Initial implementation of Process Group level V...

2017-08-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2051 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #2044: NIFI-4139 Extract key provider to framework-level service

2017-08-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2044 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi-registry pull request #3: NIFIREG-6 Adding nifi-registry-bootstrap modu...

2017-08-03 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/3#discussion_r131141483 --- Diff: nifi-registry-runtime/src/main/java/org/apache/nifi/registry/NiFiRegistry.java --- @@ -18,22 +18,69 @@ import

[GitHub] nifi-registry pull request #3: NIFIREG-6 Adding nifi-registry-bootstrap modu...

2017-08-03 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/3#discussion_r131150677 --- Diff: nifi-registry-runtime/src/main/java/org/apache/nifi/registry/NiFiRegistry.java --- @@ -43,28 +90,242 @@ public void run

[GitHub] nifi-registry issue #3: NIFIREG-6 Adding nifi-registry-bootstrap module

2017-08-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi-registry/pull/3 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #2047: NIFI-4210: Add support for OpenId Connect

2017-08-03 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2047#discussion_r131135419 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/oidc

[GitHub] nifi pull request #2047: NIFI-4210: Add support for OpenId Connect

2017-08-02 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2047#discussion_r130962746 --- Diff: pom.xml --- @@ -95,7 +95,7 @@ 9.4.3.v20170317 4.10.4 4.2.4.RELEASE -4.0.3.RELEASE

[GitHub] nifi pull request #2047: NIFI-4210: Add support for OpenId Connect

2017-08-02 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2047#discussion_r130962379 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/oidc

[GitHub] nifi pull request #2047: NIFI-4210: Add support for OpenId Connect

2017-08-02 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2047#discussion_r130943341 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/oidc

[GitHub] nifi pull request #2047: NIFI-4210: Add support for OpenId Connect

2017-08-02 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2047#discussion_r130884930 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/oidc/OidcService.java

[GitHub] nifi pull request #2047: NIFI-4210: Add support for OpenId Connect

2017-08-02 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2047#discussion_r130882716 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/oidc/OidcService.java

[GitHub] nifi pull request #2047: NIFI-4210: Add support for OpenId Connect

2017-08-02 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2047#discussion_r130879118 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/oidc/OidcService.java

[GitHub] nifi pull request #2047: NIFI-4210: Add support for OpenId Connect

2017-08-02 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2047#discussion_r130878806 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/oidc/OidcService.java

[GitHub] nifi pull request #2047: NIFI-4210: Add support for OpenId Connect

2017-08-02 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2047#discussion_r130878563 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/AccessResource.java

[GitHub] nifi pull request #2047: NIFI-4210: Add support for OpenId Connect

2017-08-02 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2047#discussion_r130873359 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/AccessResource.java

[GitHub] nifi pull request #2047: NIFI-4210: Add support for OpenId Connect

2017-08-02 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2047#discussion_r130871309 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/AccessResource.java

[GitHub] nifi pull request #2047: NIFI-4210: Add support for OpenId Connect

2017-08-01 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/2047 NIFI-4210: Add support for OpenId Connect NIFI-4210: - Introducing support for OpenId Connect. - Updating REST API and UI to support the authorization code flow. You can merge this pull

[GitHub] nifi issue #2019: NIFI-4032: Managed Ranger Authorizer

2017-07-24 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2019 Great find @YolandaMDavis! Will address this and update. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi issue #1872: NIFI-106: Expose processors' counters in Stats History

2017-07-21 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1872 Thanks @markap14! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #2023: NIFI-4206: Proxy instructions in Admin Guide

2017-07-20 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2023 @bond- Another commit has been pushed which includes a brief example for NiFi specific configuration. I am not super familiar with proxy configurations so if you have any additional suggestions

[GitHub] nifi issue #1644: NIFI-11 - Capture StringIndexOutOfBoundsException to preve...

2017-07-19 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1644 Thanks @trixpan! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request #2023: NIFI-4206: Proxy instructions in Admin Guide

2017-07-19 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/2023 NIFI-4206: Proxy instructions in Admin Guide NIFI-4206: - Updating admin guide to include instructions for running NiFi behind a proxy. You can merge this pull request into a Git repository

[GitHub] nifi pull request #2019: NIFI-4032: Managed Ranger Authorizer

2017-07-18 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/2019 NIFI-4032: Managed Ranger Authorizer NIFI-4032: Managed Ranger Authorizer - Introducing the ManagedRangerAuthorizer. - Introducing the AuthorizationAuditor. - Updating authorization

[GitHub] nifi pull request #1872: NIFI-106: Expose processors' counters in Stats Hist...

2017-07-17 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/1872#discussion_r127742238 --- Diff: nifi-api/src/main/java/org/apache/nifi/controller/status/ProcessorStatus.java --- @@ -234,6 +245,7 @@ public ProcessorStatus clone

[GitHub] nifi pull request #1872: NIFI-106: Expose processors' counters in Stats Hist...

2017-07-17 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/1872#discussion_r127739416 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/http/endpoints

[GitHub] nifi pull request #1872: NIFI-106: Expose processors' counters in Stats Hist...

2017-07-17 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/1872#discussion_r127741268 --- Diff: nifi-framework-api/src/main/java/org/apache/nifi/controller/status/history/StatusHistory.java --- @@ -41,4 +41,9 @@ * @return List

[GitHub] nifi pull request #1872: NIFI-106: Expose processors' counters in Stats Hist...

2017-07-17 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/1872#discussion_r127741006 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java

[GitHub] nifi issue #1872: NIFI-106: Expose processors' counters in Stats History

2017-07-17 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1872 @markap14 this sounds like a good approach. Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi-registry issue #1: NIFIREG-1 Initial project structure for NiFi Registr...

2017-07-13 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi-registry/pull/1 Thanks @bbende! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #2001: NIFI-1586 Removed check for distributed ZK quorum before s...

2017-07-11 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2001 Thanks @jtstorck! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #2001: NIFI-1586 Removed check for distributed ZK quorum before s...

2017-07-10 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2001 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1999: NIFI-3939: Reviewed and corrected all incorrect nifi-web-a...

2017-07-10 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1999 Thanks @m-hogue! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1999: NIFI-3939: Reviewed and corrected all incorrect nifi-web-a...

2017-07-10 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1999 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1996: NIFI-4167: StandardResourceClaimManager should not synchro...

2017-07-10 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1996 Thanks @markap14! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1996: NIFI-4167: StandardResourceClaimManager should not synchro...

2017-07-10 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1996 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #2000: NIFI-4172: renamed ClusteSummaryEntity to ClusterSummaryEn...

2017-07-10 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2000 I've updated the fix version on the JIRA so we'll catch it for 2.0.0. Unfortunately, I cannot close the PR without a commit. Only the person that created the PR can do so. Do you mind closing

[GitHub] nifi issue #2000: NIFI-4172: renamed ClusteSummaryEntity to ClusterSummaryEn...

2017-07-10 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2000 Thanks for the PR @m-hogue. I almost made this fix myself awhile back and held off. Technically, this class is part of a domain model for the REST API. Folks should be able to use this model

[GitHub] nifi issue #1995: NIFI-4151: Ensure that we properly call invalidateValidati...

2017-07-07 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1995 Thanks @markap14. This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1978: NIFI-4127: Composite User Group Providers

2017-07-07 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1978 @pvillard31 A second commit has been pushed updating the documentation and providing an example of the composite configurable user group provider. Thanks again for the review! --- If your project

[GitHub] nifi issue #1962: NIFI-4143 - externalize MAX_CONCURRENT_REQUESTS

2017-07-06 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1962 Thanks @pvillard31! Most recent update looks great. This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi pull request #1978: NIFI-4127: Composite User Group Providers

2017-07-06 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/1978#discussion_r125994624 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -464,6 +464,17 @@ Another option for the UserGroupProvider

[GitHub] nifi pull request #1978: NIFI-4127: Composite User Group Providers

2017-07-06 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/1978#discussion_r125987445 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -464,6 +464,17 @@ Another option for the UserGroupProvider

[GitHub] nifi issue #1979: NIFI-4151: Updated UpdateAttribute to only create JAXB Con...

2017-07-06 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1979 Thanks @markap14! The update has addressed the test failures and this has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi issue #1980: NIFI-4153: Use a LinkedBlockingQueue instead of a Synchron...

2017-07-06 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1980 Thanks @markap14! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1979: NIFI-4151: Updated UpdateAttribute to only create JAXB Con...

2017-07-05 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1979 @markap14 Looks like the proposed changes are causing unit test failures. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi issue #1980: NIFI-4153: Use a LinkedBlockingQueue instead of a Synchron...

2017-07-05 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1980 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1962: NIFI-4143 - externalize MAX_CONCURRENT_REQUESTS

2017-07-05 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1962 @pvillard31 Just started reviewing this PR. I'm wondering if the property should be associated with the cluster section instead of the web properties. This property is only relevant when clustered

[GitHub] nifi issue #1979: NIFI-4151: Updated UpdateAttribute to only create JAXB Con...

2017-07-05 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1979 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #1978: NIFI-4127: Composite User Group Providers

2017-07-05 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1978 NIFI-4127: Composite User Group Providers NIFI-4127: - Introducing composite ConfigurableUserGroupProvider and UserGroupProvider. - Adding appropriate unit tests. - Updating object model

[GitHub] nifi issue #1923: NIFI-4059: Introduce LdapUserGroupProvider

2017-06-19 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1923 Thanks @pvillard31 for having a look at this PR! I've addressed the two issues above and I think resolving the group name when searching users only and detecting group membership is supported. Check

[GitHub] nifi pull request #1923: NIFI-4059: Introduce LdapUserGroupProvider

2017-06-16 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1923 NIFI-4059: Introduce LdapUserGroupProvider NIFI-4059: - Introducing the LdapUserGroupProvider. - Updating documentation accordingly. - Moving the IdentityMapping utilities so they were

[GitHub] nifi issue #1900: NIFI-4019: Added support for X-Forwarded-* headers

2017-06-15 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1900 Yup. Thanks again! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #1900: NIFI-4019: Added support for X-Forwarded-* headers

2017-06-15 Thread mcgilman
Github user mcgilman closed the pull request at: https://github.com/apache/nifi/pull/1900 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi issue #1900: NIFI-4019: Added support for X-Forwarded-* headers

2017-06-14 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1900 Thanks for catching those @jtstorck! Will update. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1897: NIFI-3653: Introduce ManagedAuthorizer

2017-06-09 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1897 For those reviewing... just pushed a follow-up commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1897: NIFI-3653: Introduce ManagedAuthorizer

2017-06-09 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1897 I'll be posting another commit to this PR to more easily allow providers to map their users, groups, and policies to the internal data model. Also, have minor documentation and error message tweaks

[GitHub] nifi pull request #1903: NIFI-4045: POST lineage may not respond with eventI...

2017-06-08 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1903 NIFI-4045: POST lineage may not respond with eventId NIFI-4045: - Addressing issues causing the eventId to not be relayed when submitting a lineage request under certain conditions. You can

[GitHub] nifi pull request #1900: NIFI-4019: Added support for X-Forwarded-* headers

2017-06-08 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1900 NIFI-4019: Added support for X-Forwarded-* headers NIFI-4019: - Adding support for X-Forwarded-* headers. - Unrelated code clean up. You can merge this pull request into a Git repository

[GitHub] nifi pull request #1897: NIFI-3653: Introduce ManagedAuthorizer

2017-06-07 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1897 NIFI-3653: Introduce ManagedAuthorizer NIFI-3653: - Introducing UserGroup and Policy provider interfaces. - Introducing FileUserGroupProvider and FileAccessPolicyProvider. - Refactoring

[GitHub] nifi pull request #1893: NIFI-4027: Restoring tooltips in the toolbar

2017-06-06 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1893 NIFI-4027: Restoring tooltips in the toolbar NIFI-4027: - Fixing the positioning of the tooltips in the component toolbar. You can merge this pull request into a Git repository by running

[GitHub] nifi issue #1644: NIFI-11 - Capture StringIndexOutOfBoundsException to preve...

2017-06-06 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1644 @trixpan I think the most recent commit does address the remaining spots, however it appears break a unit test. Do you mind updating? Looking at the failure in the Travis build, I believe the new

[GitHub] nifi issue #1644: NIFI-11 - Capture StringIndexOutOfBoundsException to preve...

2017-06-02 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1644 @trixpan I believe there a couple other instances where we are evaluating an expression where we are still just catching ProcessException. Specifically, I believe we also need this adjustment when

[GitHub] nifi issue #1872: NIFI-106: Expose processors' counters in Stats History

2017-05-30 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1872 @markap14 - Counters are currently protected in access policies using a global resource. This is due to the fact that there are instance based Counters and a corresponding type based Counter

[GitHub] nifi pull request #1871: NIFI-3719: Address timezone issue when formatting h...

2017-05-30 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1871 NIFI-3719: Address timezone issue when formatting hours/minutes/seconds NIFI-3719: - Removing the usage of SimpleDateFormat when formatting hours/minutes/seconds as the current timezone could

[GitHub] nifi issue #1848: [NIFI-3925] bound width of combo options drop down text

2017-05-24 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1848 Thanks @scottyaslan. This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1849: [NIFI-3943] align combo option item toolips to hover close...

2017-05-24 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1849 Thanks @scottyaslan. This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1848: [NIFI-3925] bound width of combo options drop down text

2017-05-24 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1848 @scottyaslan Would it be possible to update this PR to not take a percentage based approach? The component(s) selected by the combo plugin can have any width. Taking a percentage based approach may

[GitHub] nifi issue #1848: [NIFI-3925] bound width of combo options drop down text

2017-05-24 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1848 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1644: NIFI-11 - Capture StringIndexOutOfBoundsException to preve...

2017-05-24 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1644 Pretty sure it still needs an update. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request #1844: NIFI-3955: Filtering out the EventTime searchable f...

2017-05-23 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1844 NIFI-3955: Filtering out the EventTime searchable field for all implementation of ProvenanceRepository NIFI-3955: - Filtering out the EventTime searchable field for all implementation

[GitHub] nifi pull request #1838: NIFI-3933: Monitor heartbeats based on connected no...

2017-05-22 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1838 NIFI-3933: Monitor heartbeats based on connected nodes NIFI-3933: - When monitoring heartbeats use the connected nodes as the basis for the check. This addresses the case when a node

[GitHub] nifi issue #1812: NIFI-1963 Forces a node reconnecting to a cluster to inher...

2017-05-17 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1812 Thanks @jtstorck. This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1812: NIFI-1963 Forces a node reconnecting to a cluster to inher...

2017-05-17 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1812 Will pick up review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] nifi issue #1799: NIFI-3896 - Makes DeprecationNotice more intuitive

2017-05-17 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1799 Thanks @trixpan. This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1799: NIFI-3896 - Makes DeprecationNotice more intuitive

2017-05-17 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1799 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1819: NIFI-3917: Use a default value of 'false' for CSV Reader's...

2017-05-17 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1819 Thanks @markap14! This has been merged to master. And thanks @kevdoran reviewing too! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi issue #1819: NIFI-3917: Use a default value of 'false' for CSV Reader's...

2017-05-17 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1819 Will review/merge... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1818: [NIFI-3906] Introduce additional validation when handling ...

2017-05-17 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1818 Thanks @scottyaslan. This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1818: [NIFI-3906] Introduce additional validation when handling ...

2017-05-17 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1818 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1817: NIFI-3923: Only start processors after repositories have b...

2017-05-17 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1817 Thanks @markap14. This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1817: NIFI-3923: Only start processors after repositories have b...

2017-05-17 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1817 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1808: NIFI-3904 Adding logic to only reload when incoming bundle...

2017-05-16 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1808 Thanks @bbende. This looks good and has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi issue #1808: NIFI-3904 Adding logic to only reload when incoming bundle...

2017-05-16 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1808 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #1803: NIFI-3901: Address Provenance Rest Api issues

2017-05-15 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1803 NIFI-3901: Address Provenance Rest Api issues NIFI-3901: - Addressing response code of POST /provenance/lineage. - Ensuring cluster node details are set accordingly. You can merge this pull

<    1   2   3   4   5   6   7   8   9   10   >