[GitHub] nifi pull request #1872: NIFI-106: Expose processors' counters in Stats Hist...

2017-07-17 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/1872#discussion_r127741006 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java

[GitHub] nifi issue #1872: NIFI-106: Expose processors' counters in Stats History

2017-07-17 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1872 @markap14 this sounds like a good approach. Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi issue #1995: NIFI-4151: Ensure that we properly call invalidateValidati...

2017-07-07 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1995 Thanks @markap14. This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #2001: NIFI-1586 Removed check for distributed ZK quorum before s...

2017-07-11 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2001 Thanks @jtstorck! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1999: NIFI-3939: Reviewed and corrected all incorrect nifi-web-a...

2017-07-10 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1999 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1996: NIFI-4167: StandardResourceClaimManager should not synchro...

2017-07-10 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1996 Thanks @markap14! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1999: NIFI-3939: Reviewed and corrected all incorrect nifi-web-a...

2017-07-10 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1999 Thanks @m-hogue! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1996: NIFI-4167: StandardResourceClaimManager should not synchro...

2017-07-10 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1996 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #2000: NIFI-4172: renamed ClusteSummaryEntity to ClusterSummaryEn...

2017-07-10 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2000 I've updated the fix version on the JIRA so we'll catch it for 2.0.0. Unfortunately, I cannot close the PR without a commit. Only the person that created the PR can do so. Do you mind closing

[GitHub] nifi issue #2000: NIFI-4172: renamed ClusteSummaryEntity to ClusterSummaryEn...

2017-07-10 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2000 Thanks for the PR @m-hogue. I almost made this fix myself awhile back and held off. Technically, this class is part of a domain model for the REST API. Folks should be able to use this model

[GitHub] nifi issue #2001: NIFI-1586 Removed check for distributed ZK quorum before s...

2017-07-10 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2001 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #1978: NIFI-4127: Composite User Group Providers

2017-07-06 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/1978#discussion_r125987445 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -464,6 +464,17 @@ Another option for the UserGroupProvider

[GitHub] nifi pull request #1978: NIFI-4127: Composite User Group Providers

2017-07-06 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/1978#discussion_r125994624 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -464,6 +464,17 @@ Another option for the UserGroupProvider

[GitHub] nifi issue #1962: NIFI-4143 - externalize MAX_CONCURRENT_REQUESTS

2017-07-06 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1962 Thanks @pvillard31! Most recent update looks great. This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi issue #1978: NIFI-4127: Composite User Group Providers

2017-07-07 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1978 @pvillard31 A second commit has been pushed updating the documentation and providing an example of the composite configurable user group provider. Thanks again for the review! --- If your project

[GitHub] nifi pull request #2019: NIFI-4032: Managed Ranger Authorizer

2017-07-18 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/2019 NIFI-4032: Managed Ranger Authorizer NIFI-4032: Managed Ranger Authorizer - Introducing the ManagedRangerAuthorizer. - Introducing the AuthorizationAuditor. - Updating authorization

[GitHub] nifi issue #2023: NIFI-4206: Proxy instructions in Admin Guide

2017-07-20 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2023 @bond- Another commit has been pushed which includes a brief example for NiFi specific configuration. I am not super familiar with proxy configurations so if you have any additional suggestions

[GitHub] nifi issue #1872: NIFI-106: Expose processors' counters in Stats History

2017-07-21 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1872 Thanks @markap14! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1644: NIFI-11 - Capture StringIndexOutOfBoundsException to preve...

2017-07-19 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1644 Thanks @trixpan! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request #2023: NIFI-4206: Proxy instructions in Admin Guide

2017-07-19 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/2023 NIFI-4206: Proxy instructions in Admin Guide NIFI-4206: - Updating admin guide to include instructions for running NiFi behind a proxy. You can merge this pull request into a Git repository

[GitHub] nifi issue #2019: NIFI-4032: Managed Ranger Authorizer

2017-07-24 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2019 Great find @YolandaMDavis! Will address this and update. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi issue #1980: NIFI-4153: Use a LinkedBlockingQueue instead of a Synchron...

2017-07-06 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1980 Thanks @markap14! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request #1978: NIFI-4127: Composite User Group Providers

2017-07-05 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1978 NIFI-4127: Composite User Group Providers NIFI-4127: - Introducing composite ConfigurableUserGroupProvider and UserGroupProvider. - Adding appropriate unit tests. - Updating object model

[GitHub] nifi issue #1979: NIFI-4151: Updated UpdateAttribute to only create JAXB Con...

2017-07-05 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1979 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1979: NIFI-4151: Updated UpdateAttribute to only create JAXB Con...

2017-07-06 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1979 Thanks @markap14! The update has addressed the test failures and this has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi issue #1980: NIFI-4153: Use a LinkedBlockingQueue instead of a Synchron...

2017-07-05 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1980 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1979: NIFI-4151: Updated UpdateAttribute to only create JAXB Con...

2017-07-05 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1979 @markap14 Looks like the proposed changes are causing unit test failures. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi issue #1962: NIFI-4143 - externalize MAX_CONCURRENT_REQUESTS

2017-07-05 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1962 @pvillard31 Just started reviewing this PR. I'm wondering if the property should be associated with the cluster section instead of the web properties. This property is only relevant when clustered

[GitHub] nifi issue #1697: NIFI-3695 - added proxy dn flag to support providing autho...

2017-04-26 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1697 @YolandaMDavis Code changes look good. However, one thing I noticed is that the error provided when the specified proxied user lacks sufficient permissions could be made a little more user-friendly

[GitHub] nifi pull request #1697: NIFI-3695 - added proxy dn flag to support providin...

2017-04-26 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/1697#discussion_r113531250 --- Diff: nifi-toolkit/nifi-toolkit-admin/src/main/groovy/org/apache/nifi/toolkit/admin/nodemanager/NodeManagerTool.groovy --- @@ -75,6 +77,7 @@ public

[GitHub] nifi issue #1697: NIFI-3695 - added proxy dn flag to support providing autho...

2017-04-27 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1697 @YolandaMDavis I've added another commit [1] to print the response body when possible. If your happy with this addition, I'll amend it to your PR. Thanks. [1] https://github.com/mcgilman

[GitHub] nifi issue #1697: NIFI-3695 - added proxy dn flag to support providing autho...

2017-04-27 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1697 +1 as well. Thanks @YolandaMDavis. This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi issue #2047: NIFI-4210: Add support for OpenId Connect

2017-08-09 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2047 @alopresto This is not something that was introduced in this PR though I am happy to address it here. Will push a new commit shortly. Thanks! --- If your project is set up for it, you can reply

[GitHub] nifi pull request #2047: NIFI-4210: Add support for OpenId Connect

2017-08-02 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2047#discussion_r130878563 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/AccessResource.java

[GitHub] nifi pull request #2047: NIFI-4210: Add support for OpenId Connect

2017-08-02 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2047#discussion_r130882716 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/oidc/OidcService.java

[GitHub] nifi pull request #2047: NIFI-4210: Add support for OpenId Connect

2017-08-02 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2047#discussion_r130878806 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/oidc/OidcService.java

[GitHub] nifi pull request #2047: NIFI-4210: Add support for OpenId Connect

2017-08-02 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2047#discussion_r130884930 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/oidc/OidcService.java

[GitHub] nifi pull request #2047: NIFI-4210: Add support for OpenId Connect

2017-08-02 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2047#discussion_r130879118 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/oidc/OidcService.java

[GitHub] nifi pull request #2047: NIFI-4210: Add support for OpenId Connect

2017-08-02 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2047#discussion_r130943341 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/oidc

[GitHub] nifi pull request #2051: NIFI-4224: Initial implementation of Process Group ...

2017-08-08 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2051#discussion_r131979744 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java

[GitHub] nifi pull request #2051: NIFI-4224: Initial implementation of Process Group ...

2017-08-08 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2051#discussion_r131999511 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java

[GitHub] nifi pull request #2051: NIFI-4224: Initial implementation of Process Group ...

2017-08-08 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2051#discussion_r131998273 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java

[GitHub] nifi pull request #2051: NIFI-4224: Initial implementation of Process Group ...

2017-08-08 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2051#discussion_r131985592 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/dao/impl/StandardProcessGroupDAO.java

[GitHub] nifi pull request #2051: NIFI-4224: Initial implementation of Process Group ...

2017-08-08 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2051#discussion_r131979395 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/dto/ProcessGroupDTO.java

[GitHub] nifi pull request #2051: NIFI-4224: Initial implementation of Process Group ...

2017-08-08 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2051#discussion_r132005935 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java

[GitHub] nifi pull request #2051: NIFI-4224: Initial implementation of Process Group ...

2017-08-08 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2051#discussion_r131983043 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java

[GitHub] nifi pull request #2051: NIFI-4224: Initial implementation of Process Group ...

2017-08-08 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2051#discussion_r131978526 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/dto/VariableRegistryDTO.java

[GitHub] nifi pull request #2051: NIFI-4224: Initial implementation of Process Group ...

2017-08-08 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2051#discussion_r131997868 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java

[GitHub] nifi pull request #2051: NIFI-4224: Initial implementation of Process Group ...

2017-08-08 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2051#discussion_r131993623 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/FlowResource.java --- @@ -640,7

[GitHub] nifi pull request #2051: NIFI-4224: Initial implementation of Process Group ...

2017-08-08 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2051#discussion_r131985519 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/dao/impl/StandardProcessGroupDAO.java

[GitHub] nifi pull request #2051: NIFI-4224: Initial implementation of Process Group ...

2017-08-08 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2051#discussion_r131998712 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java

[GitHub] nifi pull request #2051: NIFI-4224: Initial implementation of Process Group ...

2017-08-08 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2051#discussion_r131994112 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/FlowResource.java --- @@ -640,7

[GitHub] nifi pull request #2051: NIFI-4224: Initial implementation of Process Group ...

2017-08-08 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2051#discussion_r131996939 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java

[GitHub] nifi pull request #2051: NIFI-4224: Initial implementation of Process Group ...

2017-08-08 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2051#discussion_r131983295 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java

[GitHub] nifi pull request #2051: NIFI-4224: Initial implementation of Process Group ...

2017-08-08 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2051#discussion_r131983144 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java

[GitHub] nifi pull request #2051: NIFI-4224: Initial implementation of Process Group ...

2017-08-08 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2051#discussion_r131997934 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java

[GitHub] nifi pull request #2051: NIFI-4224: Initial implementation of Process Group ...

2017-08-08 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2051#discussion_r131983689 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java

[GitHub] nifi pull request #2051: NIFI-4224: Initial implementation of Process Group ...

2017-08-09 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2051#discussion_r132257748 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java

[GitHub] nifi pull request #2051: NIFI-4224: Initial implementation of Process Group ...

2017-08-09 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2051#discussion_r132257197 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/dto/ProcessGroupDTO.java

[GitHub] nifi issue #2044: NIFI-4139 Extract key provider to framework-level service

2017-08-07 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2044 Thanks @alopresto! This has been merged to master. I accidentally forgot to add the 'This closes...' text to the commit message. Would you mind closing this PR out? Thanks! --- If your project

[GitHub] nifi-registry issue #3: NIFIREG-6 Adding nifi-registry-bootstrap module

2017-08-07 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi-registry/pull/3 Thanks @bbende! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #2044: NIFI-4139 Extract key provider to framework-level service

2017-08-04 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2044 @alopresto These refactorings look good. The backward compatibility support for legacy configurations is also solid. One minor thing I'd like to investigate further if we can remove the dependency

[GitHub] nifi issue #2087: NIFI-4295: When determining which controller services to r...

2017-08-16 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2087 @markap14 It appears the changes introduced are causing some test failures. ``` Failed tests: TestStandardControllerServiceProvider.validateEnableServices:506 null

[GitHub] nifi-registry pull request #5: NIFIREG-7 Defining Provider API and initial f...

2017-08-22 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/5#discussion_r134531054 --- Diff: nifi-registry-utils/src/main/java/org/apache/nifi/registry/util/StringUtils.java --- @@ -0,0 +1,99 @@ +/* + * Licensed

[GitHub] nifi-registry issue #5: NIFIREG-7 Defining Provider API and initial filesyst...

2017-08-22 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi-registry/pull/5 Thanks @bbende! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #2051: NIFI-4224: Initial implementation of Process Group level V...

2017-08-17 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2051 Thanks @markap14! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #2087: NIFI-4295: When determining which controller services to r...

2017-08-17 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2087 Thanks @markap14! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1739: NIFI-3776 Correcting links in documentation for SeeAlso an...

2017-05-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1739 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1739: NIFI-3776 Correcting links in documentation for SeeAlso an...

2017-05-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1739 Thanks @bbende! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request #1740: NIFI-3782: Controller Service duplicated during Cop...

2017-05-03 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1740 NIFI-3782: Controller Service duplicated during Copy/Paste - Ensuring referenced Controller Services are not included in copy/paste requests when the Processor is located in a sub group. You can

[GitHub] nifi issue #1726: NIFI-3765 - Added a 'status' operation to Node Manager

2017-05-02 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1726 Thanks @YolandaMDavis. Verified new capabilities and existing functions of the node-manager tool. This has been merged to master. --- If your project is set up for it, you can reply to this email

[GitHub] nifi issue #1718: NIFI-391 - Introduce the ability to deprecate a component

2017-05-15 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1718 Thanks @trixpan! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request #1784: NIFI-3853: Filtering out control characters

2017-05-11 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1784 NIFI-3853: Filtering out control characters NIFI-3853: - Filtering out certain control characters and unpaired Unicode surrogate codepoints prior to saving the flow.xml. You can merge

[GitHub] nifi issue #1718: NIFI-391 - Introduce the ability to deprecate a component

2017-05-10 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1718 Yes that was a typo. Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi issue #1718: NIFI-391 - Introduce the ability to deprecate a component

2017-05-09 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1718 Ok sounds good. Let's proceed with this PR and then we can file another JIRA for the UI work. I just started reviewing and noticed that the `DocumentTypeDTO` is missing the deprecation flag

[GitHub] nifi pull request #1780: NIFI-3865: Fix issues viewing content when clustere...

2017-05-10 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1780 NIFI-3865: Fix issues viewing content when clustered NIFI-3865: - Obtaining the appropriate input stream after accessing content. The stream was being consumed into a buffer and was not longer

[GitHub] nifi issue #1817: NIFI-3923: Only start processors after repositories have b...

2017-05-17 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1817 Thanks @markap14. This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1818: [NIFI-3906] Introduce additional validation when handling ...

2017-05-17 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1818 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1818: [NIFI-3906] Introduce additional validation when handling ...

2017-05-17 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1818 Thanks @scottyaslan. This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request #1801: NIFI-3868: Bulletin Merging Issue

2017-05-15 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1801 NIFI-3868: Bulletin Merging Issue NIFI-3868: - Ensuring we do not attempt to group bulletins that lack permissions. - Only group bulletins when all nodes report the same message

[GitHub] nifi issue #1819: NIFI-3917: Use a default value of 'false' for CSV Reader's...

2017-05-17 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1819 Will review/merge... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1819: NIFI-3917: Use a default value of 'false' for CSV Reader's...

2017-05-17 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1819 Thanks @markap14! This has been merged to master. And thanks @kevdoran reviewing too! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi issue #1799: NIFI-3896 - Makes DeprecationNotice more intuitive

2017-05-17 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1799 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1799: NIFI-3896 - Makes DeprecationNotice more intuitive

2017-05-17 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1799 Thanks @trixpan. This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1812: NIFI-1963 Forces a node reconnecting to a cluster to inher...

2017-05-17 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1812 Thanks @jtstorck. This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1812: NIFI-1963 Forces a node reconnecting to a cluster to inher...

2017-05-17 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1812 Will pick up review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] nifi pull request #1803: NIFI-3901: Address Provenance Rest Api issues

2017-05-15 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1803 NIFI-3901: Address Provenance Rest Api issues NIFI-3901: - Addressing response code of POST /provenance/lineage. - Ensuring cluster node details are set accordingly. You can merge this pull

[GitHub] nifi issue #1808: NIFI-3904 Adding logic to only reload when incoming bundle...

2017-05-16 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1808 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1817: NIFI-3923: Only start processors after repositories have b...

2017-05-17 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1817 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1785: [NIFI-3830] force browsers to use URLSearchParams polyfill...

2017-05-13 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1785 Thanks @scottyaslan. This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request #1718: NIFI-391 - Introduce the ability to deprecate a com...

2017-05-13 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/1718#discussion_r116357519 --- Diff: nifi-api/src/main/java/org/apache/nifi/annotation/documentation/DeprecationNotice.java --- @@ -0,0 +1,51 @@ +/* + * Licensed

[GitHub] nifi pull request #1781: NIFI-3837: Being more specific with escaping of bac...

2017-05-10 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1781 NIFI-3837: Being more specific with escaping of back references in ReplaceText NIFI-3837: - Being more specific regarding the escaping of back references in evaluated expressions. You can

[GitHub] nifi pull request #1838: NIFI-3933: Monitor heartbeats based on connected no...

2017-05-22 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1838 NIFI-3933: Monitor heartbeats based on connected nodes NIFI-3933: - When monitoring heartbeats use the connected nodes as the basis for the check. This addresses the case when a node

[GitHub] nifi pull request #1844: NIFI-3955: Filtering out the EventTime searchable f...

2017-05-23 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1844 NIFI-3955: Filtering out the EventTime searchable field for all implementation of ProvenanceRepository NIFI-3955: - Filtering out the EventTime searchable field for all implementation

[GitHub] nifi issue #1848: [NIFI-3925] bound width of combo options drop down text

2017-05-24 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1848 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1644: NIFI-11 - Capture StringIndexOutOfBoundsException to preve...

2017-05-24 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1644 Pretty sure it still needs an update. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #1849: [NIFI-3943] align combo option item toolips to hover close...

2017-05-24 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1849 Thanks @scottyaslan. This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1848: [NIFI-3925] bound width of combo options drop down text

2017-05-24 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1848 @scottyaslan Would it be possible to update this PR to not take a percentage based approach? The component(s) selected by the combo plugin can have any width. Taking a percentage based approach may

[GitHub] nifi issue #1808: NIFI-3904 Adding logic to only reload when incoming bundle...

2017-05-16 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1808 Thanks @bbende. This looks good and has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi issue #1872: NIFI-106: Expose processors' counters in Stats History

2017-05-30 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1872 @markap14 - Counters are currently protected in access policies using a global resource. This is due to the fact that there are instance based Counters and a corresponding type based Counter

<    1   2   3   4   5   6   7   8   9   10   >