GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1087
Not showing View Configuration context menu option for Process Groups
NIFI-2843:
- Removing the View Configuration menu item from the context menu on
Process Groups.
You can merge this pull
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1090
UI - Policy Management Improvements
NIFI-2849:
- Showing process group name when possible.
- Providing a link to jump to the process group defined in the effective
policy.
- Preventing
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1095
Cluster - Merging response when the node is the Cluster Cooridinator
NIFI-2777:
NIFI-2856:
- Only performing response merging when the node is the cluster
cooridinator even if there is a
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1082
Reviewing..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1082
The proposed changes seem to help introduce some space from the upper left
hand corner of the canvas but don't seem to account for the entire width of the
graph controls. Could it possible
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1096
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1096
Thanks @scottyaslan! This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1091
Thanks @combineads. This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1089
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1085
Looks good @trixpan! Thanks this has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1106
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1106
Looks good @scottyaslan! This has been merged to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1094
Thanks @scottyaslan. This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1089
Looks good @scottyaslan. This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1099
Thanks @scottyaslan! This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1109
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1109
Looks like lots of debug level logging was added around the wait/notify of
the monitor used to lock during requests. However, in the case there was a
dissenting node in phase one of a two phase
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1109
Thanks @markap14! This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1122
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1080
Can someone else finish up the review of this PR? I helped contribute to
this PR and would prefer someone else's eyes on. Thanks!
---
If your project is set up for it, you can reply to this
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1122
Thanks @ijokarumawak! This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1136
Hey @simplesteph, thanks for the PR!
I'm not sure we can merge this in as is. I'm afraid that changing the
format of the of pre-existing values (like all time values in this c
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1136
Our use of swagger is simply for generating the documentation. The
swagger.json is generated into the target directory and is not made available
as part of the released source or convenience
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1136
NiFi follows the semantic versioning guidelines. What your suggesting is
changing the meaning of those fields. They are strings that are meant to be
human-readable (one with the time and the other
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2170
Thanks @yuri1969! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2178
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2178
Thanks @yuri1969! This has been merged to master. Just FYI - I made a minor
tweak to your commit to ensure the counter name was properly escaped prior to
passing it to `nfDialog`.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2178
@yuri1969 no worries! It was a trivial tweak and the rest looked great.
Thanks again!
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2084
Thanks @alopresto! Looks good. This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2195
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2200
@yuri1969 What is your JIRA username? I should be able to grant you
additional permissions. Thanks.
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2206
NIFI-: Upgrade to Jersey 2.x
NIFI-:
- Upgrading to Jersey 2.x.
- Updating NOTICE files where necessary.
You can merge this pull request into a Git repository by running:
$ git
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2206
This PR upgrades Jersey throughout NiFi where it is used directly. Most
transitive Jersey dependencies are left intact. The most significant changes
are centered in the clustering framework
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2206
Thanks @bbende. I've pushed another commit that addresses the checkstyle
issues.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2209
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2209
Thanks @andrewmlim! This has been merged to master.
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2210
NIFI-4481: Visualize Processors Running on Primary Node
NIFI-4481:
- Adding support for visualizing if a component is scheduled for primary
node only.
[Visualization](https
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2216
NIFI-4497: Fixing issue preventing separators in sub context menus
NIFI-4497:
- Fixing issue preventing separators in sub context menus.
@scottyaslan Was hoping you could take a peek at
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2219
NiFi-4436: Add UI controls for starting/stopping/reverting flow versioning
@markap14 Please review the frontend/backend integration of the early
version control capabilities utilizing the local
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2219
I am going to update this PR to indicate that it is a work in progress as
merging will break the build because it depends on Registry artifacts. Will
hold off on merging until we either release the
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2217
Reviewing...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2217
Thanks @jtstorck! This has been merged to master.
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2227
NIFI-4518: Fixing URI issue when querying the bulletin board with many
source ids
NIFI-4518:
- When the URI is too long, invoking the bulletin board multiple times for
all specified component
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2253
Will review...
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2261
NIFI-4587: Fixing newlines in comment fields
NIFI-4587:
- Updating styles to allow for newlines in Process Group, Processor,
Controller Service, and Reporting Task comments.
You can merge this
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2262
NIFI-4591: Ensure View Details is button is visible when appropriate
NIFI-4591:
- Ensuring View Details button is visible if the user has read access and
the service is defined in the current
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2263
NIFI-4593: Ensuring jackson dependencies are bundled
NIFI-4593:
- Ensuring the necessary jackson dependencies are bundled.
You can merge this pull request into a Git repository by running
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2195
@yuri1969 @pvillard31 Ugh sorry guys. I totally forgot about this. I've
been swamped with some other things at the moment. I remember jumping on this
PR because I wanted to verify the case w
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2253
Thanks @markap14! This has been merged to master.
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2274
NIFI-4567: LdapUserGroupProvider: Allow admin to configure group membership
attribute
NIFI-4567
- Adding new properties to allow the referenced attribute of a user/group
to be configurable
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2276
@sbouchex This is a great catch and thanks for the contribution! Reviewing
the code it appears that the runStatus was moved into the status snapshot
likely during the 0.x -> 1.x transtion. T
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2276#discussion_r151693413
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/dto/DtoFactory.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2276#discussion_r151695374
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/dto/DtoFactory.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2276#discussion_r151706697
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/dto/DtoFactory.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2276#discussion_r151711473
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/dto/DtoFactory.java
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2277
NIFI-4614: ManagedRangerAuthorizer: Wildcard policies
NIFI-4614:
- Updating the types of resources that are filtered out for viewing
purposes. Updates include resources with no values and
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2276
Thanks @sbouchex! This has been merged to master.
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2278
NIFI-4617: TestCSVRecordReader Test Failure
NIFI-4617:
- Ensuring a charset is specified when converting a string into bytes.
You can merge this pull request into a Git repository by running
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2279
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2279
Thanks @alopresto! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2298
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2298
Thanks @markap14! This has been merged to master.
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2306
NIFI-4646: AbstractRecordProcessor: Report reason for
SchemaNotFoundException
NIFI-4646:
- Ensuring the reason behind the SchemaNotFoundException is reported when
interacting with the
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2305
+1 Looks good @joewitt! Will merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2309
Will review...
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2311
NIFI-4645: Remove activation rules for include the grpc bundle
NIFI-4645:
- Removing rule based activation because it was causing the
generateArchives profile to not activate. Now the grpc
Github user mcgilman closed the pull request at:
https://github.com/apache/nifi/pull/2311
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2311
Closing because this wasn't doing exactly what I thought it was.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2313
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2313
Thanks @joewitt! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2318
Thanks @joewitt! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2319
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2319
Thanks @joewitt! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2319
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2320
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2320
Thanks @joewitt! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi-registry/pull/54
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2341
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi-registry/pull/54
Thanks @bbende! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2341
Thanks @kevdoran! I've merged this to master and I also amended your to
include the updated documentation in the admin guide too.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2219
I believe this PR is ready for testing. Please proceed with reviewing.
Please note that due to a dependency on the Apache NiFi Registry, this PR
cannot be merged until the Registry is released and
Github user mcgilman commented on the issue:
https://github.com/apache/nifi-registry/pull/59
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi-registry/pull/59
Thanks @bbende! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2346
@rsomas Thanks for submitting a PR! Reading through the JIRA, I wanted to
get your take on possibly taking a slightly different approach as it appears
that the attribute that identifies the user may
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2352
NIFI-4689: WriteAheadProvenance Properties
NIFI-4689:
- Ensuring all provenance properties are represented in nifi.properties.
You can merge this pull request into a Git repository by running
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2353
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2353
Thanks @ijokarumawak @aperepel! This has been merged to master.
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2358
NIFI-: Ensuring the /nifi-api/controller redirection filter runs
NIFI-:
- Ensure the /nifi-api/controller redirection filter executes before
matching.
You can merge this pull request
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2219
@JPercivall Thanks for taking the time to check this out. The behavior your
seeing regarding the propagation of the local modification indicator is
correct. When there is a nested version Process
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2219#discussion_r159233407
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/WEB-INF/partials/canvas/save-flow-version-dialog.jsp
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2219#discussion_r159233690
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/WEB-INF/partials/canvas/save-flow-version-dialog.jsp
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2219#discussion_r159240358
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/registry/flow/StandardFlowRegistryClient.java
Github user mcgilman closed the pull request at:
https://github.com/apache/nifi/pull/2358
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2358
Thanks @alopresto! Closing...
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2365
NIFI-4092: Removing direct dependency on jaxb
NIFI-4092:
- Removing direct dependency on jaxb.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2219
@scottyaslan Thanks! I've addressed issues with the menu going off the
screen. If you have a second to verify again, it would be appreciated.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2365
@joewitt Looks like the previous implementation using a `com.sun` class
used two space indentation. Primarily investigation suggests a few options...
- Accept a new default of 4 spaces
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2365
@joewitt I agree that we should remain consistent with the older format. I
don't think I fully explained option 3. The stax-utils artifact appears to
package the same `com.sun` class we
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2365
@joewitt I agree regarding the questionable L&N on option 3. I also agree
with your take on option two. Let me update the PR.
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2370
NIFI-4733: Addressing two phase commit logic issue in variable registry
NIFI-4733:
- Resolving logic issue in two phase commit when updating variable registry.
You can merge this pull request
701 - 800 of 1205 matches
Mail list logo
