[GitHub] nifi pull request #1157: NIFI-2791 Adding 'math' expression language functio...

2016-10-25 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1157#discussion_r84855173 --- Diff: nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/MathEvaluator.java

[GitHub] nifi issue #1157: NIFI-2791 Adding 'math' expression language function

2016-10-25 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1157 +1 thanks @JPercivall ! Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi pull request #1163: NIFI-2956 - GetHDFS - fixed directory path evaluati...

2016-10-27 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1163 NIFI-2956 - GetHDFS - fixed directory path evaluation You can merge this pull request into a Git repository by running: $ git pull https://github.com/pvillard31/nifi NIFI-2956

[GitHub] nifi pull request #1166: NIFI-2963 FetchHDFS should support Compression Code...

2016-10-28 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1166 NIFI-2963 FetchHDFS should support Compression Codec property You can merge this pull request into a Git repository by running: $ git pull https://github.com/pvillard31/nifi fetchhdfs

[GitHub] nifi pull request #1163: NIFI-2956 - GetHDFS - fixed directory path evaluati...

2016-11-02 Thread pvillard31
Github user pvillard31 closed the pull request at: https://github.com/apache/nifi/pull/1163 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi issue #1166: NIFI-2963 FetchHDFS should support Compression Codec prope...

2016-11-02 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1166 duh... I must admit I did copy/paste the logic from the GetHDFS processor and didn't catch the loop over files in the GetHDFS processor. Anyway, this should now make much more sense. Thank

[GitHub] nifi pull request #1181: NIFI-1322 - PutHDFS - allow file append resolution

2016-11-03 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1181 NIFI-1322 - PutHDFS - allow file append resolution Two remarks: - LocalFileSystem object used for unit tests does not implement the append method. - Based on HDFS-4600 (https

[GitHub] nifi pull request #1181: NIFI-1322 - PutHDFS - allow file append resolution

2016-11-04 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1181#discussion_r86526545 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java --- @@ -74,9 +75,15

[GitHub] nifi pull request #1181: NIFI-1322 - PutHDFS - allow file append resolution

2016-11-04 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1181#discussion_r86528178 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java --- @@ -315,21 +328,24

[GitHub] nifi issue #1195: NIFI-3013 GetSNMP fix stop and start null pointer exceptio...

2016-11-10 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1195 +1, merging. Thanks @joaohf ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] nifi issue #1196: NIFI-3014 GetSNMP add textual oid attribute to flowfile

2016-11-10 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1196 Hi @joaohf, thanks for the PR. Do you agree that this will make sense if and only if we are doing a GET and not a WALK? Besides you will get the same result having an UpdateAttribute processor

[GitHub] nifi issue #1204: [NIFI-3021] remove white-space:no-wrap on view configurati...

2016-11-10 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1204 +1 confirmed fix when testing with ExecuteProcessor, merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi pull request #1206: NIFI-2912 Allow custom text in GenerateFlowFile

2016-11-10 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1206 NIFI-2912 Allow custom text in GenerateFlowFile You can merge this pull request into a Git repository by running: $ git pull https://github.com/pvillard31/nifi NIFI-2912 Alternatively you

[GitHub] nifi issue #1206: NIFI-2912 Allow custom text in GenerateFlowFile

2016-11-11 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1206 Hey @alopresto. I definitely agree with you. In fact what do you think about setting 0B as default File Size value and setting Text as default Data Format? This way user is only required to set

[GitHub] nifi pull request #1211: NIFI-2751 - Pull batch in round-robin manner - fix ...

2016-11-12 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1211 NIFI-2751 - Pull batch in round-robin manner - fix for / by 0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/pvillard31/nifi NIFI-2751

[GitHub] nifi pull request #1234: NIFI-2985 Update User Guide for Backpressure Visual...

2016-11-16 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1234#discussion_r88317871 --- Diff: nifi-docs/src/main/asciidoc/user-guide.adoc --- @@ -759,7 +759,7 @@ image:addConnect.png["Connection Bubble"] image:processor-

[GitHub] nifi issue #1234: NIFI-2985 Update User Guide for Backpressure Visual indica...

2016-11-16 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1234 +1 merging... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] nifi pull request #1243: NIFI-3016 - Allow template overriding

2016-11-17 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1243 NIFI-3016 - Allow template overriding You can merge this pull request into a Git repository by running: $ git pull https://github.com/pvillard31/nifi NIFI-3016 Alternatively you can review

[GitHub] nifi pull request #1243: NIFI-3016 - Allow template overriding

2016-11-17 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1243#discussion_r88567738 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-actions.js --- @@ -1271,7 +1272,43

[GitHub] nifi issue #1258: NIFI-3082: Fixed status code handling in PutElasticsearchH...

2016-11-22 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1258 +1 LGTM, checked the code and ran contrib check. Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi issue #1255: NIFI-3078: Test InvokeScriptedProcessor with JS.

2016-11-22 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1255 LGTM, tests are checking a large set of cases, ran a contrib-check, I'm a +1. Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] nifi issue #1257: NIFI-3041 Removed references to Windows start-nifi.bat and...

2016-11-22 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1257 +1. Merging to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] nifi issue #1311: NIFI-3175 Fix a bug in the ValidateCSV processor to handle...

2016-12-15 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1311 @Wesley-Lawrence You're right, the appveyor failure is not related. Just reviewed your PR, and it LGTM: reproduced the error, confirmed the fix, contrib-check. All good! Thanks fo

[GitHub] nifi pull request #1360: NIFI-3259 - Process group level option in Ambari re...

2016-12-27 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1360 NIFI-3259 - Process group level option in Ambari reporting task Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi pull request #1361: NIFI-3231 Added EL support to hostname and port in ...

2016-12-28 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1361 NIFI-3231 Added EL support to hostname and port in PutTCP/UDP Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi pull request #1362: NIFI-3228 added s3.contenttype in PutS3Object

2016-12-28 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1362 NIFI-3228 added s3.contenttype in PutS3Object Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the

[GitHub] nifi issue #1361: NIFI-3231 Added EL support to hostname and port in PutTCP/...

2016-12-28 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1361 Good catch @ddewaele, thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi pull request #1363: NIFI-3183 Added command and arguments as FF attribu...

2016-12-28 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1363 NIFI-3183 Added command and arguments as FF attributes in ExecuteProc… …ess processor Thank you for submitting a contribution to Apache NiFi. In order to streamline the

[GitHub] nifi pull request #1365: NIFI-3164 Added message at startup to log NAR loadi...

2016-12-28 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1365 NIFI-3164 Added message at startup to log NAR loading Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to

[GitHub] nifi issue #1361: NIFI-3231 Added EL support to hostname and port in PutTCP/...

2016-12-29 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1361 Sure @ddewaele, feel free to open a JIRA for the HTTP processors and submit a PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi pull request #1366: NIFI-3164 Added NAR loading duration

2016-12-29 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1366 NIFI-3164 Added NAR loading duration Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following

[GitHub] nifi pull request #1367: NIFI-3139 Added host:port list and non empty EL val...

2016-12-29 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1367 NIFI-3139 Added host:port list and non empty EL validators in Standar… …dValidators Thank you for submitting a contribution to Apache NiFi. In order to streamline the review

[GitHub] nifi pull request #1368: NIFI-3121 Remove read permissions on proxy resource...

2016-12-29 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1368 NIFI-3121 Remove read permissions on proxy resource for Node Identities Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we

[GitHub] nifi pull request #1369: NIFI-3114 Updated documentation of ListenHTTP

2016-12-29 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1369 NIFI-3114 Updated documentation of ListenHTTP Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the

[GitHub] nifi pull request #1370: NIFI-3057 Added provenance events to PutElasticsear...

2016-12-29 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1370 NIFI-3057 Added provenance events to PutElasticsearch and FetchElasti… …csearch Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of

[GitHub] nifi pull request #1374: NIFI-3269 added call to onPropertyModified when upd...

2016-12-30 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1374 NIFI-3269 added call to onPropertyModified when updating controller s… …ervices Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of

[GitHub] nifi pull request #1375: NIFI-3004 Improved StandardSSLContextService custom...

2016-12-30 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1375 NIFI-3004 Improved StandardSSLContextService customValidate Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to

[GitHub] nifi issue #1375: NIFI-3004 Improved StandardSSLContextService customValidat...

2016-12-30 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1375 **Note**: This PR needs #1374 first, otherwise the unit test will fail. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi pull request #1377: NIFI-2968 Improved message when ExecuteSQL hits uns...

2016-12-30 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1377 NIFI-2968 Improved message when ExecuteSQL hits unsupported SQL types Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask

[GitHub] nifi issue #1373: NIFI-3266 Added EL support for basePath and port in Listen...

2016-12-30 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1373 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] nifi pull request #1373: NIFI-3266 Added EL support for basePath and port in...

2016-12-30 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1373#discussion_r94231391 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListenHTTP.java --- @@ -16,22

[GitHub] nifi pull request #1373: NIFI-3266 Added EL support for basePath and port in...

2016-12-30 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1373#discussion_r94231446 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestListenHTTP.java --- @@ -0,0

[GitHub] nifi issue #1353: NIFI-3247: Removing unnecessary authorization check during...

2016-12-30 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1353 Visually verified code change, full build with contrib-check, manually fixed conflict with master. LGTM. Merged to master. Thanks @mcgilman! --- If your project is set up for it, you can reply to

[GitHub] nifi pull request #1378: NIFI-2952 Fixed search value validation in ReplaceT...

2016-12-30 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1378 NIFI-2952 Fixed search value validation in ReplaceText Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to

[GitHub] nifi pull request #1379: NIFI-2944 check remote input hostname at startup

2016-12-30 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1379 NIFI-2944 check remote input hostname at startup Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the

[GitHub] nifi issue #1148: NIFI-2923 Add expression language support to Kerberos para...

2016-12-30 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1148 Hi @mauriziocolleluori, If you still encounter issues in UI when testing properties while using expression language, please check that nifi.kerberos.krb5.file is correctly set in your

[GitHub] nifi pull request #1380: NIFI-2914 Fixed log message in AbstractMongoProcess...

2017-01-03 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1380 NIFI-2914 Fixed log message in AbstractMongoProcessor Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to

[GitHub] nifi pull request #1381: NIFI-2908 Added TimeZone to toDate() and format() E...

2017-01-03 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1381 NIFI-2908 Added TimeZone to toDate() and format() EL Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure

[GitHub] nifi pull request #1382: NIFI-2860 Use different properties for JVM Heap Max...

2017-01-03 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1382 NIFI-2860 Use different properties for JVM Heap Max and Min values Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi pull request #1383: NIFI-2859 - Ignore files starting with a dot in Lis...

2017-01-03 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1383 NIFI-2859 - Ignore files starting with a dot in ListHDFS Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to

[GitHub] nifi issue #1037: NIFI-1893 Add processor for validating JSON

2017-01-03 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1037 @basvank Due to licensing issues: https://issues.apache.org/jira/browse/NIFI-2991 We unfortunately had to remove this processor... we are looking for a new solution using another

[GitHub] nifi pull request #1384: NIFI-2839 Add a confirmation dialog when deleting a...

2017-01-03 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1384 NIFI-2839 Add a confirmation dialog when deleting a Controller Service Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask

[GitHub] nifi pull request #1385: NIFI-2761 Fixed error message in bootstrap

2017-01-03 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1385 NIFI-2761 Fixed error message in bootstrap Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the

[GitHub] nifi pull request #1387: NIFI-1797 - Added compression codec property to Cre...

2017-01-04 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1387 NIFI-1797 - Added compression codec property to CreateHadoopSequenceF… …ile processor Thank you for submitting a contribution to Apache NiFi. In order to streamline the

[GitHub] nifi issue #1384: NIFI-2839 Add a confirmation dialog when deleting a Contro...

2017-01-04 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1384 Thanks for the review @mcgilman and @andrewmlim ! I changed the wording in the confirmation dialog and pushed another commit to address reporting tasks. --- If your project is set up for it

[GitHub] nifi issue #1391: NIFI-2840: Ensuring templates are sorted based on timestam...

2017-01-04 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1391 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] nifi issue #1391: NIFI-2840: Ensuring templates are sorted based on timestam...

2017-01-04 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1391 Looks good to me, did a full build and created/added templates, ordering is as expected. Merged to master, thanks @mcgilman! --- If your project is set up for it, you can reply to this email and

[GitHub] nifi issue #1375: NIFI-3004 Improved StandardSSLContextService customValidat...

2017-01-05 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1375 Hey @alopresto, thanks for the review! I added your work as an additional commit to this PR. It looks good to me. Maybe the threshold could be added as a controller service property (however it

[GitHub] nifi issue #1397: NIFI-3286 Updating occurances of 'Scope.NODE' in Developer...

2017-01-05 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1397 +1, merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] nifi issue #1396: NIFI-3283 Fixing typo in UpdateAttribute error message

2017-01-05 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1396 +1, merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] nifi issue #1398: NIFI-3275: Correcting SocketChannelSender log warning mess...

2017-01-05 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1398 +1, merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] nifi issue #1386: NIFI-3274 Adding WriteAheadLog configuration options to Wr...

2017-01-05 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1386 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] nifi issue #1386: NIFI-3274 Adding WriteAheadLog configuration options to Wr...

2017-01-05 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1386 +1, LGTM, launched NiFi with various combinations of parameters and observed behavior was as expected. Merged to master. --- If your project is set up for it, you can reply to this email and have

[GitHub] nifi issue #1388: NIFI-3276 - FileSystemRepository.getPath() only check exis...

2017-01-05 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1388 +1, merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] nifi pull request #1400: NIFI-957 Added the possibility to use DefaultSchedu...

2017-01-05 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1400 NIFI-957 Added the possibility to use DefaultSchedule annotation in r… …eporting tasks Thank you for submitting a contribution to Apache NiFi. In order to streamline the

[GitHub] nifi pull request #1401: NIFI-3290 Reporting task to send bulletins with S2S

2017-01-05 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1401 NIFI-3290 Reporting task to send bulletins with S2S Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure

[GitHub] nifi pull request #1383: NIFI-2859 - Ignore files starting with a dot in Lis...

2017-01-06 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1383#discussion_r94956675 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/ListHDFS.java --- @@ -176,7 +176,7

[GitHub] nifi pull request #1403: NIFI-3293 - Expose counters to reporting tasks, and...

2017-01-06 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1403 NIFI-3293 - Expose counters to reporting tasks, and send counters dat… …a in Ambari reporting task Thank you for submitting a contribution to Apache NiFi. In order to

[GitHub] nifi issue #1383: NIFI-2859 - Ignore files starting with a dot in ListHDFS

2017-01-06 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1383 @bbende: I added the file filter property as suggested. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] nifi pull request #1328: NIFI-1682 Adding RollingWindowOperation processor

2017-01-06 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1328#discussion_r95008584 --- Diff: nifi-nar-bundles/nifi-stateful-analysis-bundle/nifi-stateful-analysis-processors/src/main/java/org/apache/nifi/processors/stateful/analysis

[GitHub] nifi pull request #1328: NIFI-1682 Adding RollingWindowOperation processor

2017-01-06 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1328#discussion_r95007556 --- Diff: nifi-nar-bundles/pom.xml --- @@ -55,13 +55,13 @@ nifi-scripting-bundle nifi-elasticsearch-bundle nifi-amqp

[GitHub] nifi pull request #1328: NIFI-1682 Adding RollingWindowOperation processor

2017-01-06 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1328#discussion_r95008090 --- Diff: nifi-nar-bundles/nifi-stateful-analysis-bundle/nifi-stateful-analysis-processors/src/main/java/org/apache/nifi/processors/stateful/analysis

[GitHub] nifi pull request #1328: NIFI-1682 Adding RollingWindowOperation processor

2017-01-06 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1328#discussion_r95009399 --- Diff: nifi-nar-bundles/nifi-stateful-analysis-bundle/nifi-stateful-analysis-processors/src/test/java/org/apache/nifi/processors/stateful/analysis

[GitHub] nifi pull request #1328: NIFI-1682 Adding RollingWindowOperation processor

2017-01-06 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1328#discussion_r95009109 --- Diff: nifi-nar-bundles/nifi-stateful-analysis-bundle/nifi-stateful-analysis-processors/src/main/java/org/apache/nifi/processors/stateful/analysis

[GitHub] nifi pull request #1328: NIFI-1682 Adding RollingWindowOperation processor

2017-01-06 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1328#discussion_r95007532 --- Diff: nifi-nar-bundles/pom.xml --- @@ -55,13 +55,13 @@ nifi-scripting-bundle nifi-elasticsearch-bundle nifi-amqp

[GitHub] nifi pull request #1328: NIFI-1682 Adding RollingWindowOperation processor

2017-01-06 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1328#discussion_r95008179 --- Diff: nifi-nar-bundles/nifi-stateful-analysis-bundle/nifi-stateful-analysis-processors/src/main/java/org/apache/nifi/processors/stateful/analysis

[GitHub] nifi pull request #1328: NIFI-1682 Adding RollingWindowOperation processor

2017-01-06 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1328#discussion_r95008505 --- Diff: nifi-nar-bundles/nifi-stateful-analysis-bundle/nifi-stateful-analysis-processors/src/main/java/org/apache/nifi/processors/stateful/analysis

[GitHub] nifi pull request #1409: NIFI-1962 - Fixed NPE in toDate() EL function

2017-01-10 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1409 NIFI-1962 - Fixed NPE in toDate() EL function Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the

[GitHub] nifi pull request #1411: NIFI-3309 ensures that CS are deleted when a proces...

2017-01-11 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1411 NIFI-3309 ensures that CS are deleted when a process group is deleted Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask

[GitHub] nifi issue #1409: NIFI-1962 - Fixed NPE in toDate() EL function

2017-01-18 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1409 Hey @ijokarumawak, thanks for the review. You are absolutely right, I updated the PR accordingly. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] nifi pull request #2138: NIFI-4371 - add support for query timeout in Hive p...

2018-01-09 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2138#discussion_r160459279 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/AbstractHiveQLProcessor.java --- @@ -75,6

[GitHub] nifi pull request #2138: NIFI-4371 - add support for query timeout in Hive p...

2018-01-09 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2138#discussion_r160465819 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/PutHiveQL.java --- @@ -232,6 +233,13

[GitHub] nifi pull request #2138: NIFI-4371 - add support for query timeout in Hive p...

2018-01-09 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2138#discussion_r160469685 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/PutHiveQL.java --- @@ -232,6 +233,13

[GitHub] nifi pull request #2391: NIFI-4747 - Removed directory existence check in Ge...

2018-01-09 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/2391 NIFI-4747 - Removed directory existence check in GetHDFS Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to

[GitHub] nifi issue #2398: NIFI-4767: Fixed issues with RecordPath using the wrong fi...

2018-01-11 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2398 +1, merging to master, thanks @markap14 ---

[GitHub] nifi issue #2310: NIFI-4428: Add PutDruidRecord processor and DruidTranquili...

2018-01-13 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2310 Hi guys, @joewitt - are you a +1 on the L&N part? I'm a +1 on the code and can take care of merging it. ---

[GitHub] nifi issue #2056: NIFI-4262 - MergeContent - option to add merged uuid in or...

2018-01-14 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2056 Hey @markap14, I rebased against master and followed your recommandations. Let me know if I missed something! Thanks for the review! ---

[GitHub] nifi issue #2399: NIFI-4748 Add endpoint override to Kinesis processors

2018-01-17 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2399 +1, merging to master, thanks @jfrazee ---

[GitHub] nifi issue #2401: NIFI-4759 Fixed a bug that left a hard-coded reference to ...

2018-01-17 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2401 +1, LGTM, thanks for the PR @MikeThomsen and thanks for the review @mgaido91 ---

[GitHub] nifi issue #2336: NIFI-4688 - PutParquet should have RemoteOwner and RemoteG...

2018-01-17 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2336 Hey @panelladavide - I think the last version of your PR is missing some parts of your code. Can you take a look? Could you rebase it against master and squash commits into a single one? ---

[GitHub] nifi issue #2402: NIFI-4770 ListAzureBlobStorage now writes azure.container ...

2018-01-18 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2402 Thanks @zenfenan, +1, merging to master ---

[GitHub] nifi-registry pull request #92: NIFIREG-122 - add build status to main READM...

2018-01-18 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi-registry/pull/92 NIFIREG-122 - add build status to main README You can merge this pull request into a Git repository by running: $ git pull https://github.com/pvillard31/nifi-registry NIFIREG-122

[GitHub] nifi pull request #2391: NIFI-4747 - Removed directory existence check in Ge...

2018-01-19 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2391#discussion_r162701033 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/GetHDFS.java --- @@ -220,16 +220,6

[GitHub] nifi issue #2413: NIFI-4791 Made external links open in new windows and fixe...

2018-01-20 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2413 +1, merging to master, thanks @andrewmlim ---

[GitHub] nifi issue #2424: NIFI-4393: Handle database specific identifier escape char...

2018-01-23 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2424 Code LGTM @ijokarumawak. I'm a +1 on this PR but will wait a bit in case @mattyb149 or someone else wants to double check. ---

[GitHub] nifi issue #2422: NIFI-4773: Moved DB Fetch processors' connection code from...

2018-01-23 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2422 +1, merging to master. Build failed on travis because it took too long but local build with contrib check is OK. ---

[GitHub] nifi pull request #2430: NIFI-4809 - Implement a SiteToSiteMetricsReportingT...

2018-01-23 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/2430 NIFI-4809 - Implement a SiteToSiteMetricsReportingTask To avoid some code duplication, I moved few utilitary classes into the reporting-utils package. And I also added two metrics (available

[GitHub] nifi pull request #2426: NIFI-4790: support HTTPS Proxy in InvokeHTTP

2018-01-24 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2426#discussion_r163476600 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java --- @@ -513,6

[GitHub] nifi pull request #2426: NIFI-4790: support HTTPS Proxy in InvokeHTTP

2018-01-24 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2426#discussion_r163476469 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java --- @@ -213,11

[GitHub] nifi pull request #2426: NIFI-4790: support HTTPS Proxy in InvokeHTTP

2018-01-24 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2426#discussion_r163476703 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java --- @@ -513,6

<    1   2   3   4   5   6   7   8   9   10   >