[GitHub] nifi issue #2224: NIFI-4515 - Enabled EL on Kerberos properties for Kafka 0....

2018-01-04 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2224 I just rebased against master and added 1.0 Kafka processors. ---

[GitHub] nifi pull request #2138: NIFI-4371 - add support for query timeout in Hive p...

2018-01-04 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2138#discussion_r159671901 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/PutHiveQL.java --- @@ -233,6 +234,7

[GitHub] nifi pull request #2138: NIFI-4371 - add support for query timeout in Hive p...

2018-07-30 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2138#discussion_r206334616 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/AbstractHiveQLProcessor.java --- @@ -75,6

[GitHub] nifi pull request #2138: NIFI-4371 - add support for query timeout in Hive p...

2018-07-30 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2138#discussion_r206334896 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/AbstractHiveQLProcessor.java --- @@ -76,6

[GitHub] nifi issue #2924: NIFI-5450: Added ENDPOINT_OVERRIDE to AWS SQS processors

2018-07-30 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2924 +1, merging to master, thanks @zenfenan ---

[GitHub] nifi pull request #2138: NIFI-4371 - add support for query timeout in Hive p...

2018-07-30 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2138#discussion_r206335572 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/AbstractHiveQLProcessor.java --- @@ -75,6

[GitHub] nifi issue #2914: NIFI-5448 Added failure relationship to UpdateAttributes t...

2018-07-26 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2914 @MikeThomsen oh nice! completely forgot about this option! my bad ---

[GitHub] nifi issue #2917: NIFI-5454: Added EL support and copy.index attribute to Du...

2018-07-26 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2917 +1, merging to master, thanks @mattyb149 ---

[GitHub] nifi issue #2914: NIFI-5448 Added failure relationship to UpdateAttributes t...

2018-07-26 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2914 @MikeThomsen - unfortunately, I believe this is a breaking change that will need to wait for NiFi 2.0.0. Adding a relationship will make the processor invalid after an upgrade and users will have

[GitHub] nifi pull request #2927: NIFI-5473 Added section on using external signed CA...

2018-07-31 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2927#discussion_r206432068 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -281,6 +281,272 @@ After running the client you will have the CA’s certificate

[GitHub] nifi issue #2926: NIFI-5471: Push table aliasing to DatabaseAdapter impls

2018-07-31 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2926 +1, merging to master, thanks @mattyb149 ---

[GitHub] nifi issue #2846: NIFI-5381 Add GetSFTP and PutSFTP Unit Tests

2018-08-10 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2846 +1 as well, merging to master, thanks @patricker ---

[GitHub] nifi-registry issue #133: NIFIREG-190

2018-08-09 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi-registry/pull/133 Had a quick look through the code and it LGTM, will try to give it a try today or tomorrow if no else has the cycles to do so. ---

[GitHub] nifi-registry issue #134: NIFIREG-192: Implement REGISTRY_START event

2018-08-09 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi-registry/pull/134 Same here - code LGTM, will give it a try today or tomorrow if no one has the cycles to do it before. ---

[GitHub] nifi issue #2682: NIFI-4731: BQ Processors and GCP library update.

2018-08-06 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2682 @danieljimenez Based on [WARNING] Files with unapproved licenses: /home/travis/build/apache/nifi/nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/test/java/org

[GitHub] nifi pull request #2946: NIFI-5494: Added ExpressionLanguage support to 'Hiv...

2018-08-12 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2946#discussion_r209458522 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/PutHiveStreaming.java --- @@ -182,6 +182,7

[GitHub] nifi pull request #2946: NIFI-5494: Added ExpressionLanguage support to 'Hiv...

2018-08-12 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2946#discussion_r209458548 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/processors/hive/PutHive3Streaming.java --- @@ -133,6

[GitHub] nifi issue #2947: [WIP] NIFI-5516: Implement Load-Balanced Connections

2018-08-24 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2947 I've been very busy the last few days/weeks and missed that PR. Thanks for the wip @markap14, this is awesome and going to change a lot of things! I gave it a try very quickly and will try

[GitHub] nifi issue #2950: NIFI-5517: Add support for remaining Hive types to PutHive...

2018-08-24 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2950 Code LGTM and ran few tests against a running Hive 3 instance, it works as expected. Merging to master, thanks @mattyb149 ---

[GitHub] nifi issue #1977: NIFI-515 - DeleteSQS and PutSQS should offer batch process...

2018-08-24 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1977 Hey @jzonthemtn - sorry for the late answer, I've been busy lately. I just rebased this PR against master. If it still looks good to you, I'm sure we can find someone willing to merge it. ---

[GitHub] nifi issue #2963: NIFI-5541 - Added OWASP profile for dependency check

2018-08-24 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2963 @alopresto - a friendly ping as you probably want to have a look on this ---

[GitHub] nifi pull request #2963: NIFI-5541 - Added OWASP profile for dependency chec...

2018-08-24 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/2963 NIFI-5541 - Added OWASP profile for dependency check Added a profile allowing people to run the OWASP maven plugin. I had to add ``false`` to get things working without failure. I'm

[GitHub] nifi pull request #2966: NIFI-5552 - Add option to normalize header column n...

2018-08-24 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/2966 NIFI-5552 - Add option to normalize header column names in CSVRecordR… …eader Thank you for submitting a contribution to Apache NiFi. In order to streamline the review

[GitHub] nifi pull request #2682: NIFI-4731: BQ Processors and GCP library update.

2018-08-24 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2682#discussion_r212763892 --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-services-api/pom.xml --- @@ -33,7 +33,7 @@ com.google.auth

[GitHub] nifi pull request #2682: NIFI-4731: BQ Processors and GCP library update.

2018-08-24 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2682#discussion_r212761916 --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/AbstractBigQueryProcessor.java

[GitHub] nifi pull request #2682: NIFI-4731: BQ Processors and GCP library update.

2018-08-24 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2682#discussion_r212762648 --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/BigQueryAttributes.java --- @@ -0,0

[GitHub] nifi pull request #2682: NIFI-4731: BQ Processors and GCP library update.

2018-08-24 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2682#discussion_r212762691 --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/BqUtils.java --- @@ -0,0 +1,84

[GitHub] nifi pull request #2682: NIFI-4731: BQ Processors and GCP library update.

2018-08-24 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2682#discussion_r212763182 --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQueryBatch.java --- @@ -0,0

[GitHub] nifi pull request #2682: NIFI-4731: BQ Processors and GCP library update.

2018-08-24 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2682#discussion_r212762507 --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/AbstractGCPProcessor.java --- @@ -43,7 +43,8

[GitHub] nifi pull request #2682: NIFI-4731: BQ Processors and GCP library update.

2018-08-24 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2682#discussion_r212762943 --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQueryBatch.java --- @@ -0,0

[GitHub] nifi pull request #2682: NIFI-4731: BQ Processors and GCP library update.

2018-08-24 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2682#discussion_r212762622 --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/BigQueryAttributes.java --- @@ -0,0

[GitHub] nifi pull request #2138: NIFI-4371 - add support for query timeout in Hive p...

2018-08-28 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2138#discussion_r21538 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/processors/hive/AbstractHive3QLProcessor.java

[GitHub] nifi issue #2138: NIFI-4371 - add support for query timeout in Hive processo...

2018-08-27 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2138 finally got time to get back on this one... if you want to have another look @mattyb149 ---

[GitHub] nifi pull request #2138: NIFI-4371 - add support for query timeout in Hive p...

2018-08-28 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2138#discussion_r213204485 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/processors/hive/AbstractHive3QLProcessor.java

[GitHub] nifi issue #2946: NIFI-5494: Added ExpressionLanguage support to 'Hive Confi...

2018-08-22 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2946 Hi @zenfenan - sorry it took so long, really busy for the last few weeks. It LGTM, merging to master, thanks for the improvement. ---

[GitHub] nifi issue #2964: NIFI-5551: If session.get() returns null, then return fron...

2018-08-27 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2964 +1, merging to master, thanks @markap14 ---

[GitHub] nifi pull request #2973: NIFI-5561 - Add component name filtering to S2S Pro...

2018-08-29 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/2973 NIFI-5561 - Add component name filtering to S2S Provenance Reporting … …Task Thank you for submitting a contribution to Apache NiFi. In order to streamline the review

[GitHub] nifi pull request #2903: NIFI-5437 - Yield in ExecuteScript when catching Sc...

2018-07-17 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/2903 NIFI-5437 - Yield in ExecuteScript when catching ScriptException Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi issue #2898: NIFI-4407: Updated Expression Language Guide to provide de...

2018-07-18 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2898 +1, code LGTM, made few tests, checked doc update, merging to master, thanks @markap14 ---

[GitHub] nifi issue #2891: NIFI-5305 Added a unit test to check for the behavior desc...

2018-07-18 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2891 +1, merging to master, thanks @MikeThomsen ---

[GitHub] nifi issue #2904: NIFI-5196 Fixed JMS connection leak when uncaught exceptio...

2018-07-18 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2904 +1, code LGTM, merging to master, thanks @mosermw ---

[GitHub] nifi issue #1925: NIFI-3964 KeyValue lookup service and Grok patterns contro...

2018-07-18 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1925 I'm certainly not a grok expert and probably using it in simplest cases, but in all the log ingestion use cases I'm working on, I'm usually fine with the default patterns file (already loaded from

[GitHub] nifi issue #1925: NIFI-3964 KeyValue lookup service and Grok patterns contro...

2018-07-18 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1925 Just rebased this one against master, if someone wants to have a look. ---

[GitHub] nifi issue #2138: NIFI-4371 - add support for query timeout in Hive processo...

2018-07-18 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2138 Hey @mattyb149 - I believe we added this one for Hive 3 processors but forgot this PR. I know you're not available at the moment, but just a reminder for when you're back ;) (or if someone else

[GitHub] nifi issue #379: NIFI-1022 Added Tachyon/Alluxio processors

2018-07-18 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/379 Closing this one as I don't have time to get back into it at the moment. For anyone interested, it would at least be necessary to upgrade Alluxio version to the latest. (@HorizonNet - I see you're

[GitHub] nifi pull request #379: NIFI-1022 Added Tachyon/Alluxio processors

2018-07-18 Thread pvillard31
Github user pvillard31 closed the pull request at: https://github.com/apache/nifi/pull/379 ---

[GitHub] nifi issue #1925: NIFI-3964 KeyValue lookup service and Grok patterns contro...

2018-07-18 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1925 @ottobackwards - you're completely right and by rebasing the PR, I missed something. Instead of using java grokCompiler.register(String,String); I should use

[GitHub] nifi issue #2966: NIFI-5552 - Add option to normalize header column names in...

2018-08-30 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2966 Hey @markap14 - thanks for the review. You're right, it's much better to address it when creating the Avro schema. That would prevent this error to happen again if one day we add a Reader

[GitHub] nifi issue #2966: NIFI-5552 - Add option to normalize header column names in...

2018-08-31 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2966 > we don't want to change recordField.getFieldName() - that is the NiFi class and has nothing to do with Avro. We really want to avoid enforcing any Avro naming peculiarities on NiFi - we sho

[GitHub] nifi pull request #2973: NIFI-5561 - Add component name filtering to S2S Pro...

2018-08-30 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2973#discussion_r213933585 --- Diff: nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting

[GitHub] nifi pull request #2973: NIFI-5561 - Add component name filtering to S2S Pro...

2018-08-30 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2973#discussion_r213933052 --- Diff: nifi-nar-bundles/nifi-extension-utils/nifi-reporting-utils/src/main/java/org/apache/nifi/reporting/util/provenance/ProvenanceEventConsumer.java

[GitHub] nifi pull request #2966: NIFI-5552 - Add option to normalize header column n...

2018-08-30 Thread pvillard31
Github user pvillard31 closed the pull request at: https://github.com/apache/nifi/pull/2966 ---

[GitHub] nifi pull request #2966: NIFI-5552 - Add option to normalize header column n...

2018-08-30 Thread pvillard31
GitHub user pvillard31 reopened a pull request: https://github.com/apache/nifi/pull/2966 NIFI-5552 - Add option to normalize header column names in CSVRecordR… …eader Thank you for submitting a contribution to Apache NiFi. In order to streamline the review

[GitHub] nifi pull request #2973: NIFI-5561 - Add component name filtering to S2S Pro...

2018-08-30 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2973#discussion_r213990560 --- Diff: nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting

[GitHub] nifi pull request #2682: NIFI-4731: BQ Processors and GCP library update.

2018-09-11 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2682#discussion_r216662096 --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/AbstractGCPProcessor.java --- @@ -43,7 +43,8

[GitHub] nifi pull request #2839: NIFI-5372 Making adjustments to the docker-compose ...

2018-07-04 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2839#discussion_r200042921 --- Diff: nifi-docker/docker-compose/README.md --- @@ -0,0 +1,56 @@ + + +# Apache NiFi Docker Compose + +# Usage + +## Overview

[GitHub] nifi issue #2854: NIFI-5355 ResizeImage Fails to read PNG type on some OS's

2018-07-10 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2854 I'm a +1 as well, merging to master, thanks @patricker @joewitt ---

[GitHub] nifi pull request #2870: NIFI-5399 Added wildcard certificate documentation ...

2018-07-10 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2870#discussion_r201246258 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -164,6 +164,16 @@ accomplished by setting the `nifi.remote.input.secure

[GitHub] nifi issue #2871: NIFI-5401 Improved logging for node identity loading.

2018-07-10 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2871 +1, merging to master, thanks @alopresto ---

[GitHub] nifi issue #2877: NIFI-5407: Add a MetricsReportingTask to send to ElasticSe...

2018-07-11 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2877 Hi @richmidwinter - usually we recommend to use the Site To Site Reporting tasks to re-ingest data generated by NiFi at framework level (such as controller status, bulletins, provenance events

[GitHub] nifi issue #2830: NIFI-4889: Logout not working properly with OIDC

2018-07-12 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2830 @Trojan295 - NiFi 1.7.0 has been released, I'd recommend you to rebase against master (so that all the pom files are updated to 1.8.0-SNAPSHOT) and do a full build to have a clean local maven repo

[GitHub] nifi pull request #2426: NIFI-4790: support HTTPS Proxy in InvokeHTTP

2018-01-24 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2426#discussion_r163476469 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java --- @@ -213,11

[GitHub] nifi pull request #2426: NIFI-4790: support HTTPS Proxy in InvokeHTTP

2018-01-24 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2426#discussion_r163476600 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java --- @@ -513,6

[GitHub] nifi pull request #2426: NIFI-4790: support HTTPS Proxy in InvokeHTTP

2018-01-24 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2426#discussion_r163476703 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java --- @@ -513,6

[GitHub] nifi issue #2422: NIFI-4773: Moved DB Fetch processors' connection code from...

2018-01-23 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2422 +1, merging to master. Build failed on travis because it took too long but local build with contrib check is OK. ---

[GitHub] nifi issue #2424: NIFI-4393: Handle database specific identifier escape char...

2018-01-23 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2424 Code LGTM @ijokarumawak. I'm a +1 on this PR but will wait a bit in case @mattyb149 or someone else wants to double check. ---

[GitHub] nifi pull request #2430: NIFI-4809 - Implement a SiteToSiteMetricsReportingT...

2018-01-23 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/2430 NIFI-4809 - Implement a SiteToSiteMetricsReportingTask To avoid some code duplication, I moved few utilitary classes into the reporting-utils package. And I also added two metrics (available

[GitHub] nifi issue #2430: NIFI-4809 - Implement a SiteToSiteMetricsReportingTask

2018-01-24 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2430 I'll need to update this PR if #2431 is merged first. ---

[GitHub] nifi pull request #2682: NIFI-4731: BQ Processors and GCP library update.

2018-09-11 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2682#discussion_r216691828 --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQueryBatch.java --- @@ -0,0

[GitHub] nifi pull request #2682: NIFI-4731: BQ Processors and GCP library update.

2018-09-11 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2682#discussion_r216687983 --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/AbstractGCPProcessor.java --- @@ -43,7 +43,8

[GitHub] nifi pull request #2682: NIFI-4731: BQ Processors and GCP library update.

2018-09-11 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2682#discussion_r216690423 --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQueryBatch.java --- @@ -0,0

[GitHub] nifi pull request #2682: NIFI-4731: BQ Processors and GCP library update.

2018-09-11 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2682#discussion_r216690236 --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQueryBatch.java --- @@ -0,0

[GitHub] nifi pull request #2682: NIFI-4731: BQ Processors and GCP library update.

2018-09-11 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2682#discussion_r216692916 --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQueryBatch.java --- @@ -0,0

[GitHub] nifi pull request #2682: NIFI-4731: BQ Processors and GCP library update.

2018-09-11 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2682#discussion_r216699464 --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/BigQueryAttributes.java --- @@ -0,0

[GitHub] nifi pull request #2682: NIFI-4731: BQ Processors and GCP library update.

2018-09-11 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2682#discussion_r216713400 --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQueryBatch.java --- @@ -0,0

[GitHub] nifi pull request #2682: NIFI-4731: BQ Processors and GCP library update.

2018-09-11 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2682#discussion_r216683619 --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQueryBatch.java --- @@ -0,0

[GitHub] nifi pull request #2682: NIFI-4731: BQ Processors and GCP library update.

2018-09-11 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2682#discussion_r216683722 --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQueryBatch.java --- @@ -0,0

[GitHub] nifi pull request #2682: NIFI-4731: BQ Processors and GCP library update.

2018-09-11 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2682#discussion_r216694142 --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/BigQueryAttributes.java --- @@ -0,0

[GitHub] nifi pull request #2518: NIFI-4637 Added support for visibility labels to th...

2018-03-07 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2518#discussion_r172975369 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-hbase-client-service-api/src/main/java/org/apache/nifi/hbase/HBaseClientService.java --- @@ -150,6

[GitHub] nifi pull request #2518: NIFI-4637 Added support for visibility labels to th...

2018-03-07 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2518#discussion_r172973981 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseRecord.java --- @@ -385,7 +427,18

[GitHub] nifi pull request #2518: NIFI-4637 Added support for visibility labels to th...

2018-03-07 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2518#discussion_r172973696 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseRecord.java --- @@ -194,6 +220,12

[GitHub] nifi pull request #2518: NIFI-4637 Added support for visibility labels to th...

2018-03-07 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2518#discussion_r172972637 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseCell.java --- @@ -96,16 +97,18

[GitHub] nifi pull request #2518: NIFI-4637 Added support for visibility labels to th...

2018-03-07 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2518#discussion_r172977733 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/DeleteHBaseRow.java --- @@ -103,6 +103,17

[GitHub] nifi pull request #2518: NIFI-4637 Added support for visibility labels to th...

2018-03-07 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2518#discussion_r172973274 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseJSON.java --- @@ -255,7 +253,16 @@ public

[GitHub] nifi pull request #2518: NIFI-4637 Added support for visibility labels to th...

2018-03-07 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2518#discussion_r172976209 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-hbase_1_1_2-client-service-bundle/nifi-hbase_1_1_2-client-service/src/main/java/org/apache/nifi/hbase

[GitHub] nifi pull request #2518: NIFI-4637 Added support for visibility labels to th...

2018-03-07 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2518#discussion_r172975481 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-hbase-client-service-api/src/main/java/org/apache/nifi/hbase/HBaseClientService.java --- @@ -126,6

[GitHub] nifi pull request #2518: NIFI-4637 Added support for visibility labels to th...

2018-03-07 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2518#discussion_r172977970 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/GetHBase.java --- @@ -16,28 +16,6

[GitHub] nifi pull request #2518: NIFI-4637 Added support for visibility labels to th...

2018-03-07 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2518#discussion_r172976240 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-hbase_1_1_2-client-service-bundle/nifi-hbase_1_1_2-client-service/src/main/java/org/apache/nifi/hbase

[GitHub] nifi pull request #2518: NIFI-4637 Added support for visibility labels to th...

2018-03-07 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2518#discussion_r172973432 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseRecord.java --- @@ -141,6 +149,16

[GitHub] nifi pull request #2513: NIFI-4940 - CSVReader - Header schema strategy - no...

2018-03-06 Thread pvillard31
Github user pvillard31 closed the pull request at: https://github.com/apache/nifi/pull/2513 ---

[GitHub] nifi issue #2513: NIFI-4940 - CSVReader - Header schema strategy - normalize...

2018-03-06 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2513 Closing as per comment from Mark in the JIRA. What I was trying to achieve can already be done and works nicely :) Thanks anyway for having a look @zenfenan ! ---

[GitHub] nifi issue #2430: NIFI-4809 - Implement a SiteToSiteMetricsReportingTask

2018-03-07 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2430 @mattyb149 - pushed another commit with unit tests and doc ---

[GitHub] nifi issue #2520: NIFI-4928 Updated BouncyCastle dependencies to version 1.5...

2018-03-08 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2520 +1, confirmed correct behavior with provided template. Merging to master, thanks @alopresto ---

[GitHub] nifi pull request #2522: NIFI-4948 - MongoDB Lookup Service throws an except...

2018-03-08 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/2522 NIFI-4948 - MongoDB Lookup Service throws an exception if there is no… … match Thank you for submitting a contribution to Apache NiFi. In order to streamline the review

[GitHub] nifi issue #2522: NIFI-4948 - MongoDB Lookup Service throws an exception if ...

2018-03-08 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2522 @MikeThomsen - since you've been extensively working on the Mongo processors, I'd appreciate if you could give your feedback on this one. Thanks much! ---

[GitHub] nifi pull request #2530: NIFI-4800 Expose the flattenMode as property in Fla...

2018-03-12 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2530#discussion_r173719906 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/groovy/org/apache/nifi/processors/standard/TestFlattenJson.groovy

[GitHub] nifi pull request #2530: NIFI-4800 Expose the flattenMode as property in Fla...

2018-03-12 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2530#discussion_r173719874 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/groovy/org/apache/nifi/processors/standard/TestFlattenJson.groovy

[GitHub] nifi pull request #2530: NIFI-4800 Expose the flattenMode as property in Fla...

2018-03-12 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2530#discussion_r173719297 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FlattenJson.java --- @@ -89,13

[GitHub] nifi issue #2527: FetchHBaseRow - log level and displayName

2018-03-09 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2527 Hi @bdesert - unfortunately, since this processor has been already released with NiFi 1.5.0, we cannot change the name of the properties in a minor release as it would break the existing workflows

[GitHub] nifi issue #2448: NIFI-4838 Added configurable progressive commits to GetMon...

2018-03-09 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2448 @MikeThomsen - sure, mind rebasing to run some tests with a Mongo docker instance? ---

<    4   5   6   7   8   9   10   11   12   >