Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2224
I just rebased against master and added 1.0 Kafka processors.
---
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2138#discussion_r159671901
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/PutHiveQL.java
---
@@ -233,6 +234,7
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2138#discussion_r206334616
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/AbstractHiveQLProcessor.java
---
@@ -75,6
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2138#discussion_r206334896
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/AbstractHiveQLProcessor.java
---
@@ -76,6
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2924
+1, merging to master, thanks @zenfenan
---
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2138#discussion_r206335572
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/AbstractHiveQLProcessor.java
---
@@ -75,6
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2914
@MikeThomsen oh nice! completely forgot about this option! my bad
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2917
+1, merging to master, thanks @mattyb149
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2914
@MikeThomsen - unfortunately, I believe this is a breaking change that will
need to wait for NiFi 2.0.0. Adding a relationship will make the processor
invalid after an upgrade and users will have
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2927#discussion_r206432068
--- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc ---
@@ -281,6 +281,272 @@ After running the client you will have the CAâs
certificate
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2926
+1, merging to master, thanks @mattyb149
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2846
+1 as well, merging to master, thanks @patricker
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi-registry/pull/133
Had a quick look through the code and it LGTM, will try to give it a try
today or tomorrow if no else has the cycles to do so.
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi-registry/pull/134
Same here - code LGTM, will give it a try today or tomorrow if no one has
the cycles to do it before.
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2682
@danieljimenez
Based on
[WARNING] Files with unapproved licenses:
/home/travis/build/apache/nifi/nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/test/java/org
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2946#discussion_r209458522
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/PutHiveStreaming.java
---
@@ -182,6 +182,7
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2946#discussion_r209458548
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/processors/hive/PutHive3Streaming.java
---
@@ -133,6
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2947
I've been very busy the last few days/weeks and missed that PR. Thanks for
the wip @markap14, this is awesome and going to change a lot of things! I gave
it a try very quickly and will try
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2950
Code LGTM and ran few tests against a running Hive 3 instance, it works as
expected. Merging to master, thanks @mattyb149
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/1977
Hey @jzonthemtn - sorry for the late answer, I've been busy lately. I just
rebased this PR against master. If it still looks good to you, I'm sure we can
find someone willing to merge it.
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2963
@alopresto - a friendly ping as you probably want to have a look on this
---
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/2963
NIFI-5541 - Added OWASP profile for dependency check
Added a profile allowing people to run the OWASP maven plugin. I had to add
``false`` to get things working
without failure.
I'm
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/2966
NIFI-5552 - Add option to normalize header column names in CSVRecordRâ¦
â¦eader
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2682#discussion_r212763892
--- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-services-api/pom.xml ---
@@ -33,7 +33,7 @@
com.google.auth
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2682#discussion_r212761916
--- Diff:
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/AbstractBigQueryProcessor.java
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2682#discussion_r212762648
--- Diff:
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/BigQueryAttributes.java
---
@@ -0,0
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2682#discussion_r212762691
--- Diff:
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/BqUtils.java
---
@@ -0,0 +1,84
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2682#discussion_r212763182
--- Diff:
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQueryBatch.java
---
@@ -0,0
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2682#discussion_r212762507
--- Diff:
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/AbstractGCPProcessor.java
---
@@ -43,7 +43,8
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2682#discussion_r212762943
--- Diff:
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQueryBatch.java
---
@@ -0,0
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2682#discussion_r212762622
--- Diff:
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/BigQueryAttributes.java
---
@@ -0,0
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2138#discussion_r21538
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/processors/hive/AbstractHive3QLProcessor.java
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2138
finally got time to get back on this one... if you want to have another
look @mattyb149
---
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2138#discussion_r213204485
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/processors/hive/AbstractHive3QLProcessor.java
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2946
Hi @zenfenan - sorry it took so long, really busy for the last few weeks.
It LGTM, merging to master, thanks for the improvement.
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2964
+1, merging to master, thanks @markap14
---
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/2973
NIFI-5561 - Add component name filtering to S2S Provenance Reporting â¦
â¦Task
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/2903
NIFI-5437 - Yield in ExecuteScript when catching ScriptException
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2898
+1, code LGTM, made few tests, checked doc update, merging to master,
thanks @markap14
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2891
+1, merging to master, thanks @MikeThomsen
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2904
+1, code LGTM, merging to master, thanks @mosermw
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/1925
I'm certainly not a grok expert and probably using it in simplest cases,
but in all the log ingestion use cases I'm working on, I'm usually fine with
the default patterns file (already loaded from
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/1925
Just rebased this one against master, if someone wants to have a look.
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2138
Hey @mattyb149 - I believe we added this one for Hive 3 processors but
forgot this PR. I know you're not available at the moment, but just a reminder
for when you're back ;) (or if someone else
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/379
Closing this one as I don't have time to get back into it at the moment.
For anyone interested, it would at least be necessary to upgrade Alluxio
version to the latest. (@HorizonNet - I see you're
Github user pvillard31 closed the pull request at:
https://github.com/apache/nifi/pull/379
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/1925
@ottobackwards - you're completely right and by rebasing the PR, I missed
something.
Instead of using
java
grokCompiler.register(String,String);
I should use
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2966
Hey @markap14 - thanks for the review. You're right, it's much better to
address it when creating the Avro schema. That would prevent this error to
happen again if one day we add a Reader
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2966
> we don't want to change recordField.getFieldName() - that is the NiFi
class and has nothing to do with Avro. We really want to avoid enforcing any
Avro naming peculiarities on NiFi - we sho
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2973#discussion_r213933585
--- Diff:
nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2973#discussion_r213933052
--- Diff:
nifi-nar-bundles/nifi-extension-utils/nifi-reporting-utils/src/main/java/org/apache/nifi/reporting/util/provenance/ProvenanceEventConsumer.java
Github user pvillard31 closed the pull request at:
https://github.com/apache/nifi/pull/2966
---
GitHub user pvillard31 reopened a pull request:
https://github.com/apache/nifi/pull/2966
NIFI-5552 - Add option to normalize header column names in CSVRecordRâ¦
â¦eader
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2973#discussion_r213990560
--- Diff:
nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2682#discussion_r216662096
--- Diff:
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/AbstractGCPProcessor.java
---
@@ -43,7 +43,8
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2839#discussion_r200042921
--- Diff: nifi-docker/docker-compose/README.md ---
@@ -0,0 +1,56 @@
+
+
+# Apache NiFi Docker Compose
+
+# Usage
+
+## Overview
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2854
I'm a +1 as well, merging to master, thanks @patricker @joewitt
---
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2870#discussion_r201246258
--- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc ---
@@ -164,6 +164,16 @@ accomplished by setting the `nifi.remote.input.secure
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2871
+1, merging to master, thanks @alopresto
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2877
Hi @richmidwinter - usually we recommend to use the Site To Site Reporting
tasks to re-ingest data generated by NiFi at framework level (such as
controller status, bulletins, provenance events
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2830
@Trojan295 - NiFi 1.7.0 has been released, I'd recommend you to rebase
against master (so that all the pom files are updated to 1.8.0-SNAPSHOT) and do
a full build to have a clean local maven repo
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2426#discussion_r163476469
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
---
@@ -213,11
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2426#discussion_r163476600
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
---
@@ -513,6
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2426#discussion_r163476703
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
---
@@ -513,6
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2422
+1, merging to master. Build failed on travis because it took too long but
local build with contrib check is OK.
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2424
Code LGTM @ijokarumawak. I'm a +1 on this PR but will wait a bit in case
@mattyb149 or someone else wants to double check.
---
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/2430
NIFI-4809 - Implement a SiteToSiteMetricsReportingTask
To avoid some code duplication, I moved few utilitary classes into the
reporting-utils package. And I also added two metrics (available
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2430
I'll need to update this PR if #2431 is merged first.
---
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2682#discussion_r216691828
--- Diff:
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQueryBatch.java
---
@@ -0,0
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2682#discussion_r216687983
--- Diff:
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/AbstractGCPProcessor.java
---
@@ -43,7 +43,8
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2682#discussion_r216690423
--- Diff:
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQueryBatch.java
---
@@ -0,0
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2682#discussion_r216690236
--- Diff:
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQueryBatch.java
---
@@ -0,0
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2682#discussion_r216692916
--- Diff:
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQueryBatch.java
---
@@ -0,0
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2682#discussion_r216699464
--- Diff:
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/BigQueryAttributes.java
---
@@ -0,0
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2682#discussion_r216713400
--- Diff:
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQueryBatch.java
---
@@ -0,0
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2682#discussion_r216683619
--- Diff:
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQueryBatch.java
---
@@ -0,0
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2682#discussion_r216683722
--- Diff:
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQueryBatch.java
---
@@ -0,0
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2682#discussion_r216694142
--- Diff:
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/BigQueryAttributes.java
---
@@ -0,0
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2518#discussion_r172975369
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-hbase-client-service-api/src/main/java/org/apache/nifi/hbase/HBaseClientService.java
---
@@ -150,6
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2518#discussion_r172973981
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseRecord.java
---
@@ -385,7 +427,18
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2518#discussion_r172973696
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseRecord.java
---
@@ -194,6 +220,12
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2518#discussion_r172972637
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseCell.java
---
@@ -96,16 +97,18
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2518#discussion_r172977733
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/DeleteHBaseRow.java
---
@@ -103,6 +103,17
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2518#discussion_r172973274
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseJSON.java
---
@@ -255,7 +253,16 @@ public
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2518#discussion_r172976209
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-hbase_1_1_2-client-service-bundle/nifi-hbase_1_1_2-client-service/src/main/java/org/apache/nifi/hbase
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2518#discussion_r172975481
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-hbase-client-service-api/src/main/java/org/apache/nifi/hbase/HBaseClientService.java
---
@@ -126,6
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2518#discussion_r172977970
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/GetHBase.java
---
@@ -16,28 +16,6
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2518#discussion_r172976240
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-hbase_1_1_2-client-service-bundle/nifi-hbase_1_1_2-client-service/src/main/java/org/apache/nifi/hbase
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2518#discussion_r172973432
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseRecord.java
---
@@ -141,6 +149,16
Github user pvillard31 closed the pull request at:
https://github.com/apache/nifi/pull/2513
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2513
Closing as per comment from Mark in the JIRA. What I was trying to achieve
can already be done and works nicely :) Thanks anyway for having a look
@zenfenan !
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2430
@mattyb149 - pushed another commit with unit tests and doc
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2520
+1, confirmed correct behavior with provided template. Merging to master,
thanks @alopresto
---
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/2522
NIFI-4948 - MongoDB Lookup Service throws an exception if there is noâ¦
⦠match
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2522
@MikeThomsen - since you've been extensively working on the Mongo
processors, I'd appreciate if you could give your feedback on this one. Thanks
much!
---
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2530#discussion_r173719906
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/groovy/org/apache/nifi/processors/standard/TestFlattenJson.groovy
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2530#discussion_r173719874
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/groovy/org/apache/nifi/processors/standard/TestFlattenJson.groovy
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2530#discussion_r173719297
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FlattenJson.java
---
@@ -89,13
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2527
Hi @bdesert - unfortunately, since this processor has been already released
with NiFi 1.5.0, we cannot change the name of the properties in a minor release
as it would break the existing workflows
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2448
@MikeThomsen - sure, mind rebasing to run some tests with a Mongo docker
instance?
---
801 - 900 of 1144 matches
Mail list logo