[GitHub] [nifi] adamfisher commented on pull request #3317: NIFI-6047 Add DetectDuplicateRecord Processor

2020-10-22 Thread GitBox
adamfisher commented on pull request #3317: URL: https://github.com/apache/nifi/pull/3317#issuecomment-714820284 Last I remember getting the tests running but it was really hard to get the whole framework to build. It's super close. Please let me know if you need anything. I did add

[GitHub] [nifi] MikeThomsen commented on pull request #3317: NIFI-6047 Add DetectDuplicateRecord Processor

2020-10-22 Thread GitBox
MikeThomsen commented on pull request #3317: URL: https://github.com/apache/nifi/pull/3317#issuecomment-714777665 @mattyb149 @joewitt Been a while since I looked at this, but I think I was mostly +1 on this. We have a strong need for this, so I'll take over the PR and close the gaps.

[GitHub] [nifi] pkelly-nifi commented on a change in pull request #4576: NIFI-7886: FetchAzureBlobStorage, FetchS3Object, and FetchGCSObject processors should be able to fetch ranges

2020-10-22 Thread GitBox
pkelly-nifi commented on a change in pull request #4576: URL: https://github.com/apache/nifi/pull/4576#discussion_r510465823 ## File path: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/FetchS3Object.java ## @@ -147,6

[GitHub] [nifi] mtien-apache commented on a change in pull request #4593: NIFI-7584 Added OIDC logout mechanism.

2020-10-22 Thread GitBox
mtien-apache commented on a change in pull request #4593: URL: https://github.com/apache/nifi/pull/4593#discussion_r510450932 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/AccessResource.java ##

[GitHub] [nifi-registry] kevdoran commented on pull request #287: NIFIREG-399 Support chown docker in docker

2020-10-22 Thread GitBox
kevdoran commented on pull request #287: URL: https://github.com/apache/nifi-registry/pull/287#issuecomment-714697537 Closing for now. @nkininge please let me know if you have found a solution for this. This is an automated

[GitHub] [nifi-registry] kevdoran closed pull request #307: NIFIREG-425 Update automated UI tests with correct URL

2020-10-22 Thread GitBox
kevdoran closed pull request #307: URL: https://github.com/apache/nifi-registry/pull/307 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [nifi-registry] kevdoran closed pull request #287: NIFIREG-399 Support chown docker in docker

2020-10-22 Thread GitBox
kevdoran closed pull request #287: URL: https://github.com/apache/nifi-registry/pull/287 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [nifi-registry] kevdoran merged pull request #308: NIFIREG-349 Add nifi.registry.bootstrap.sensitive.key to Bootstrap Pr…

2020-10-22 Thread GitBox
kevdoran merged pull request #308: URL: https://github.com/apache/nifi-registry/pull/308 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [nifi] lucasmoten commented on a change in pull request #4576: NIFI-7886: FetchAzureBlobStorage, FetchS3Object, and FetchGCSObject processors should be able to fetch ranges

2020-10-22 Thread GitBox
lucasmoten commented on a change in pull request #4576: URL: https://github.com/apache/nifi/pull/4576#discussion_r510368352 ## File path: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/FetchS3Object.java ## @@ -147,6

[GitHub] [nifi] lucasmoten commented on a change in pull request #4576: NIFI-7886: FetchAzureBlobStorage, FetchS3Object, and FetchGCSObject processors should be able to fetch ranges

2020-10-22 Thread GitBox
lucasmoten commented on a change in pull request #4576: URL: https://github.com/apache/nifi/pull/4576#discussion_r510366644 ## File path: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/FetchS3Object.java ## @@ -147,6

[GitHub] [nifi] lucasmoten commented on a change in pull request #4576: NIFI-7886: FetchAzureBlobStorage, FetchS3Object, and FetchGCSObject processors should be able to fetch ranges

2020-10-22 Thread GitBox
lucasmoten commented on a change in pull request #4576: URL: https://github.com/apache/nifi/pull/4576#discussion_r510351426 ## File path: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/FetchS3Object.java ## @@ -147,6

[GitHub] [nifi] lucasmoten commented on a change in pull request #4576: NIFI-7886: FetchAzureBlobStorage, FetchS3Object, and FetchGCSObject processors should be able to fetch ranges

2020-10-22 Thread GitBox
lucasmoten commented on a change in pull request #4576: URL: https://github.com/apache/nifi/pull/4576#discussion_r510346462 ## File path: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/FetchS3Object.java ## @@ -147,6

[GitHub] [nifi] asfgit closed pull request #4510: NIFI-7549 Adding Hazelcast based DistributedMapCacheClient support

2020-10-22 Thread GitBox
asfgit closed pull request #4510: URL: https://github.com/apache/nifi/pull/4510 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [nifi-minifi-cpp] szaszm edited a comment on pull request #900: MINIFICPP-1350 - Explicit serializer for MergeContent

2020-10-22 Thread GitBox
szaszm edited a comment on pull request #900: URL: https://github.com/apache/nifi-minifi-cpp/pull/900#issuecomment-714642657 I did some pre-merge manual testing of FFv3. For a while everything worked fine and just as I removed the GenerateFlowFile -> MergeContent connection, NiFi started

[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #900: MINIFICPP-1350 - Explicit serializer for MergeContent

2020-10-22 Thread GitBox
szaszm commented on pull request #900: URL: https://github.com/apache/nifi-minifi-cpp/pull/900#issuecomment-714642657 I did some pre-merge manual testing of FFv3. For a while everything worked fine and just as I removed the GenerateFlowFile -> MergeContent connection, NiFi started spewing

[GitHub] [nifi-registry] andrewmlim opened a new pull request #308: NIFIREG-349 Add nifi.registry.bootstrap.sensitive.key to Bootstrap Pr…

2020-10-22 Thread GitBox
andrewmlim opened a new pull request #308: URL: https://github.com/apache/nifi-registry/pull/308 …operties section in Admin Guide This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [nifi] kevdoran commented on a change in pull request #4510: NIFI-7549 Adding Hazelcast based DistributedMapCacheClient support

2020-10-22 Thread GitBox
kevdoran commented on a change in pull request #4510: URL: https://github.com/apache/nifi/pull/4510#discussion_r510242994 ## File path:

[GitHub] [nifi] tlsmith109 opened a new pull request #4615: NIFI-5629 Optimize listing before applying batching.

2020-10-22 Thread GitBox
tlsmith109 opened a new pull request #4615: URL: https://github.com/apache/nifi/pull/4615 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR Modified standard processor GetFile to prevent

[GitHub] [nifi] naddym commented on pull request #4588: NIFI-7904: Support for validation query timeout in DBCP,Hive and HBas…

2020-10-22 Thread GitBox
naddym commented on pull request #4588: URL: https://github.com/apache/nifi/pull/4588#issuecomment-714372371 Sure @mattyb149, We have REST API based dataflow which entertains requests and returns responses after series of manipulation which also involves database connections. Sometimes,

[GitHub] [nifi] simonbence commented on a change in pull request #4510: NIFI-7549 Adding Hazelcast based DistributedMapCacheClient support

2020-10-22 Thread GitBox
simonbence commented on a change in pull request #4510: URL: https://github.com/apache/nifi/pull/4510#discussion_r509949183 ## File path:

[GitHub] [nifi] simonbence commented on a change in pull request #4510: NIFI-7549 Adding Hazelcast based DistributedMapCacheClient support

2020-10-22 Thread GitBox
simonbence commented on a change in pull request #4510: URL: https://github.com/apache/nifi/pull/4510#discussion_r509948525 ## File path:

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #929: MINIFICPP-1397 Fix compilation errors when PCAP is enabled

2020-10-22 Thread GitBox
lordgamez commented on a change in pull request #929: URL: https://github.com/apache/nifi-minifi-cpp/pull/929#discussion_r509934214 ## File path: libminifi/test/pcap-tests/PcapTest.cpp ## @@ -69,9 +69,10 @@ class PcapTestHarness : public IntegrationBase { void

[GitHub] [nifi] turcsanyip commented on a change in pull request #4510: NIFI-7549 Adding Hazelcast based DistributedMapCacheClient support

2020-10-21 Thread GitBox
turcsanyip commented on a change in pull request #4510: URL: https://github.com/apache/nifi/pull/4510#discussion_r509737191 ## File path:

[GitHub] [nifi] thenatog commented on a change in pull request #4593: NIFI-7584 Added OIDC logout mechanism.

2020-10-21 Thread GitBox
thenatog commented on a change in pull request #4593: URL: https://github.com/apache/nifi/pull/4593#discussion_r509539937 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/AccessResource.java ## @@

[GitHub] [nifi] bbende opened a new pull request #4614: NIFI-7888 Add support for SAML authentication

2020-10-21 Thread GitBox
bbende opened a new pull request #4614: URL: https://github.com/apache/nifi/pull/4614 This PR adds the ability to authenticate to NiFi via a SAML identity provider, similar to how OIDC authentication works. In addition, there is an option to obtain group membership info from the

[GitHub] [nifi] alopresto commented on a change in pull request #4593: NIFI-7584 Added OIDC logout mechanism.

2020-10-21 Thread GitBox
alopresto commented on a change in pull request #4593: URL: https://github.com/apache/nifi/pull/4593#discussion_r509461400 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/AccessResource.java ## @@

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #915: MINIFICPP-1376 Create PutS3Object processor

2020-10-21 Thread GitBox
lordgamez commented on a change in pull request #915: URL: https://github.com/apache/nifi-minifi-cpp/pull/915#discussion_r509427851 ## File path: cmake/BundledAwsSdkCpp.cmake ## @@ -23,8 +23,8 @@ function(use_bundled_libaws SOURCE_DIR BINARY_DIR) set(SUFFIX "a")

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #915: MINIFICPP-1376 Create PutS3Object processor

2020-10-21 Thread GitBox
lordgamez commented on a change in pull request #915: URL: https://github.com/apache/nifi-minifi-cpp/pull/915#discussion_r509426886 ## File path: PROCESSORS.md ## @@ -1125,3 +1126,40 @@ In the list below, the names of required properties appear in bold. Any other pr

[GitHub] [nifi] thenatog commented on a change in pull request #4593: NIFI-7584 Added OIDC logout mechanism.

2020-10-21 Thread GitBox
thenatog commented on a change in pull request #4593: URL: https://github.com/apache/nifi/pull/4593#discussion_r509401269 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/AccessResource.java ## @@

[GitHub] [nifi] anaylor commented on pull request #4130: NIFI-6235 - Prioritizing standard content war loading order

2020-10-21 Thread GitBox
anaylor commented on pull request #4130: URL: https://github.com/apache/nifi/pull/4130#issuecomment-713666171 > @anaylor I see this rebase is turning out to be more complex then it should be... > > I think the challenge is that apache nifi's primary branch moved from master to main

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #915: MINIFICPP-1376 Create PutS3Object processor

2020-10-21 Thread GitBox
szaszm commented on a change in pull request #915: URL: https://github.com/apache/nifi-minifi-cpp/pull/915#discussion_r509358873 ## File path: PROCESSORS.md ## @@ -1125,3 +1126,40 @@ In the list below, the names of required properties appear in bold. Any other pr

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #915: MINIFICPP-1376 Create PutS3Object processor

2020-10-21 Thread GitBox
lordgamez commented on a change in pull request #915: URL: https://github.com/apache/nifi-minifi-cpp/pull/915#discussion_r509348502 ## File path: PROCESSORS.md ## @@ -1125,3 +1126,40 @@ In the list below, the names of required properties appear in bold. Any other pr

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #926: MINIFICPP-1387 - Speed up Identifier to string conversion

2020-10-21 Thread GitBox
adamdebreceni commented on a change in pull request #926: URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r509320738 ## File path: libminifi/include/utils/Id.h ## @@ -65,10 +67,11 @@ class Identifier { bool operator!=(const Identifier& other) const;

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #915: MINIFICPP-1376 Create PutS3Object processor

2020-10-21 Thread GitBox
szaszm commented on a change in pull request #915: URL: https://github.com/apache/nifi-minifi-cpp/pull/915#discussion_r509319208 ## File path: PROCESSORS.md ## @@ -1125,3 +1126,40 @@ In the list below, the names of required properties appear in bold. Any other pr

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #915: MINIFICPP-1376 Create PutS3Object processor

2020-10-21 Thread GitBox
lordgamez commented on a change in pull request #915: URL: https://github.com/apache/nifi-minifi-cpp/pull/915#discussion_r509310005 ## File path: PROCESSORS.md ## @@ -1125,3 +1126,40 @@ In the list below, the names of required properties appear in bold. Any other pr

[GitHub] [nifi] markap14 merged pull request #4611: NIFI-7925: Fix ValidateRecord if avro array or map contains null element/value

2020-10-21 Thread GitBox
markap14 merged pull request #4611: URL: https://github.com/apache/nifi/pull/4611 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [nifi] markap14 commented on pull request #4611: NIFI-7925: Fix ValidateRecord if avro array or map contains null element/value

2020-10-21 Thread GitBox
markap14 commented on pull request #4611: URL: https://github.com/apache/nifi/pull/4611#issuecomment-713563265 Thanks @adenes! Code looks really good. I'm very happy that you noticed and addressed the same issue with the Map data type. Really well put-together PR! +1 will merge to `main`.

[GitHub] [nifi-minifi-cpp] fgerlits opened a new pull request #929: MINIFICPP-1397 Fix compilation errors when PCAP is enabled

2020-10-21 Thread GitBox
fgerlits opened a new pull request #929: URL: https://github.com/apache/nifi-minifi-cpp/pull/929 The CapturePacket (PCAP) processor is not enabled by default, and it was not compiled in any of our CI jobs, so it has got into a bad state where it no longer compiled. I have fixed

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #915: MINIFICPP-1376 Create PutS3Object processor

2020-10-21 Thread GitBox
szaszm commented on a change in pull request #915: URL: https://github.com/apache/nifi-minifi-cpp/pull/915#discussion_r501682430 ## File path: cmake/BundledAwsSdkCpp.cmake ## @@ -23,8 +23,8 @@ function(use_bundled_libaws SOURCE_DIR BINARY_DIR) set(SUFFIX "a")

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #928: MINIFICPP-1394 - Speed up ConsumeWindowsEventLog processor

2020-10-21 Thread GitBox
szaszm commented on a change in pull request #928: URL: https://github.com/apache/nifi-minifi-cpp/pull/928#discussion_r509169143 ## File path: extensions/windows-event-log/wel/WindowsEventLog.cpp ## @@ -43,10 +45,10 @@ void WindowsEventLogMetadataImpl::renderMetadata() {

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #926: MINIFICPP-1387 - Speed up Identifier to string conversion

2020-10-21 Thread GitBox
arpadboda commented on a change in pull request #926: URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r509168851 ## File path: libminifi/include/utils/Id.h ## @@ -65,10 +67,11 @@ class Identifier { bool operator!=(const Identifier& other) const; bool

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #926: MINIFICPP-1387 - Speed up Identifier to string conversion

2020-10-21 Thread GitBox
adamdebreceni commented on a change in pull request #926: URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r509166507 ## File path: libminifi/include/utils/Id.h ## @@ -65,10 +67,11 @@ class Identifier { bool operator!=(const Identifier& other) const;

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #926: MINIFICPP-1387 - Speed up Identifier to string conversion

2020-10-21 Thread GitBox
szaszm commented on a change in pull request #926: URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r509157469 ## File path: libminifi/include/utils/Id.h ## @@ -65,10 +67,11 @@ class Identifier { bool operator!=(const Identifier& other) const; bool

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #926: MINIFICPP-1387 - Speed up Identifier to string conversion

2020-10-21 Thread GitBox
adamdebreceni commented on a change in pull request #926: URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r509027132 ## File path: libminifi/include/utils/Id.h ## @@ -65,10 +67,11 @@ class Identifier { bool operator!=(const Identifier& other) const;

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #928: MINIFICPP-1394 - Speed up ConsumeWindowsEventLog processor

2020-10-21 Thread GitBox
adamdebreceni commented on a change in pull request #928: URL: https://github.com/apache/nifi-minifi-cpp/pull/928#discussion_r509023703 ## File path: extensions/windows-event-log/wel/WindowsEventLog.cpp ## @@ -43,10 +45,10 @@ void WindowsEventLogMetadataImpl::renderMetadata()

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #928: MINIFICPP-1394 - Speed up ConsumeWindowsEventLog processor

2020-10-21 Thread GitBox
adamdebreceni commented on a change in pull request #928: URL: https://github.com/apache/nifi-minifi-cpp/pull/928#discussion_r509021609 ## File path: extensions/windows-event-log/wel/WindowsEventLog.cpp ## @@ -129,34 +133,30 @@ std::string

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #928: MINIFICPP-1394 - Speed up ConsumeWindowsEventLog processor

2020-10-21 Thread GitBox
adamdebreceni commented on a change in pull request #928: URL: https://github.com/apache/nifi-minifi-cpp/pull/928#discussion_r509021203 ## File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp ## @@ -514,30 +515,33 @@ void

[GitHub] [nifi] markobean commented on pull request #4563: NIFI-7738 Reverse Provenance Query

2020-10-20 Thread GitBox
markobean commented on pull request #4563: URL: https://github.com/apache/nifi/pull/4563#issuecomment-713266553 Global Menu > Data Provenance results in a listing of provenance events which can be filtered as expected, including the "NOT" feature. However, choosing "View data

[GitHub] [nifi] thenatog commented on pull request #4613: NiFi-7819 - Add Zookeeper client TLS (external zookeeper) for cluster state management

2020-10-20 Thread GitBox
thenatog commented on pull request #4613: URL: https://github.com/apache/nifi/pull/4613#issuecomment-713261888 This PR now allows the user to configure the TLS properties for ZooKeeper state provider using the nifi.properties file instead of the state-management.xml as in the previous PR.

[GitHub] [nifi] thenatog closed pull request #4592: NiFi-7819 - Add Zookeeper client TLS (external zookeeper) for cluster state management

2020-10-20 Thread GitBox
thenatog closed pull request #4592: URL: https://github.com/apache/nifi/pull/4592 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [nifi] thenatog commented on pull request #4592: NiFi-7819 - Add Zookeeper client TLS (external zookeeper) for cluster state management

2020-10-20 Thread GitBox
thenatog commented on pull request #4592: URL: https://github.com/apache/nifi/pull/4592#issuecomment-713260476 Sorry, I've opened a fresh PR here: https://github.com/apache/nifi/pull/4613 rebased on Joey's changes. I've incorporated the changes requested above. Let me know if there's any

[GitHub] [nifi] thenatog opened a new pull request #4613: NiFi-7819 - Add Zookeeper client TLS (external zookeeper) for cluster state management

2020-10-20 Thread GitBox
thenatog opened a new pull request #4613: URL: https://github.com/apache/nifi/pull/4613 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR _Enables X functionality; fixes bug NIFI-._

[GitHub] [nifi] mattyb149 opened a new pull request #4612: NIFI-7637: Ensure all array elements are compatible in DataTypeUtils.isArrayTypeCompatible()

2020-10-20 Thread GitBox
mattyb149 opened a new pull request #4612: URL: https://github.com/apache/nifi/pull/4612 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR In isArrayTypeCompatible() we just check to see if

[GitHub] [nifi] thenatog commented on a change in pull request #4592: NiFi-7819 - Add Zookeeper client TLS (external zookeeper) for cluster state management

2020-10-20 Thread GitBox
thenatog commented on a change in pull request #4592: URL: https://github.com/apache/nifi/pull/4592#discussion_r508875708 ## File path:

[GitHub] [nifi] adenes opened a new pull request #4611: NIFI-7925: Fix ValidateRecord if avro array or map contains null element/value

2020-10-20 Thread GitBox
adenes opened a new pull request #4611: URL: https://github.com/apache/nifi/pull/4611 Fix the issue that ValidateRecord marks an avro record invalid if it contains an array with null element or a map with null value even if the schema would allow it. In order to streamline the

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #926: MINIFICPP-1387 - Speed up Identifier to string conversion

2020-10-20 Thread GitBox
szaszm commented on a change in pull request #926: URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r508708537 ## File path: libminifi/include/utils/Id.h ## @@ -65,10 +67,11 @@ class Identifier { bool operator!=(const Identifier& other) const; bool

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #926: MINIFICPP-1387 - Speed up Identifier to string conversion

2020-10-20 Thread GitBox
arpadboda commented on a change in pull request #926: URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r508700255 ## File path: libminifi/include/utils/Id.h ## @@ -65,10 +67,11 @@ class Identifier { bool operator!=(const Identifier& other) const; bool

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #926: MINIFICPP-1387 - Speed up Identifier to string conversion

2020-10-20 Thread GitBox
szaszm commented on a change in pull request #926: URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r508697986 ## File path: libminifi/include/utils/Id.h ## @@ -65,10 +67,11 @@ class Identifier { bool operator!=(const Identifier& other) const; bool

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #926: MINIFICPP-1387 - Speed up Identifier to string conversion

2020-10-20 Thread GitBox
arpadboda commented on a change in pull request #926: URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r508692793 ## File path: libminifi/include/utils/Id.h ## @@ -65,10 +67,11 @@ class Identifier { bool operator!=(const Identifier& other) const; bool

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #926: MINIFICPP-1387 - Speed up Identifier to string conversion

2020-10-20 Thread GitBox
arpadboda commented on a change in pull request #926: URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r508692793 ## File path: libminifi/include/utils/Id.h ## @@ -65,10 +67,11 @@ class Identifier { bool operator!=(const Identifier& other) const; bool

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #928: MINIFICPP-1394 - Speed up ConsumeWindowsEventLog processor

2020-10-20 Thread GitBox
szaszm commented on a change in pull request #928: URL: https://github.com/apache/nifi-minifi-cpp/pull/928#discussion_r508687901 ## File path: extensions/windows-event-log/wel/WindowsEventLog.cpp ## @@ -129,34 +133,30 @@ std::string

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #928: MINIFICPP-1394 - Speed up ConsumeWindowsEventLog processor

2020-10-20 Thread GitBox
szaszm commented on a change in pull request #928: URL: https://github.com/apache/nifi-minifi-cpp/pull/928#discussion_r508369819 ## File path: extensions/windows-event-log/wel/WindowsEventLog.cpp ## @@ -129,34 +133,30 @@ std::string

[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #914: MINIFICPP-1323 Encrypt sensitive properties using libsodium

2020-10-20 Thread GitBox
arpadboda closed pull request #914: URL: https://github.com/apache/nifi-minifi-cpp/pull/914 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [nifi] adenes opened a new pull request #4610: NIFI-7929: connectionTimeout and readTimeout options are not exposed …

2020-10-20 Thread GitBox
adenes opened a new pull request #4610: URL: https://github.com/apache/nifi/pull/4610 …in the CLI - added the connectionTimeout and readTimeout parameters to AbstractCommand#createBaseOptions - added new tests to test if the proper timeout values are passed to the JAX-RS client

[GitHub] [nifi] thenatog commented on pull request #4592: NiFi-7819 - Add Zookeeper client TLS (external zookeeper) for cluster state management

2020-10-20 Thread GitBox
thenatog commented on pull request #4592: URL: https://github.com/apache/nifi/pull/4592#issuecomment-712984880 Resolving some conflicts and will update this PR. It will no longer require extra TLS configuration in the state-management.xml. If nifi.zookeeper.client.secure=true, it will use

[GitHub] [nifi] thenatog closed pull request #4250: NIFI-7401 Add ZooKeeper client TLS to CuratorLeaderElectionManager

2020-10-20 Thread GitBox
thenatog closed pull request #4250: URL: https://github.com/apache/nifi/pull/4250 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [nifi] simonbence commented on a change in pull request #4510: NIFI-7549 Adding Hazelcast based DistributedMapCacheClient support

2020-10-20 Thread GitBox
simonbence commented on a change in pull request #4510: URL: https://github.com/apache/nifi/pull/4510#discussion_r508661743 ## File path: nifi-nar-bundles/nifi-hazelcast-bundle/nifi-hazelcast-services/src/main/java/org/apache/nifi/hazelcast/services/cache/IMapBasedHazelcastCache.java

[GitHub] [nifi] simonbence commented on a change in pull request #4510: NIFI-7549 Adding Hazelcast based DistributedMapCacheClient support

2020-10-20 Thread GitBox
simonbence commented on a change in pull request #4510: URL: https://github.com/apache/nifi/pull/4510#discussion_r508649677 ## File path:

[GitHub] [nifi] thenatog closed pull request #4592: NiFi-7819 - Add Zookeeper client TLS (external zookeeper) for cluster state management

2020-10-20 Thread GitBox
thenatog closed pull request #4592: URL: https://github.com/apache/nifi/pull/4592 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [nifi] simonbence commented on a change in pull request #4510: NIFI-7549 Adding Hazelcast based DistributedMapCacheClient support

2020-10-20 Thread GitBox
simonbence commented on a change in pull request #4510: URL: https://github.com/apache/nifi/pull/4510#discussion_r508617371 ## File path:

[GitHub] [nifi] simonbence commented on a change in pull request #4510: NIFI-7549 Adding Hazelcast based DistributedMapCacheClient support

2020-10-20 Thread GitBox
simonbence commented on a change in pull request #4510: URL: https://github.com/apache/nifi/pull/4510#discussion_r508595309 ## File path: nifi-nar-bundles/nifi-hazelcast-bundle/nifi-hazelcast-services/src/main/java/org/apache/nifi/hazelcast/services/util/LongUtil.java ## @@

[GitHub] [nifi] mattyb149 commented on pull request #4588: NIFI-7904: Support for validation query timeout in DBCP,Hive and HBas…

2020-10-20 Thread GitBox
mattyb149 commented on pull request #4588: URL: https://github.com/apache/nifi/pull/4588#issuecomment-712879544 Can you share a use case where this happens? I'm guessing if you have a validation query that does "too much work" and the DB goes down or something, maybe the query would

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #920: MINIFICPP-1296 - All tests should use volatile state storage

2020-10-20 Thread GitBox
adamdebreceni commented on a change in pull request #920: URL: https://github.com/apache/nifi-minifi-cpp/pull/920#discussion_r508484578 ## File path: extensions/standard-processors/tests/unit/TailFileTests.cpp ## @@ -1129,8 +1129,11 @@ TEST_CASE("TailFile finds and finishes

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #920: MINIFICPP-1296 - All tests should use volatile state storage

2020-10-20 Thread GitBox
adamdebreceni commented on a change in pull request #920: URL: https://github.com/apache/nifi-minifi-cpp/pull/920#discussion_r508473323 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -497,11 +497,8 @@ bool TailFile::recoverState(const

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #920: MINIFICPP-1296 - All tests should use volatile state storage

2020-10-20 Thread GitBox
adamdebreceni commented on a change in pull request #920: URL: https://github.com/apache/nifi-minifi-cpp/pull/920#discussion_r508460189 ## File path: libminifi/include/utils/ThreadPool.h ## @@ -227,11 +227,10 @@ class ThreadPool { * Returns true if a task is running.

[GitHub] [nifi] turcsanyip commented on a change in pull request #4510: NIFI-7549 Adding Hazelcast based DistributedMapCacheClient support

2020-10-20 Thread GitBox
turcsanyip commented on a change in pull request #4510: URL: https://github.com/apache/nifi/pull/4510#discussion_r508028622 ## File path:

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #914: MINIFICPP-1323 Encrypt sensitive properties using libsodium

2020-10-20 Thread GitBox
szaszm commented on a change in pull request #914: URL: https://github.com/apache/nifi-minifi-cpp/pull/914#discussion_r508418996 ## File path: libminifi/include/properties/Properties.h ## @@ -65,7 +65,7 @@ class Properties { * @param value value in which to place the map's

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on pull request #928: MINIFICPP-1394 - Speed up ConsumeWindowsEventLog processor

2020-10-20 Thread GitBox
adamdebreceni commented on pull request #928: URL: https://github.com/apache/nifi-minifi-cpp/pull/928#issuecomment-712732711 with the following setup: CWEL -> LogAttribute, CWEL: {batch commit size: 1000, output format both, 1 sec timer driven}, LogAttribute: {1000 batch size, event

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #928: MINIFICPP-1394 - Speed up ConsumeWindowsEventLog processor

2020-10-20 Thread GitBox
fgerlits commented on a change in pull request #928: URL: https://github.com/apache/nifi-minifi-cpp/pull/928#discussion_r508332309 ## File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp ## @@ -514,30 +515,33 @@ void

[GitHub] [nifi-minifi-cpp] adamdebreceni opened a new pull request #928: MINIFICPP-1394 - Speed up ConsumeWindowsEventLog processor

2020-10-20 Thread GitBox
adamdebreceni opened a new pull request #928: URL: https://github.com/apache/nifi-minifi-cpp/pull/928 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #914: MINIFICPP-1323 Encrypt sensitive properties using libsodium

2020-10-20 Thread GitBox
adamdebreceni commented on a change in pull request #914: URL: https://github.com/apache/nifi-minifi-cpp/pull/914#discussion_r508332045 ## File path: encrypt-config/ConfigFileEncryptor.cpp ## @@ -0,0 +1,64 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #926: MINIFICPP-1387 - Speed up Identifier to string conversion

2020-10-20 Thread GitBox
adamdebreceni commented on a change in pull request #926: URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r508274717 ## File path: libminifi/include/utils/Id.h ## @@ -65,10 +67,11 @@ class Identifier { bool operator!=(const Identifier& other) const;

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #926: MINIFICPP-1387 - Speed up Identifier to string conversion

2020-10-20 Thread GitBox
adamdebreceni commented on a change in pull request #926: URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r508247054 ## File path: libminifi/src/core/ProcessSession.cpp ## @@ -66,10 +66,12 @@ ProcessSession::~ProcessSession() { } void

[GitHub] [nifi] kevinbsilva commented on pull request #4605: NIFI-7932 Allow MonitorActivity's "Threshold Duration" property to use variables

2020-10-19 Thread GitBox
kevinbsilva commented on pull request #4605: URL: https://github.com/apache/nifi/pull/4605#issuecomment-712524341 Hello @pvillard31, thank you very much for your comment! There is no particular reason at all, i thought it would be a good idea when using older flows (from imports,

[GitHub] [nifi] thenatog commented on pull request #4592: NiFi-7819 - Add Zookeeper client TLS (external zookeeper) for cluster state management

2020-10-19 Thread GitBox
thenatog commented on pull request #4592: URL: https://github.com/apache/nifi/pull/4592#issuecomment-712504637 One thing I'm trying to change is passing through the Zookeeper TLS configuration from NiFi properties to the state provider. This will make configuration a lot simpler and less

[GitHub] [nifi] jfrazee commented on pull request #4592: NiFi-7819 - Add Zookeeper client TLS (external zookeeper) for cluster state management

2020-10-19 Thread GitBox
jfrazee commented on pull request #4592: URL: https://github.com/apache/nifi/pull/4592#issuecomment-712491718 I gave this a spin today and it works as expected. I tested with JKS stores and ListFile with a network filesystem. I agree with some of the other comments, but probably makes

[GitHub] [nifi] jfrazee commented on a change in pull request #4592: NiFi-7819 - Add Zookeeper client TLS (external zookeeper) for cluster state management

2020-10-19 Thread GitBox
jfrazee commented on a change in pull request #4592: URL: https://github.com/apache/nifi/pull/4592#discussion_r508113540 ## File path:

[GitHub] [nifi] exceptionfactory commented on a change in pull request #4250: NIFI-7401 Add ZooKeeper client TLS to CuratorLeaderElectionManager

2020-10-19 Thread GitBox
exceptionfactory commented on a change in pull request #4250: URL: https://github.com/apache/nifi/pull/4250#discussion_r508111993 ## File path:

[GitHub] [nifi] jfrazee commented on a change in pull request #4250: NIFI-7401 Add ZooKeeper client TLS to CuratorLeaderElectionManager

2020-10-19 Thread GitBox
jfrazee commented on a change in pull request #4250: URL: https://github.com/apache/nifi/pull/4250#discussion_r507950335 ## File path:

[GitHub] [nifi] thenatog commented on pull request #4250: NIFI-7401 Add ZooKeeper client TLS to CuratorLeaderElectionManager

2020-10-19 Thread GitBox
thenatog commented on pull request #4250: URL: https://github.com/apache/nifi/pull/4250#issuecomment-712293762 +1 from me, keen to get this merged so I can fix up my PR so we can get it all merged it. This is an automated

[GitHub] [nifi] pgyori commented on a change in pull request #4603: NIFI-7922: Added support for GET in ListenHTTP for health check

2020-10-19 Thread GitBox
pgyori commented on a change in pull request #4603: URL: https://github.com/apache/nifi/pull/4603#discussion_r507819038 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListenHTTP.java ## @@ -351,6

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #926: MINIFICPP-1387 - Speed up Identifier to string conversion

2020-10-19 Thread GitBox
szaszm commented on a change in pull request #926: URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507815133 ## File path: libminifi/include/utils/SmallString.h ## @@ -0,0 +1,86 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #926: MINIFICPP-1387 - Speed up Identifier to string conversion

2020-10-19 Thread GitBox
szaszm commented on a change in pull request #926: URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507814242 ## File path: libminifi/src/core/ProcessSession.cpp ## @@ -66,10 +66,12 @@ ProcessSession::~ProcessSession() { } void ProcessSession::add(const

[GitHub] [nifi] pgyori commented on a change in pull request #4603: NIFI-7922: Added support for GET in ListenHTTP for health check

2020-10-19 Thread GitBox
pgyori commented on a change in pull request #4603: URL: https://github.com/apache/nifi/pull/4603#discussion_r507811792 ## File path:

[GitHub] [nifi] pgyori commented on a change in pull request #4603: NIFI-7922: Added support for GET in ListenHTTP for health check

2020-10-19 Thread GitBox
pgyori commented on a change in pull request #4603: URL: https://github.com/apache/nifi/pull/4603#discussion_r507808251 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/servlets/ListenHTTPServlet.java

[GitHub] [nifi] pgyori commented on a change in pull request #4603: NIFI-7922: Added support for GET in ListenHTTP for health check

2020-10-19 Thread GitBox
pgyori commented on a change in pull request #4603: URL: https://github.com/apache/nifi/pull/4603#discussion_r507799954 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/servlets/HealthCheckServlet.java

[GitHub] [nifi] pgyori commented on pull request #4603: NIFI-7922: Added support for GET in ListenHTTP for health check

2020-10-19 Thread GitBox
pgyori commented on pull request #4603: URL: https://github.com/apache/nifi/pull/4603#issuecomment-712194518 > > > The concept of a health check for deployment behind a load balancer is useful, but listening on a different port and having a different approach to TLS negotiation may not be

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #926: MINIFICPP-1387 - Speed up Identifier to string conversion

2020-10-19 Thread GitBox
szaszm commented on a change in pull request #926: URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507780131 ## File path: libminifi/include/utils/Id.h ## @@ -65,10 +67,11 @@ class Identifier { bool operator!=(const Identifier& other) const; bool

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #926: MINIFICPP-1387 - Speed up Identifier to string conversion

2020-10-19 Thread GitBox
adamdebreceni commented on a change in pull request #926: URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507761664 ## File path: libminifi/include/utils/Id.h ## @@ -65,10 +67,11 @@ class Identifier { bool operator!=(const Identifier& other) const;

[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #927: MINIFICPP-1392 - Fix and test streams reading/writing zero-length data

2020-10-19 Thread GitBox
arpadboda closed pull request #927: URL: https://github.com/apache/nifi-minifi-cpp/pull/927 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

  1   2   3   4   5   6   7   8   9   10   >