[jira] [Updated] (NIFI-3142) ExtractHL7Attributes processor does not route to REL_FAILURE for an exception other than an HL7Exception

2017-03-28 Thread Kirby Linvill (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirby Linvill updated NIFI-3142:

Status: Open  (was: Patch Available)

Additional logic should be added to catch seen exceptions rather than catching 
all exceptions in general to prevent the possibility of data loss. As a result, 
I am cancelling this patch.

> ExtractHL7Attributes processor does not route to REL_FAILURE for an exception 
> other than an HL7Exception
> 
>
> Key: NIFI-3142
> URL: https://issues.apache.org/jira/browse/NIFI-3142
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.0.0
>Reporter: Kirby Linvill
>Priority: Minor
>  Labels: easyfix
>
> The ExtractHL7Attribute processor will not route a flowfile to REL_FAILURE if 
> processing the flow file throws an exception that is not an HL7Exception. 
> This bug is a result of the try catch block in the onTrigger method. It is 
> easily fixed by changing the catch block to catch a throwable object. Change
> {noformat} 
> try {
> ...
> } catch (final HL7Exception e) {
> getLogger().error("Failed to extract attributes from {} due to {}", new 
> Object[]{flowFile, e}, e);
> session.transfer(flowFile, REL_FAILURE);
> return;
> }
> {noformat} 
> to 
> {noformat} 
> try {
> ...
> } catch (final Throwable t) {
> getLogger().error("Failed to extract attributes from {} due to {}", new 
> Object[]{flowFile, t}, t);
> session.transfer(flowFile, REL_FAILURE);
> return;
> }
> {noformat} 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (NIFI-3142) ExtractHL7Attributes processor does not route to REL_FAILURE for an exception other than an HL7Exception

2016-12-02 Thread Kirby Linvill (JIRA)
Kirby Linvill created NIFI-3142:
---

 Summary: ExtractHL7Attributes processor does not route to 
REL_FAILURE for an exception other than an HL7Exception
 Key: NIFI-3142
 URL: https://issues.apache.org/jira/browse/NIFI-3142
 Project: Apache NiFi
  Issue Type: Bug
  Components: Extensions
Affects Versions: 1.0.0
Reporter: Kirby Linvill
Priority: Minor


The ExtractHL7Attribute processor will not route a flowfile to REL_FAILURE if 
processing the flow file throws an exception that is not an HL7Exception. This 
bug is a result of the try catch block in the onTrigger method. It is easily 
fixed by changing the catch block to catch a throwable object. Change
{noformat} 
try {
...
} catch (final HL7Exception e) {
getLogger().error("Failed to extract attributes from {} due to {}", new 
Object[]{flowFile, e}, e);
session.transfer(flowFile, REL_FAILURE);
return;
}
{noformat} 

to 

{noformat} 
try {
...
} catch (final Throwable t) {
getLogger().error("Failed to extract attributes from {} due to {}", new 
Object[]{flowFile, t}, t);
session.transfer(flowFile, REL_FAILURE);
return;
}
{noformat} 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)