[GitHub] nifi issue #2780: NIFI-5289 - Changed nifi-mock junit Dependency to Compile ...

2018-07-08 Thread MartinPayne
Github user MartinPayne commented on the issue: https://github.com/apache/nifi/pull/2780 > The global declaration for JUnit is JUnit 4.12. If someone is using v5, they'll have to work around that. Yes, we're using a workaround at the moment. We have to declare JUni

[GitHub] nifi issue #2780: NIFI-5289 - Changed nifi-mock junit Dependency to Compile ...

2018-07-08 Thread MartinPayne
Github user MartinPayne commented on the issue: https://github.com/apache/nifi/pull/2780 @MikeThomsen I'm not too sure what you mean. At the moment you'll get a NoClassDefFoundError unless JUnit 4 happens to be on the test classpath (it won't be on the test classpath if you're using

[GitHub] nifi-maven pull request #5: NIFI-5304 - Changed Lifecycle Phase Binding for ...

2018-06-12 Thread MartinPayne
GitHub user MartinPayne opened a pull request: https://github.com/apache/nifi-maven/pull/5 NIFI-5304 - Changed Lifecycle Phase Binding for Help Mojo Moved Maven Plugin Plugin help Mojo from "process-classes" to "generate-sources" lifecycle phase to

[GitHub] nifi issue #2780: NIFI-5289 - Changed nifi-mock junit Dependency to Compile ...

2018-06-11 Thread MartinPayne
Github user MartinPayne commented on the issue: https://github.com/apache/nifi/pull/2780 @joewitt Compile scope is the correct scope in this case. If JUnit 4 was only used in the tests for NiFi Mock, test scope would be correct. However, the [NiFi Mock code uses JUnit 4 as a compile

[GitHub] nifi pull request #2780: NIFI-5289 - Changed nifi-mock junit Dependency to C...

2018-06-10 Thread MartinPayne
GitHub user MartinPayne opened a pull request: https://github.com/apache/nifi/pull/2780 NIFI-5289 - Changed nifi-mock junit Dependency to Compile Scope Resolves NoClassDefFoundError for org.junit.Assert when using nifi-mock. Thank you for submitting a contribution to Apache