[GitHub] nifi issue #1450: NIFI-3339b Add getDataSource() to DBCPService, second vers...
Github user ToivoAdams commented on the issue: https://github.com/apache/nifi/pull/1450 @ijokarumawak @mattyb149 We could add example how to use String JDBC to wiki. No need to be part of NiFi codebase. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1450: NIFI-3339b Add getDataSource() to DBCPService, second vers...
Github user ToivoAdams commented on the issue: https://github.com/apache/nifi/pull/1450 Hi @ijokarumawak I have something like this already in use. This was meant to be temporary solution until ârightâ implementation is available. Now I am little bit confused. Wrapping outside of the DBCPService feels like temporary workaround? No? And just to be sure I need to do some more testing. Thanks Toivo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1417: NIFI-3339 Add getDataSource() to DBCPService.
Github user ToivoAdams closed the pull request at: https://github.com/apache/nifi/pull/1417 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1450: NIFI-3339b Add getDataSource() to DBCPService, seco...
GitHub user ToivoAdams opened a pull request: https://github.com/apache/nifi/pull/1450 NIFI-3339b Add getDataSource() to DBCPService, second version Thank you for submitting a contribution to Apache NiFi. ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ToivoAdams/nifi nifi-3339b Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1450.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1450 commit 30cd21d7064af611bae6310e959b60df257249fc Author: Toivo Adams <toivo.ad...@gmail.com> Date: 2017-01-29T11:40:37Z NIFI-3339b Add getDataSource() to DBCPService, second version --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #984: Nifi 2624
Github user ToivoAdams commented on the issue: https://github.com/apache/nifi/pull/984 I created new pull request #1142 Could not reopen this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1142: NIFI-2624 JdbcCommon treats BigDecimals now as Avro...
GitHub user ToivoAdams opened a pull request: https://github.com/apache/nifi/pull/1142 NIFI-2624 JdbcCommon treats BigDecimals now as Avro Logical type usin⦠Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. â¦g bytes to hold data (not String as is was before). You can merge this pull request into a Git repository by running: $ git pull https://github.com/ToivoAdams/nifi nifi-2624b Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1142.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1142 commit 4d6de9663087ebb30041341c8d55de01c4af3875 Author: Toivo Adams <toivo.ad...@gmail.com> Date: 2016-10-16T17:15:33Z NIFI-2624 JdbcCommon treats BigDecimals now as Avro Logical type using bytes to hold data (not String as is was before). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #984: Nifi 2624
Github user ToivoAdams commented on the issue: https://github.com/apache/nifi/pull/984 @trixpan I did rebase, resolved conflicts. Git refused to push. So I used force push. toivo@Optx:~/git/nifi$ git push origin -f nifi-2624 Counting objects: 2712, done. Delta compression using up to 4 threads. Compressing objects: 100% (1079/1079), done. Writing objects: 100% (2712/2712), 2.51 MiB | 1.81 MiB/s, done. Total 2712 (delta 952), reused 2399 (delta 740) remote: Resolving deltas: 100% (952/952), completed with 402 local objects. To g...@github.com:ToivoAdams/nifi.git + 7e33a04...540ef63 nifi-2624 -> nifi-2624 (forced update) Now PR is closed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #984: Nifi 2624
Github user ToivoAdams closed the pull request at: https://github.com/apache/nifi/pull/984 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #388: nifi-1214b Mock Framework should allow order-indepen...
Github user ToivoAdams closed the pull request at: https://github.com/apache/nifi/pull/388 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #803: nifi-1214c Mock Framework should allow order-indepen...
Github user ToivoAdams closed the pull request at: https://github.com/apache/nifi/pull/803 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #803: nifi-1214c Mock Framework should allow order-independent as...
Github user ToivoAdams commented on the issue: https://github.com/apache/nifi/pull/803 New PR #1033 I did rebase as usual. But git refused to push and recommended pull before push. I did pull but it seems I should force push instead of pull. Thanks Toivo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1033: nifi-1214d Mock Framework …on FlowFiles. This rep...
GitHub user ToivoAdams opened a pull request: https://github.com/apache/nifi/pull/1033 nifi-1214d Mock Framework â¦on FlowFiles. This replaces previous nifi-1214c New Pull Request, replaces previous #803 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ToivoAdams/nifi nifi-1214d Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1033.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1033 commit 639df94ed2282c0efc11e0249b94c9e739c3aef5 Author: Toivo Adams <toivo.ad...@gmail.com> Date: 2016-09-20T08:35:07Z nifi-1214d Mock Framework â¦on FlowFiles. This replaces previous nifi-1214c --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #986: Nifi 2381
Github user ToivoAdams commented on the issue: https://github.com/apache/nifi/pull/986 Hi @pvillard31 I did changes. Thank you for reviewing. Toivo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #803: nifi-1214c Mock Framework should allow order-independent as...
Github user ToivoAdams commented on the issue: https://github.com/apache/nifi/pull/803 Git complained and I did what he recommend (git pull origin). It seems this was mistake. I will create another clean PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #984: Nifi 2624
GitHub user ToivoAdams opened a pull request: https://github.com/apache/nifi/pull/984 Nifi 2624 JDBC-to-Avro processors handle BigDecimals as Strings. JdbcCommon treats BigDecimals now as Avro Logical type using bytes to hold data (not String as is was before). You can merge this pull request into a Git repository by running: $ git pull https://github.com/ToivoAdams/nifi nifi-2624 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/984.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #984 commit 96717c6f39039f1af70ab7e66510fb3dfbf5732b Author: Toivo Adams <toivo.ad...@gmail.com> Date: 2016-08-28T16:56:58Z nifi-2624 JDBC-to-Avro processors handle BigDecimals as Strings. Upgrade Avro 1.7.1 to 1.8.1 commit 5cf2848b92b69e3f8971883835df8e425e59698c Author: Toivo Adams <toivo.ad...@gmail.com> Date: 2016-08-30T18:00:57Z nifi-2624 JDBC-to-Avro processors handle BigDecimals as Strings. First version. commit 90399c7382c93e188740433a4c653725429a2ab1 Author: Toivo Adams <toivo.ad...@gmail.com> Date: 2016-08-30T18:16:58Z nifi-2624 JDBC-to-Avro processors handle BigDecimals as Strings. Fix tabs. commit 7e33a0449244f6058726aea3f4a1591922efbe87 Author: Toivo Adams <toivo.ad...@gmail.com> Date: 2016-09-03T08:11:30Z nifi-2624 JDBC-to-Avro processors handle BigDecimals as Strings. Cleanup. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #388: nifi-1214b Mock Framework should allow order-independent as...
Github user ToivoAdams commented on the issue: https://github.com/apache/nifi/pull/388 I hope conflicts are now resolved. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
