Github user danieljimenez commented on the issue:
https://github.com/apache/nifi/pull/2420
There are two other PRs that supersede this one.
---
Github user danieljimenez commented on the issue:
https://github.com/apache/nifi/pull/3019
LGTM
---
Github user danieljimenez commented on the issue:
https://github.com/apache/nifi/pull/2682
Hey @pvillard31, I'm 100% okay with that. I'll even add you to my fork if
you want. I wont be able to circle back to this for a couple of weeks at least.
Thanks for all your help.
---
Github user danieljimenez commented on the issue:
https://github.com/apache/nifi/pull/2682
Is there anything I can do to ensure this makes it to 1.8? Thanks!
---
Github user danieljimenez commented on the issue:
https://github.com/apache/nifi/pull/2682
Plus I have no way to test.
---
Github user danieljimenez commented on the issue:
https://github.com/apache/nifi/pull/2682
I'd rather not, the scope of this keeps moving. I'd like to keep it focused
on master right now.
---
Github user danieljimenez commented on the issue:
https://github.com/apache/nifi/pull/2936
FWIW I am currently using a SNAPSHOT from 01782bf on a real RabbitMQ server.
---
Github user danieljimenez commented on the issue:
https://github.com/apache/nifi/pull/2936
@mosermw Port added sir. :)
---
Github user danieljimenez commented on the issue:
https://github.com/apache/nifi/pull/2936
@mosermw I can, I just enabled the fields most likely to be variables for
most use cases. If you'd like me to add that to this PR, I certainly can.
---
Github user danieljimenez commented on the issue:
https://github.com/apache/nifi/pull/2936
Missed a spot evaluating the attribute expressions. Fixed.
---
Github user danieljimenez commented on the issue:
https://github.com/apache/nifi/pull/2936
Awesome, thanks! That would mean it's targeted for 1.8.0, correct?
---
Github user danieljimenez commented on the issue:
https://github.com/apache/nifi/pull/2936
After rerunning the Travis failures are gone.
---
Github user danieljimenez commented on the issue:
https://github.com/apache/nifi/pull/2682
@pvillard31 thanks, I've added that and force pushed an update.
---
Github user danieljimenez commented on the issue:
https://github.com/apache/nifi/pull/2682
I'm not sure about the RAT plugin, but this is ready otherwise.
---
Github user danieljimenez commented on the issue:
https://github.com/apache/nifi/pull/2936
No idea what the travis failures are, they are definitely not related to
this change.
---
GitHub user danieljimenez opened a pull request:
https://github.com/apache/nifi/pull/2936
NIFI-5489: Add expression language support to AMQP processors HOST, Vâ¦
â¦HOST and USER Fields.
Thank you for submitting a contribution to Apache NiFi.
In order
Github user danieljimenez commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2682#discussion_r206191230
--- Diff:
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQueryBatch.java
---
@@ -0,0
Github user danieljimenez commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2682#discussion_r206158466
--- Diff:
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQueryBatch.java
---
@@ -0,0
Github user danieljimenez commented on the issue:
https://github.com/apache/nifi/pull/2682
Hi, sorry for the rebases. This is ready now.
---
Github user danieljimenez commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2682#discussion_r204721738
--- Diff:
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/BigQueryAttributes.java
Github user danieljimenez commented on the issue:
https://github.com/apache/nifi/pull/2826
Three cheers.\
---
Github user danieljimenez commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2682#discussion_r189218048
--- Diff:
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/BigQueryAttributes.java
Github user danieljimenez commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2682#discussion_r186428592
--- Diff:
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/AbstractGCPProcessor.java
---
@@ -36,14
GitHub user danieljimenez opened a pull request:
https://github.com/apache/nifi/pull/2682
NIFI-4731: BQ Processors and GCP library update.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure
24 matches
Mail list logo
