[GitHub] nifi pull request #3112: NIFI-5761 ReplaceText processor can stop processing...

2018-10-30 Thread gardellajuanpablo
Github user gardellajuanpablo commented on a diff in the pull request: https://github.com/apache/nifi/pull/3112#discussion_r229277738 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ReplaceText.java

[GitHub] nifi pull request #3112: NIFI-5761 ReplaceText processor can stop processing...

2018-10-29 Thread gardellajuanpablo
Github user gardellajuanpablo commented on a diff in the pull request: https://github.com/apache/nifi/pull/3112#discussion_r229159256 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/pom.xml --- @@ -24,6 +24,11 @@ nifi-api

[GitHub] nifi pull request #3112: NIFI-5761 ReplaceText processor can stop processing...

2018-10-29 Thread gardellajuanpablo
Github user gardellajuanpablo commented on a diff in the pull request: https://github.com/apache/nifi/pull/3112#discussion_r228913385 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ReplaceText.java

[GitHub] nifi pull request #3112: NIFI-5761 ReplaceText processor can stop processing...

2018-10-26 Thread gardellajuanpablo
GitHub user gardellajuanpablo opened a pull request: https://github.com/apache/nifi/pull/3112 NIFI-5761 ReplaceText processor can stop processing data if it evalua… …tes invalid expressions Thank you for submitting a contribution to Apache NiFi. In order to

[GitHub] nifi issue #2629: NIFI-5070 Fix java.sql.SQLException: ERROR 1101 (XCL01): R...

2018-07-10 Thread gardellajuanpablo
Github user gardellajuanpablo commented on the issue: https://github.com/apache/nifi/pull/2629 Hi @patricker, Regarding: "Also, this seems to specifically be for Phoenix. With the fix as is, I don't know if it's possible to tell the difference between a

[GitHub] nifi pull request #2625: NIFI-5049 Fix handling of Phonenix datetime columns

2018-05-21 Thread gardellajuanpablo
Github user gardellajuanpablo commented on a diff in the pull request: https://github.com/apache/nifi/pull/2625#discussion_r189665750 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard

[GitHub] nifi issue #2629: NIFI-5070 Fix java.sql.SQLException: ERROR 1101 (XCL01): R...

2018-04-12 Thread gardellajuanpablo
Github user gardellajuanpablo commented on the issue: https://github.com/apache/nifi/pull/2629 @zenfenan fixed checkstyle violations. Thanks ---

[GitHub] nifi pull request #2629: NIFI-5070 Fix java.sql.SQLException: ERROR 1101 (XC...

2018-04-11 Thread gardellajuanpablo
GitHub user gardellajuanpablo opened a pull request: https://github.com/apache/nifi/pull/2629 NIFI-5070 Fix java.sql.SQLException: ERROR 1101 (XCL01): ResultSet is… … closed Discovered on Phoenix Database by using QueryDatabaseTable processor. The fix consists on

[GitHub] nifi pull request #2625: NIFI-5049 Fix handling of Phonenix datetime columns

2018-04-11 Thread gardellajuanpablo
Github user gardellajuanpablo commented on a diff in the pull request: https://github.com/apache/nifi/pull/2625#discussion_r180787552 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/db/impl

[GitHub] nifi pull request #2625: NIFI-5049 Fix handling of Phonenix datetime columns

2018-04-11 Thread gardellajuanpablo
Github user gardellajuanpablo commented on a diff in the pull request: https://github.com/apache/nifi/pull/2625#discussion_r180786540 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard

[GitHub] nifi pull request #2625: NIFI-5049 Fix handling of Phonenix datetime columns

2018-04-11 Thread gardellajuanpablo
Github user gardellajuanpablo commented on a diff in the pull request: https://github.com/apache/nifi/pull/2625#discussion_r180747757 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard

[GitHub] nifi pull request #2625: NIFI-5049 Fix handling of Phonenix datetime columns

2018-04-11 Thread gardellajuanpablo
Github user gardellajuanpablo commented on a diff in the pull request: https://github.com/apache/nifi/pull/2625#discussion_r180747704 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java

[GitHub] nifi pull request #2625: NIFI-5049 Fix handling of Phonenix datetime columns

2018-04-11 Thread gardellajuanpablo
Github user gardellajuanpablo commented on a diff in the pull request: https://github.com/apache/nifi/pull/2625#discussion_r180747659 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/QueryDatabaseTableTest.java

[GitHub] nifi pull request #2625: NIFI-5049 Fix handling of Phonenix datetime columns

2018-04-10 Thread gardellajuanpablo
GitHub user gardellajuanpablo opened a pull request: https://github.com/apache/nifi/pull/2625 NIFI-5049 Fix handling of Phonenix datetime columns Fixed Error: ERROR 203 (22005): Type mismatch. TIMESTAMP and VARCHAR for = '2015-09-12 18:19:43.293' (sample date).

[GitHub] nifi issue #2507: Nifi 3093

2018-04-10 Thread gardellajuanpablo
Github user gardellajuanpablo commented on the issue: https://github.com/apache/nifi/pull/2507 @patricker I will create another ticket as you suggested. "Some JDBC Drivers do not support Query Timeout". ---

[GitHub] nifi pull request #2507: Nifi 3093

2018-03-13 Thread gardellajuanpablo
Github user gardellajuanpablo commented on a diff in the pull request: https://github.com/apache/nifi/pull/2507#discussion_r174227238 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/JdbcCommon.java

[GitHub] nifi pull request #2507: Nifi 3093

2018-03-02 Thread gardellajuanpablo
GitHub user gardellajuanpablo opened a pull request: https://github.com/apache/nifi/pull/2507 Nifi 3093 Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken

[GitHub] nifi issue #2480: NIFI-4893 Cannot convert Avro schemas to Record schemas wi...

2018-03-01 Thread gardellajuanpablo
Github user gardellajuanpablo commented on the issue: https://github.com/apache/nifi/pull/2480 @markap14 let me test it and I will let you know if it works in our environment. Thanks a lot. ---

[GitHub] nifi issue #2486: NIFI-4901 Json to Avro using Record framework does not sup...

2018-02-28 Thread gardellajuanpablo
Github user gardellajuanpablo commented on the issue: https://github.com/apache/nifi/pull/2486 @MikeThomsen the ticket is invalid. Please do not merge to master. ---

[GitHub] nifi pull request #2486: NIFI-4901 Json to Avro using Record framework does ...

2018-02-21 Thread gardellajuanpablo
GitHub user gardellajuanpablo opened a pull request: https://github.com/apache/nifi/pull/2486 NIFI-4901 Json to Avro using Record framework does not support union … …types with boolean Thank you for submitting a contribution to Apache NiFi. In order to

[GitHub] nifi pull request #2480: NIFI-4893 Cannot convert Avro schemas to Record sch...

2018-02-20 Thread gardellajuanpablo
Github user gardellajuanpablo commented on a diff in the pull request: https://github.com/apache/nifi/pull/2480#discussion_r169389143 --- Diff: nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/RecordField.java --- @@ -76,8 +77,12 @@ public RecordField

[GitHub] nifi pull request #2480: NIFI-4893 Cannot convert Avro schemas to Record sch...

2018-02-19 Thread gardellajuanpablo
GitHub user gardellajuanpablo opened a pull request: https://github.com/apache/nifi/pull/2480 NIFI-4893 Cannot convert Avro schemas to Record schemas with default … …arrays To test it run: mvn test "-pl" org.apache.nifi:nifi-avro-record-utils -a

[GitHub] nifi pull request #2185: NIFI-4330 ConsumeKafka* throw NullPointerException ...

2017-09-29 Thread gardellajuanpablo
GitHub user gardellajuanpablo opened a pull request: https://github.com/apache/nifi/pull/2185 NIFI-4330 ConsumeKafka* throw NullPointerException if Kafka message h… …as a null value It is possible null values to be stored in Kafka topics. Fixed handle this scenario