[GitHub] nifi issue #2671: NiFi-5102 - Adding Processors for MarkLogic DB

2018-11-27 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2671 If you take a look here https://nifi.apache.org/docs/nifi-docs/html/administration-guide.html#core-properties-br and checkout the 'nifi.nar.library.directory' section you can see how someone could

[GitHub] nifi issue #2671: NiFi-5102 - Adding Processors for MarkLogic DB

2018-11-27 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2671 as a good example where we should have though it through more as well we have some cool work done by the InfluxDB folks. They're now wanting to improve it in https://github.com/apache/nifi/pull/2743

[GitHub] nifi issue #2671: NiFi-5102 - Adding Processors for MarkLogic DB

2018-11-27 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2671 @ryanjdew We have addressed Travis-CI related tests issues and the build has been stable now since. It could break again as people add timing dependent tests that behave wildly different on slow

[GitHub] nifi pull request #3165: NIFI-5318 Implement NiFi test harness

2018-11-24 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/3165#discussion_r236045703 --- Diff: nifi-testharness/src/test/resources/sample_technology_rss.xml --- @@ -0,0 +1,28 @@ + + --- End diff -- this xml document looks

[GitHub] nifi pull request #3181: NIFI-5836 changed the brittle timing based tests to...

2018-11-21 Thread joewitt
GitHub user joewitt opened a pull request: https://github.com/apache/nifi/pull/3181 NIFI-5836 changed the brittle timing based tests to integration tests Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi issue #3000: NIFI-5560 Added Follow SYMLINK support for ListFTP & ListS...

2018-11-21 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/3000 +1 merged to master - thanks ---

[GitHub] nifi issue #3000: NIFI-5560 Added Follow SYMLINK support for ListFTP & ListS...

2018-11-21 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/3000 reviewing now ---

[GitHub] nifi issue #3126: NIFI-5753 Add SSL support to HortonworksSchemaRegistry ser...

2018-11-21 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/3126 thanks for the contrib. i've not tested it on a live/secured instance. Have you done so? ---

[GitHub] nifi issue #3180: NIFI-5833 Treat GetTwitter API properties as sensitive

2018-11-21 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/3180 actually looks like the todo may be legit to hang around in general and isn't specific to this twitter scenario so will leave that alone. given kojis review and comments and mine am +1 will merge

[GitHub] nifi pull request #3180: NIFI-5833 Treat GetTwitter API properties as sensit...

2018-11-21 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/3180#discussion_r235417790 --- Diff: nifi-nar-bundles/nifi-social-media-bundle/nifi-twitter-processors/src/main/java/org/apache/nifi/processors/twitter/GetTwitter.java --- @@ -56,24

[GitHub] nifi issue #3178: NIFI-4914: Add Apache Pulsar processors

2018-11-20 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/3178 the output log had "14:11:44.805 [pool-67-thread-1] ERROR org.apache.nifi.processors.pulsar.pubsub.PublishPulsarRecord - PublishPulsarRecord[id=9c298cea-0e2a-4a59-8864-92e95563d7f4] Unable to pu

[GitHub] nifi issue #3178: NIFI-4914: Add Apache Pulsar processors

2018-11-20 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/3178 build on large machine now has a unit test failure [ERROR] Failures: [ERROR] TestAsyncPublishPulsarRecord.pulsarClientExceptionTest:56 expected:<1> but was:<0> [INFO]

[GitHub] nifi pull request #3178: NIFI-4914: Add Apache Pulsar processors

2018-11-20 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/3178#discussion_r235108402 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/pubsub/ConsumePulsarRecord.java

[GitHub] nifi pull request #3178: NIFI-4914: Add Apache Pulsar processors

2018-11-20 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/3178#discussion_r235107847 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/pubsub/ConsumePulsar.java --- @@ -0,0

[GitHub] nifi pull request #3178: NIFI-4914: Add Apache Pulsar processors

2018-11-20 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/3178#discussion_r235106784 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/AbstractPulsarProducerProcessor.java

[GitHub] nifi pull request #3178: NIFI-4914: Add Apache Pulsar processors

2018-11-20 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/3178#discussion_r235102894 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/pom.xml --- @@ -0,0 +1,84 @@ + + +http://maven.apache.org/POM/4.0.0

[GitHub] nifi pull request #3178: NIFI-4914: Add Apache Pulsar processors

2018-11-20 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/3178#discussion_r235102831 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/pom.xml --- @@ -0,0 +1,84 @@ + + +http://maven.apache.org/POM/4.0.0

[GitHub] nifi pull request #3178: NIFI-4914: Add Apache Pulsar processors

2018-11-20 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/3178#discussion_r235102049 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/StandardPulsarClientService.java --- @@ -0,0

[GitHub] nifi pull request #3178: NIFI-4914: Add Apache Pulsar processors

2018-11-20 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/3178#discussion_r235101491 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/StandardPulsarClientService.java --- @@ -0,0

[GitHub] nifi pull request #3178: NIFI-4914: Add Apache Pulsar processors

2018-11-20 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/3178#discussion_r235099937 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service-api/src/main/java/org/apache/nifi/pulsar/cache/LRUCache.java --- @@ -0,0 +1,86

[GitHub] nifi issue #3178: NIFI-4914: Add Apache Pulsar processors

2018-11-20 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/3178 cool thanks. can you please take a look at my comment regarding the security related property. ---

[GitHub] nifi issue #3178: NIFI-4914: Add Apache Pulsar processors

2018-11-20 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/3178 just did a full clean build with 6 threads on an older macbook and no problems. i'll try to reproduce my build issue from yesterday on a much higher thread build/machine and advise if issue i saw

[GitHub] nifi issue #3178: NIFI-4914: Add Apache Pulsar processors

2018-11-20 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/3178 @david-streamlio i had comments on the previous PR. Can you please review those/pull them forward to this. In the future you could rebase, squash, and force push the PR if you want to get back

[GitHub] nifi pull request #2882: NIFI-4914

2018-11-19 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2882#discussion_r234765596 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/StandardPulsarClientService.java --- @@ -0,0

[GitHub] nifi issue #2882: NIFI-4914

2018-11-19 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2882 @david-streamlio its not likely we'll put a feature like this into an already released line. It doesn't fit our semver scheme. Also, on my local branch i have the changes i needed from your

[GitHub] nifi issue #2882: NIFI-4914

2018-11-16 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2882 am building against master - is 1.9.0. changing it to 1.9.0-SNAPSHOT and ignoring last commit addresses it. travis fails for a similar reason i'd guess. Probably makes sense to ditch the merge

[GitHub] nifi issue #2882: NIFI-4914

2018-11-16 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2882 the build doesn't work...at least for me or travis. also not with the new patch. i've not looked into why yet but we dont use relative paths anywhere that i know of so not sure what the latest

[GitHub] nifi issue #2882: NIFI-4914

2018-11-16 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2882 travis and local builds dont work due to some parent relative path issues. can you please confirm you're following the pattern that other components follow with regards to pom contents ---

[GitHub] nifi issue #3174: [WIP] NIFI-5820 NiFi built on Java 1.8 can run on Java 9/1...

2018-11-16 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/3174 it built with java 8. switched to 11. nifi starts up and appears to be working great. I did notice this on startup nifi.sh: JAVA_HOME not set; results may vary Java home

[GitHub] nifi issue #3130: NIFI-5791: Add Apache Daffodil (incubating) bundle

2018-11-05 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/3130 First of all this looks like a really thought out contribution and huge thanks for taking the time to create what looks like a well done NOTICE file! I'm not sure about the naming/intent

[GitHub] nifi issue #2671: NiFi-5102 - Adding Processors for MarkLogic DB

2018-10-31 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2671 team; given https://github.com/marklogic/nifi/releases could we consider closing this PR and keeping the MarkLogic artifact creation/maintenance something MarkLogic takes care of at this time

[GitHub] nifi pull request #3033: NIFI-5629 GetFile vast listing performance

2018-10-18 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/3033#discussion_r226293537 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetFile.java --- @@ -308,32

[GitHub] nifi pull request #3033: NIFI-5629 GetFile vast listing performance

2018-10-18 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/3033#discussion_r226292672 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetFile.java --- @@ -270,6 +280,9

[GitHub] nifi issue #3078: NIFI-4805 Allow Delayed Transfer

2018-10-17 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/3078 @patricker yeah sorry - i agree. I just meant that once you pull a flowfile from the queue and find it isn't time (and perhaps not even close to time) to send it to success you need to do something

[GitHub] nifi issue #3078: NIFI-4805 Allow Delayed Transfer

2018-10-17 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/3078 I do think so to be honest and i say that knowing it would be a good bit more work. You can penalize flowfiles though that are 'not ready' - we might need to allow penalization values on a per

[GitHub] nifi issue #3078: NIFI-4805 Allow Delayed Transfer

2018-10-17 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/3078 We should avoid calling this processor a 'PenalizeFlowFile' processor. First, we have a notion of penalization in the framework already and it has a very specific meaning and it kicks in when

[GitHub] nifi issue #3084: NIFI-5689 ReplaceText does not handle end of line correctl...

2018-10-16 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/3084 we cannot edit/alter NLKBufferedReader as-is. It needs to be completely redone as per https://issues.apache.org/jira/browse/NIFI-5711 ---

[GitHub] nifi issue #3062: NIFI-5686: Updated StandardProcessScheduler so that if it ...

2018-10-12 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/3062 @markap14 at least one relevant to this change test appears brittle and possible another... [ERROR] Tests run: 10, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 10.413 s <<<

[GitHub] nifi pull request #3053: NIFI-5660: JMSPublisher should not set header prope...

2018-10-09 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/3053#discussion_r223748531 --- Diff: nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/processors/JMSPublisher.java --- @@ -89,11 +89,14 @@ void

[GitHub] nifi pull request #3052: NIFI-5666 Updated all usages of Spring, beanutils, ...

2018-10-08 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/3052#discussion_r223551634 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/java/org/apache/nifi/controller/scheduling

[GitHub] nifi pull request #3052: NIFI-5666 Updated all usages of Spring, beanutils, ...

2018-10-08 Thread joewitt
GitHub user joewitt opened a pull request: https://github.com/apache/nifi/pull/3052 NIFI-5666 Updated all usages of Spring, beanutils, collections to mov… …e beyond deps with cves Thank you for submitting a contribution to Apache NiFi. In order to streamline

[GitHub] nifi issue #3034: NIFI-5479 - Fixed up dependencies to remove the WARNs caus...

2018-10-04 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/3034 also in checking the jolt transform processor's advanced ui i get this error now 2018-10-04 11:46:42,041 WARN [NiFi Web Server-87] o.e.j.s.h.C._nifi_jolt_transform_json_ui_1_8_0_SNAPSHOT

[GitHub] nifi issue #3034: NIFI-5479 - Fixed up dependencies to remove the WARNs caus...

2018-10-04 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/3034 I still see this one 2018-10-04 10:36:50,626 WARN [main] o.e.jetty.annotations.AnnotationParser Unknown asm implementation version, assuming version 393216 Did you see it? ---

[GitHub] nifi issue #3028: Nifi 4806

2018-10-03 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/3028 @mcgilman let me know off-list that the guava changes I made were too dangerous without more thorough evaluation. I've removed all guava changes from this PR as those can be taken up separately. ---

[GitHub] nifi issue #3040: NIFI-5648: Enable to launch NiFi and ignore the failed ext...

2018-10-02 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/3040 @kemixkoo I can understand where the desire for this comes from but I think this is a dangerous approach. Fundamentally we're saying that we know at startup time there is a classpath issue

[GitHub] nifi issue #3034: NIFI-5479 - Fixed up dependencies to remove the WARNs caus...

2018-10-02 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/3034 reviewing ---

[GitHub] nifi issue #3028: Nifi 4806

2018-09-25 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/3028 and i'll address the checkstyle finding [WARNING] src/test/java/org/apache/nifi/atlas/emulator/AtlasAPIV2ServerEmulator.java:[175,21] (blocks) LeftCurly: '{' at column 21 should

[GitHub] nifi issue #3028: Nifi 4806

2018-09-25 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/3028 new commons lang came out. grabbing that. will squash too to make reviewing easier from here ---

[GitHub] nifi pull request #3028: Nifi 4806

2018-09-24 Thread joewitt
GitHub user joewitt opened a pull request: https://github.com/apache/nifi/pull/3028 Nifi 4806 Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken

[GitHub] nifi pull request #2947: [WIP] NIFI-5516: Implement Load-Balanced Connection...

2018-09-18 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2947#discussion_r218446031 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/queue/clustered/partition

[GitHub] nifi issue #3007: NIFI-5596 Upgraded splunk-sdk-java version

2018-09-17 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/3007 @MikeThomsen if the nar now includes a dependency it did not previously include then the L will need to be updated, if necessary, to reflect that. I dont recall the case of jbcrypt but I dont think

[GitHub] nifi pull request #2968: NIFI-5456: AWS clients now work with private link e...

2018-08-28 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2968#discussion_r213431435 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/AbstractAWSProcessor.java --- @@ -286,7

[GitHub] nifi pull request #2933: NIFI-5479 Upgraded Jetty. Moved where we unpack bun...

2018-08-28 Thread joewitt
Github user joewitt closed the pull request at: https://github.com/apache/nifi/pull/2933 ---

[GitHub] nifi issue #2971: NIFI-5557: handling expired ticket by rollback and penaliz...

2018-08-28 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2971 @ekovacs thanks for your contribution. Are we sure there is no other course for us than to parse the exception cause for this case? If not, that is unfortunate but ok. The other question

[GitHub] nifi issue #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-08-20 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2956 Just having it called nifi-neo4j-bundle is probably sufficient. The intent with the bundles is to put like things with like dependencies together. It is about creating an isolated classloader

[GitHub] nifi issue #2944: [WIP] NIFI-5506 - support disabling wantClientAuth for use...

2018-08-10 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2944 On the PR: - Small things: 1) The message has the wrong JIRA number 2) The default of false is incorrect and should be true to remain consistent with current usage. Bigger concern

[GitHub] nifi issue #2846: NIFI-5381 Add GetSFTP and PutSFTP Unit Tests

2018-08-06 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2846 +1 if the change to the NOTICE is removed. Not needed in nar notice since those are only included in test scope (not in nar) ---

[GitHub] nifi pull request #2846: NIFI-5381 Add GetSFTP and PutSFTP Unit Tests

2018-08-06 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2846#discussion_r207997339 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-nar/src/main/resources/META-INF/NOTICE --- @@ -226,6 +226,11 @@ The following binary

[GitHub] nifi pull request #2882: NIFI-4914

2018-08-03 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2882#discussion_r207611496 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/StandardPulsarClientService.java --- @@ -0,0

[GitHub] nifi pull request #2882: NIFI-4914

2018-08-03 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2882#discussion_r207611364 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/StandardPulsarClientService.java --- @@ -0,0

[GitHub] nifi issue #2882: NIFI-4914

2018-08-02 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2882 sorry @david-streamlio i def would like to get it in as well. i will try to help soon ---

[GitHub] nifi issue #2933: NIFI-5479 Upgraded Jetty. Moved where we unpack bundled de...

2018-08-02 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2933 that would not enable us to work around this issue and does not bring the benefits that led to unpacking in the first place ---

[GitHub] nifi issue #2933: NIFI-5479 Upgraded Jetty. Moved where we unpack bundled de...

2018-08-02 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2933 big thanks to @mcgilman for finding the needed dep change in nifi-web-ui and identifying why we needed a workaround for how we extract working dir nar deps due to recent jetty change ---

[GitHub] nifi issue #2933: NIFI-5479 Upgraded Jetty. Moved where we unpack bundled de...

2018-08-02 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2933 2018-08-02 16:20:07,347 WARN [NiFi Web Server-21] o.e.jetty.annotations.AnnotationParser javax.inject.Inject scanned from multiple locations: jar:file:///Users/jwitt/Development/joewitt-nifi.git

[GitHub] nifi pull request #2933: NIFI-5479 Upgraded Jetty. Moved where we unpack bun...

2018-08-02 Thread joewitt
GitHub user joewitt opened a pull request: https://github.com/apache/nifi/pull/2933 NIFI-5479 Upgraded Jetty. Moved where we unpack bundled deps to so we… … can avoid a new jetty bug with META-INF loading logic. WIP for testing/eval. Not ready for merge Thank you

[GitHub] nifi issue #2931: NIFI-3531 Moved session.recover in JMSConsumer to exceptio...

2018-08-01 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2931 ok @mosermw sounds fair to me. ---

[GitHub] nifi issue #2931: NIFI-3531 Moved session.recover in JMSConsumer to exceptio...

2018-08-01 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2931 do we know what the original author intended by 'abrupt end OR exceptional situations'? This change covers exceptional (JMSException anyway) but what about 'abrupt'? ---

[GitHub] nifi issue #2884: NIFI-3993 Updated the ZooKeeper version to 3.4.10

2018-07-13 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2884 @jtstorck @YolandaMDavis and others interested - i recall some comments about holding off on updating zookeeper because of compatibility, etc.. Is that right? @HorizonNet did you test

[GitHub] nifi issue #2702: Added Apache Pulsar processors

2018-07-11 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2702 looks like we're back in git pr funkystate with tons of non contrib commits in the PR... ---

[GitHub] nifi issue #2838: Update processor group variable from a processor

2018-07-10 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2838 I've forced this PR closed. A new PR following the linked guidance can be submitted if there is a change needed. ---

[GitHub] nifi issue #2841: NIFI-5376 Removed deprecation warnings

2018-07-09 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2841 ok cool. Am +1 then on all of it. Builds great on travis, my local linux machine, osx. Thanks ---

[GitHub] nifi pull request #2841: NIFI-5376 Removed deprecation warnings

2018-07-09 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2841#discussion_r201208939 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/test/java/org/apache/nifi/cluster/coordination/flow

[GitHub] nifi pull request #2841: NIFI-5376 Removed deprecation warnings

2018-07-09 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2841#discussion_r201208738 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/flow

[GitHub] nifi pull request #2841: NIFI-5376 Removed deprecation warnings

2018-07-09 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2841#discussion_r201206790 --- Diff: nifi-commons/nifi-site-to-site-client/src/main/java/org/apache/nifi/remote/client/SiteToSiteClient.java --- @@ -720,7 +728,6 @@ public HttpProxy

[GitHub] nifi pull request #2841: NIFI-5376 Removed deprecation warnings

2018-07-09 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2841#discussion_r201205703 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/security/util/crypto/PasswordBasedEncryptor.java

[GitHub] nifi pull request #2841: NIFI-5376 Removed deprecation warnings

2018-07-09 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2841#discussion_r201204269 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/test/java/org/apache/nifi/processors/hadoop/TestListHDFS.java --- @@ -496,7 +496,7

[GitHub] nifi pull request #2841: NIFI-5376 Removed deprecation warnings

2018-07-09 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2841#discussion_r201204232 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/test/java/org/apache/nifi/processors/hadoop/TestGetHDFSFileInfo.java --- @@ -656,7

[GitHub] nifi pull request #2841: NIFI-5376 Removed deprecation warnings

2018-07-09 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2841#discussion_r201204095 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-site-to-site/src/main/java/org/apache/nifi/remote/protocol/http

[GitHub] nifi pull request #2841: NIFI-5376 Removed deprecation warnings

2018-07-09 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2841#discussion_r201202035 --- Diff: nifi-commons/nifi-site-to-site-client/src/main/java/org/apache/nifi/remote/client/http/HttpClient.java --- @@ -122,7 +120,7 @@ public

[GitHub] nifi pull request #2841: NIFI-5376 Removed deprecation warnings

2018-07-09 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2841#discussion_r201201974 --- Diff: nifi-commons/nifi-site-to-site-client/src/main/java/org/apache/nifi/remote/client/SiteToSiteClient.java --- @@ -107,12 +102,9

[GitHub] nifi issue #2854: NIFI-5355 ResizeImage Fails to read PNG type on some OS's

2018-07-09 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2854 ok cool thanks. assuming travis is happy i'd be a +1 ---

[GitHub] nifi issue #2854: NIFI-5355 ResizeImage Fails to read PNG type on some OS's

2018-07-09 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2854 @patricker I'm not finding good guidance in apache legal JIRA or the apache list archives yet here. However, lets be clear what we're evaluating. Initially this is code from

[GitHub] nifi issue #2854: NIFI-5355 ResizeImage Fails to read PNG type on some OS's

2018-07-09 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2854 Thanks @patricker . I understand your point about its likely licensing. However, I'm not sure that it is sufficient for Apache Software Foundation project purposes. I've read threads or comments

[GitHub] nifi issue #2856: NIFI-4811 Added two missing entries to the nifi-redis-serv...

2018-07-09 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2856 We need to ensure both nars produced have their LICENSE/NOTICE files representing all source/binary artifacts that will be included. The best way is to look at the content of the nar itself. I used

[GitHub] nifi issue #2780: NIFI-5289 - Changed nifi-mock junit Dependency to Compile ...

2018-07-09 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2780 it should be fine for junit dep to be compile scope for nifi-mock. nifi-mock will always be used under test scope so the transitive compile scoped deps will be ok. ---

[GitHub] nifi issue #2838: Update processor group variable from a processor

2018-07-09 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2838 @xlamer1st please close this PR as Andy mentions. For help on how to achieve what it looks like the goal is see Andy's advice above. For help on doing contributions see here https

[GitHub] nifi issue #2853: NIFI-5382 ConvertRecord Add Option To Drop 0 Record Files

2018-07-06 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2853 makes sense to be consistent with https://github.com/patricker/nifi/blob/f234f0b2e654027dcaa7e72acfd0f3d035377bae/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org

[GitHub] nifi pull request #2854: NIFI-5355 ResizeImage Fails to read PNG type on som...

2018-07-06 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2854#discussion_r200800108 --- Diff: nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/image/ResizeImage.java --- @@ -196,4 +187,53

[GitHub] nifi pull request #2854: NIFI-5355 ResizeImage Fails to read PNG type on som...

2018-07-06 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2854#discussion_r200800076 --- Diff: nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/image/ResizeImage.java --- @@ -17,8 +17,7

[GitHub] nifi issue #2848: NIFI-5383 Replaced hard-coded version with Maven property ...

2018-07-06 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2848 I see a couple errant uses in nifi-hbase pom(s) but otherwise it is all ok usage. In your evaluation of things looking ok it would have been a typical build I suspect. But we need

[GitHub] nifi issue #2843: NIFI-5318 Implement NiFi test harness: initial commit of n...

2018-07-06 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2843 I dont fully understand what this aims to achieve so please understand that in my comments. However, changes to the nifi-toolkit-tls module dont seem to apply to wanting a test harness style

[GitHub] nifi pull request #2843: NIFI-5318 Implement NiFi test harness: initial comm...

2018-07-06 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2843#discussion_r200799818 --- Diff: nifi-toolkit/nifi-toolkit-tls/src/main/java/org/apache/nifi/test/util/FileUtils.java --- @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache

[GitHub] nifi pull request #2843: NIFI-5318 Implement NiFi test harness: initial comm...

2018-07-06 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2843#discussion_r200799793 --- Diff: nifi-toolkit/nifi-toolkit-tls/src/main/java/org/apache/nifi/test/SimpleNiFiFlowDefinitionEditor.java --- @@ -0,0 +1,144

[GitHub] nifi pull request #2843: NIFI-5318 Implement NiFi test harness: initial comm...

2018-07-06 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2843#discussion_r200799695 --- Diff: nifi-docs/src/main/asciidoc/developer-guide.adoc --- @@ -2296,6 +2296,32 @@ threads that should be used to run the Processor can be set via

[GitHub] nifi pull request #2843: NIFI-5318 Implement NiFi test harness: initial comm...

2018-07-06 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2843#discussion_r200799698 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/main/java/org/apache/nifi/documentation/DocGenerator.java

[GitHub] nifi issue #2848: NIFI-5383 Replaced hard-coded version with Maven property ...

2018-07-06 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2848 this is not consistent with the rest of all modules in the project. the versions get changed correctly and automatically during the build release process. please revert this. if we want to change

[GitHub] nifi pull request #2841: NIFI-5376 Removed deprecation warnings

2018-07-06 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2841#discussion_r200703862 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-nar-utils/src/main/java/org/apache/nifi/nar/NarUnpacker.java --- @@ -264,7 +263,7

[GitHub] nifi issue #2806: NIFI-5068 Script to automate parts of RC validation

2018-06-26 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2806 should have them now ---

[GitHub] nifi issue #2813: NIFI-5084 Added GenerateRecord processor.

2018-06-26 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2813 Not sure. But we should just organize a proper effort to get an extension registry in play. It will take some time but with us not being able to make the download larger we should be properly

[GitHub] nifi issue #2806: NIFI-5068 Script to automate parts of RC validation

2018-06-26 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2806 @ottobackwards i'd recommend just moving this to be a bash script made available on the wiki and close the PR. You could 1. Propose an edit to the release process to make this available

  1   2   3   4   5   6   7   >