[GitHub] nifi issue #2518: NIFI-4637 Added support for visibility labels to the HBase...

2018-04-25 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/nifi/pull/2518 > Would you please educate me why delete operation uses expression instead of a comma separated labels as scan does The general reasoning is this: you may have multiple &quo

[GitHub] nifi pull request #2518: NIFI-4637 Added support for visibility labels to th...

2018-04-01 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/nifi/pull/2518#discussion_r178483377 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/pom.xml --- @@ -79,6 +80,73 @@ test

[GitHub] nifi issue #2518: NIFI-4637 Added support for visibility labels to the HBase...

2018-04-01 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/nifi/pull/2518 > Would you be open to a code review in the future (months away at least) if I were to start adding Accumulo support? Feel free to hit me up :) ---

[GitHub] nifi pull request #2518: NIFI-4637 Added support for visibility labels to th...

2018-03-29 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/nifi/pull/2518#discussion_r178044849 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/AbstractPutHBase.java --- @@ -63,6 +64,17

[GitHub] nifi pull request #2518: NIFI-4637 Added support for visibility labels to th...

2018-03-29 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/nifi/pull/2518#discussion_r178043080 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/pom.xml --- @@ -79,6 +80,73 @@ test

[GitHub] nifi pull request #2518: NIFI-4637 Added support for visibility labels to th...

2018-03-29 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/nifi/pull/2518#discussion_r178043335 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/pom.xml --- @@ -79,6 +80,73 @@ test

[GitHub] nifi issue #2360: NIFI-4323 Wrapped Get/ListHDFS hadoop operations in ugi.do...

2017-12-23 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/nifi/pull/2360 Corollary: can this be reproduced outside the context of NiFi now that a solution in NiFi was observed? Maybe that's a pending action item? :) ---

[GitHub] nifi issue #2360: NIFI-4323 Wrapped Get/ListHDFS hadoop operations in ugi.do...

2017-12-23 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/nifi/pull/2360 > use UGI.loginUserFromKeytab. This brings those components in line with daemon-process-style usage, made possible by NiFi's InstanceClassloader isolation. Relogin (on ticket expiry/connect

[GitHub] nifi pull request #1349: NIFI-1784 Initial commit for FetchHBaseRow processo...

2017-01-04 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/nifi/pull/1349#discussion_r94666507 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/FetchHBaseRow.java --- @@ -0,0 +1,407

[GitHub] nifi pull request #1349: NIFI-1784 Initial commit for FetchHBaseRow processo...

2016-12-24 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/nifi/pull/1349#discussion_r93823447 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/FetchHBaseRow.java --- @@ -0,0 +1,407

[GitHub] nifi pull request #1349: NIFI-1784 Initial commit for FetchHBaseRow processo...

2016-12-24 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/nifi/pull/1349#discussion_r93823430 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/FetchHBaseRow.java --- @@ -0,0 +1,407

[GitHub] nifi pull request #1349: NIFI-1784 Initial commit for FetchHBaseRow processo...

2016-12-24 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/nifi/pull/1349#discussion_r93823487 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/io/JsonQualifierAndValueRowSerializer.java

[GitHub] nifi pull request #1349: NIFI-1784 Initial commit for FetchHBaseRow processo...

2016-12-24 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/nifi/pull/1349#discussion_r93823474 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/FetchHBaseRow.java --- @@ -0,0 +1,407

[GitHub] nifi issue #1349: NIFI-1784 Initial commit for FetchHBaseRow processor

2016-12-21 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/nifi/pull/1349 I'll try to find some time to give this a review, might not happen before the holidays but I'll try :) --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi issue #1202: NIFI-2854: Refactor repositories and swap files to use sch...

2016-11-14 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/nifi/pull/1202 Thanks for the thoughtful explanation, @markap14! It's very apparent that you have put the thought into this one. Sorry for doubting :) --- If your project is set up for it, you can reply

[GitHub] nifi issue #1202: NIFI-2854: Refactor repositories and swap files to use sch...

2016-11-11 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/nifi/pull/1202 Have you considered using a library such as Google Protocol Buffers to reduce the debt on NiFi in maintaining custom serialization logic? --- If your project is set up for it, you can reply