[GitHub] nifi issue #1107: origin/NIFI-1526

2016-10-10 Thread mathiastiberghien
Github user mathiastiberghien commented on the issue: https://github.com/apache/nifi/pull/1107 Hi, I finally could build running all tests on my computer. I understood the licence header system and also that my repository shouldn't contain space otherwhise a lot o tests

[GitHub] nifi issue #1107: origin/NIFI-1526

2016-10-08 Thread mathiastiberghien
Github user mathiastiberghien commented on the issue: https://github.com/apache/nifi/pull/1107 Sorry for the 2 commits but I realise that lowercasing the methods in annotations changes a lot of files. I should have check before to commit but I'm really used to Visual Studio renaming

[GitHub] nifi issue #1107: origin/NIFI-1526

2016-10-07 Thread mathiastiberghien
Github user mathiastiberghien commented on the issue: https://github.com/apache/nifi/pull/1107 I'll correct styles (I'm really newbie to java and open source). I add issues to launch the styles tests so I hope I won't miss anything. Sorry for the undesired change. I had to put

[GitHub] nifi issue #1107: origin/NIFI-1526

2016-10-07 Thread mathiastiberghien
Github user mathiastiberghien commented on the issue: https://github.com/apache/nifi/pull/1107 I've been able to find the problem with Dummy processors (the class were declared in the test file which created an InstanciationException). So I commited the code with style corrections

[GitHub] nifi issue #1107: origin/NIFI-1526

2016-10-07 Thread mathiastiberghien
Github user mathiastiberghien commented on the issue: https://github.com/apache/nifi/pull/1107 Hello, Thanks for the comments. I have a question about unit test: I need to test the method createProcessor of the FlowController so I guess I need to update

[GitHub] nifi pull request #1107: origin/NIFI-1526

2016-10-05 Thread mathiastiberghien
GitHub user mathiastiberghien opened a pull request: https://github.com/apache/nifi/pull/1107 origin/NIFI-1526 This commit solves the issue 1526 adding DefaultSchedule and DefaultSettings annotation to the nifi-api This annotations are then use on Custom Processor classes