[GitHub] nifi pull request #2889: NIFI-5426: Use NIO.2 API for ListFile

2018-07-16 Thread mgaido91
Github user mgaido91 closed the pull request at: https://github.com/apache/nifi/pull/2889 ---

[GitHub] nifi issue #2889: NIFI-5426: Use NIO.2 API for ListFile

2018-07-15 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2889 Hi @markap14. I saw the comment on the JIRA that you merged this to master. Shall I close this PR then? thanks! ---

[GitHub] nifi pull request #2889: NIFI-5426: Use NIO.2 API for ListFile

2018-07-13 Thread mgaido91
GitHub user mgaido91 opened a pull request: https://github.com/apache/nifi/pull/2889 NIFI-5426: Use NIO.2 API for ListFile Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following

[GitHub] nifi issue #2789: NIFI-3242: Avoid double scheduling of a task due to quartz...

2018-06-13 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2789 cc @markap14 ---

[GitHub] nifi pull request #2789: NIFI-3242: Avoid double scheduling of a task due to...

2018-06-13 Thread mgaido91
GitHub user mgaido91 opened a pull request: https://github.com/apache/nifi/pull/2789 NIFI-3242: Avoid double scheduling of a task due to quartz imprecision Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask

[GitHub] nifi issue #2768: NIFI-5278: fixes JSON escaping of code parameter in Execut...

2018-06-09 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2768 LGTM ---

[GitHub] nifi pull request #2768: NIFI-5278: fixes JSON escaping of code parameter in...

2018-06-08 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2768#discussion_r194107658 --- Diff: nifi-nar-bundles/nifi-spark-bundle/nifi-livy-processors/src/test/java/org/apache/nifi/processors/livy/ExecuteSparkInteractiveTestBase.java

[GitHub] nifi pull request #2768: NIFI-5278: fixes JSON escaping of code parameter in...

2018-06-08 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2768#discussion_r194106518 --- Diff: nifi-nar-bundles/nifi-spark-bundle/nifi-livy-processors/src/test/java/org/apache/nifi/processors/livy/ExecuteSparkInteractiveTestBase.java

[GitHub] nifi pull request #2768: NIFI-5278: fixes JSON escaping of code parameter in...

2018-06-08 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2768#discussion_r194108030 --- Diff: nifi-nar-bundles/nifi-spark-bundle/nifi-livy-processors/src/test/java/org/apache/nifi/processors/livy/TestExecuteSparkInteractive.java

[GitHub] nifi pull request #2768: NIFI-5278: fixes JSON escaping of code parameter in...

2018-06-08 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2768#discussion_r194108434 --- Diff: nifi-nar-bundles/nifi-spark-bundle/nifi-livy-processors/src/test/java/org/apache/nifi/processors/livy/TestExecuteSparkInteractiveSSL.java

[GitHub] nifi issue #2754: NIFI-5262: Retrieve file attributes only once in ListFile

2018-06-06 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2754 thanks @pvillard31 ---

[GitHub] nifi pull request #2754: NIFI-5262: Retrieve file attributes only once in Li...

2018-06-04 Thread mgaido91
GitHub user mgaido91 opened a pull request: https://github.com/apache/nifi/pull/2754 NIFI-5262: Retrieve file attributes only once in ListFile Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi issue #2733: NIFI-5228: Allow user to choose whether or not to add File...

2018-05-23 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2733 LGTM, thanks ---

[GitHub] nifi pull request #2733: NIFI-5228: Allow user to choose whether or not to a...

2018-05-23 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2733#discussion_r190156015 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListFile.java --- @@ -255,43

[GitHub] nifi pull request #2733: NIFI-5228: Allow user to choose whether or not to a...

2018-05-23 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2733#discussion_r190155739 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListFile.java --- @@ -255,43

[GitHub] nifi issue #2657: NIFI-5109 Reset justElectedPrimaryNode flag right after re...

2018-05-22 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2657 LGTM, thanks @viazovskyi. @ijokarumawak @joewitt any other comments? ---

[GitHub] nifi issue #2657: NIFI-5109 Reset justElectedPrimaryNode flag right after re...

2018-05-21 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2657 @viazovskyi I suggest you something like: ``` git checkout nifi/master git checkout -b nifi-5109_2 // do your changes on this branch and commit them git branch -D nifi-5109 git

[GitHub] nifi issue #2657: NIFI-5109 Reset justElectedPrimaryNode flag right after re...

2018-05-21 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2657 @viazovskyi I think that the easiest way is probably creating a new branch locally from the master, reapply your changes on it and force push to this branch. ---

[GitHub] nifi issue #2657: NIFI-5109 Reset justElectedPrimaryNode flag right after re...

2018-05-21 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2657 @viazovskyi your last merge screwed a bit this PR. May you please restore it? Thanks. ---

[GitHub] nifi pull request #2657: NIFI-5109 Reset justElectedPrimaryNode flag right a...

2018-05-20 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2657#discussion_r189462936 --- Diff: nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/list/AbstractListProcessor.java

[GitHub] nifi pull request #2657: NIFI-5109 Reset justElectedPrimaryNode flag right a...

2018-05-20 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2657#discussion_r189455715 --- Diff: nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/list/AbstractListProcessor.java

[GitHub] nifi pull request #2657: NIFI-5109 Reset justElectedPrimaryNode flag right a...

2018-05-20 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2657#discussion_r189455719 --- Diff: nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/list/AbstractListProcessor.java

[GitHub] nifi issue #2657: NIFI-5109 Reset justElectedPrimaryNode flag right after re...

2018-05-17 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2657 @viazovskyi do you think it is possible to add a UT for this? ---

[GitHub] nifi pull request #2657: NIFI-5109 Reset justElectedPrimaryNode flag right a...

2018-05-17 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2657#discussion_r188866746 --- Diff: nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/list/AbstractListProcessor.java

[GitHub] nifi issue #2657: NIFI-5109 Reset justElectedPrimaryNode flag right after re...

2018-05-16 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2657 I also agree on @ijokarumawak's suggestion, may you please update the PR accordingly @viazovskyi ? ---

[GitHub] nifi issue #2630: NIFI-5041 Adds SPNEGO authentication to LivySessionControl...

2018-04-12 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2630 @ottobackwards yes, I agree and since the build passing is the one in France, I assume we are downloading from an European mirror. Can we change this according to the place of build? ---

[GitHub] nifi issue #2606: NIFI-5043: TailFile in Multifile mode should not open new ...

2018-04-05 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2606 Thank you for taking a look at this and reviewing it, @markap14! ---

[GitHub] nifi pull request #2606: NIFI-5043: TailFile in Multifile mode should not op...

2018-04-05 Thread mgaido91
GitHub user mgaido91 opened a pull request: https://github.com/apache/nifi/pull/2606 NIFI-5043: TailFile in Multifile mode should not open new readers in onTrigger Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution

[GitHub] nifi issue #2565: NIFI-4631: Use java.nio.file.Files in ListFile to improve ...

2018-03-23 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2565 @markap14 I don't know the reason but it might be because I run it on a deeply nested structure made basically all of folders. Probably the new solution is particularly more efficient in that case. ---

[GitHub] nifi pull request #2565: NIFI-4631: Use java.nio.file.Files in ListFile to i...

2018-03-19 Thread mgaido91
GitHub user mgaido91 opened a pull request: https://github.com/apache/nifi/pull/2565 NIFI-4631: Use java.nio.file.Files in ListFile to improve performance Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask

[GitHub] nifi issue #2544: NIFI-4959: Remove flowfiles and close connection for Bad R...

2018-03-16 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2544 Thanks for your help @markap14 ---

[GitHub] nifi issue #2544: NIFI-4959: Remove flowfiles and close connection for Bad R...

2018-03-16 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2544 the test error is unrelated: ``` [INFO] --- maven-remote-resources-plugin:1.5:process (process-resource-bundles) @ nifi-hive-processors --- [ERROR] Tests run: 4, Failures: 0, Errors: 1

[GitHub] nifi pull request #2544: NIFI-4959: Remove flowfiles and close connection fo...

2018-03-16 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2544#discussion_r175079382 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpRequest.java

[GitHub] nifi pull request #2544: NIFI-4959: Remove flowfiles and close connection fo...

2018-03-14 Thread mgaido91
GitHub user mgaido91 opened a pull request: https://github.com/apache/nifi/pull/2544 NIFI-4959: Remove flowfiles and close connection for Bad Requests causing IOException Thank you for submitting a contribution to Apache NiFi. In order to streamline the review

[GitHub] nifi pull request #2504: NIFI-4773: Fixed column type map initialization in ...

2018-03-02 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2504#discussion_r171887381 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java

[GitHub] nifi pull request #2504: NIFI-4773: Fixed column type map initialization in ...

2018-03-02 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2504#discussion_r171882320 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java

[GitHub] nifi issue #2201: NIFI-4367 Fix on processor for permit deriving script clas...

2018-02-21 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2201 @mattyb149 I think that the test error is unrelated. I run the failing test locally and it passes. Do you have further comments for this PR? ---

[GitHub] nifi issue #2201: NIFI-4367 Fix on processor for permit deriving script clas...

2018-02-15 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2201 kindly ping @frett27 ---

[GitHub] nifi issue #2226: NIFI-4080: Added EL support to fields in ValidateCSV

2018-02-08 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2226 +1, locally it builds and passes all the tests ---

[GitHub] nifi issue #2445: NIFI-4834: Updated AbstractJMSProcessor to use a separate ...

2018-02-07 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2445 on OSX they are passing too, so it may be a platform related error ---

[GitHub] nifi issue #2445: NIFI-4834: Updated AbstractJMSProcessor to use a separate ...

2018-02-07 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2445 this is causing some test failures on travis, but I am not able to reproduce the failures locally (https://api.travis-ci.org/v3/job/338096661/log.txt). Maybe we can revert it for the moment

[GitHub] nifi issue #2226: NIFI-4080: Added EL support to fields in ValidateCSV

2018-02-07 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2226 thanks @mattyb149. The test failures are not related to this PR. They are caused by 3ca7c3e7a19c7f496a214d9b93ace43b1507c9ec. I am investigating them. I am not sure if it is possible to re-trigger

[GitHub] nifi issue #2226: NIFI-4080: Added EL support to fields in ValidateCSV

2018-02-01 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2226 @mattyb149 there is a test failure because I just cherry-picked my changes on top of your PR, so when I run the tests, I didn't run the test you added here (sorry, my bad). This test is not valid

[GitHub] nifi issue #2201: NIFI-4367 Fix on processor for permit deriving script clas...

2018-01-29 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2201 @frett27 I did some more checks and it seems to work. Are you ok if I send a PR on your branch to improve the UT? Or can you please update this PR according to the comments (and in order to make

[GitHub] nifi issue #2201: NIFI-4367 Fix on processor for permit deriving script clas...

2018-01-25 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2201 @frett27 I tried your fix, but if you add custom properties to the scripted processor, then it results as invalid with the message: ``` ... is not a supported property. ``` Thus

[GitHub] nifi pull request #2201: NIFI-4367 Fix on processor for permit deriving scri...

2018-01-24 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2201#discussion_r163571877 --- Diff: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/resources/groovy/test_implementingabstractProcessor.groovy --- @@ -0,0

[GitHub] nifi pull request #2201: NIFI-4367 Fix on processor for permit deriving scri...

2018-01-24 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2201#discussion_r163569718 --- Diff: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java

[GitHub] nifi pull request #2201: NIFI-4367 Fix on processor for permit deriving scri...

2018-01-24 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2201#discussion_r163568827 --- Diff: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/script/impl

[GitHub] nifi pull request #2426: NIFI-4790: support HTTPS Proxy in InvokeHTTP

2018-01-24 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2426#discussion_r163554821 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java --- @@ -213,11

[GitHub] nifi issue #2294: NIFI-3538 Added DeleteHBaseRow

2018-01-24 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2294 LGTM ---

[GitHub] nifi issue #2294: NIFI-3538 Added DeleteHBaseRow

2018-01-24 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2294 thanks @MikeThomsen. Actually I was referring at [this comment](https://github.com/apache/nifi/pull/2294#discussion_r160140592). I think that is my last comment. Overall it LGTM

[GitHub] nifi issue #2426: NIFI-4790: support HTTPS Proxy in InvokeHTTP

2018-01-24 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2426 @ijokarumawak thanks, added the EL support. I am not sure why Appveyor is failing. The failure seems not related to the PR. ---

[GitHub] nifi issue #2294: NIFI-3538 Added DeleteHBaseRow

2018-01-23 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2294 @MikeThomsen sorry may you please address the last comment? And add the charset parameter? Thanks. ---

[GitHub] nifi pull request #2426: NIFI-4790: support HTTPS Proxy in InvokeHTTP

2018-01-23 Thread mgaido91
GitHub user mgaido91 opened a pull request: https://github.com/apache/nifi/pull/2426 NIFI-4790: support HTTPS Proxy in InvokeHTTP Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure

[GitHub] nifi issue #2401: NIFI-4759 Fixed a bug that left a hard-coded reference to ...

2018-01-14 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2401 @joewitt @pvillard31 maybe you can help reviewing this too, thanks. ---

[GitHub] nifi issue #2401: NIFI-4759 Fixed a bug that left a hard-coded reference to ...

2018-01-14 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2401 LGTM, thanks. ---

[GitHub] nifi pull request #2401: NIFI-4759 Fixed a bug that left a hard-coded refere...

2018-01-12 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2401#discussion_r161261787 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/test/java/org/apache/nifi/processors/mongodb/PutMongoTest.java --- @@ -256,4

[GitHub] nifi pull request #2401: NIFI-4759 Fixed a bug that left a hard-coded refere...

2018-01-12 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2401#discussion_r161261619 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/test/java/org/apache/nifi/processors/mongodb/PutMongoTest.java --- @@ -256,4

[GitHub] nifi pull request #2401: NIFI-4759 Fixed a bug that left a hard-coded refere...

2018-01-12 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2401#discussion_r161262183 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/test/java/org/apache/nifi/processors/mongodb/PutMongoTest.java --- @@ -256,4

[GitHub] nifi pull request #2392: NIFI-4759 Fixed a bug that left a hard-coded refere...

2018-01-12 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2392#discussion_r161213967 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/test/java/org/apache/nifi/processors/mongodb/PutMongoTest.java --- @@ -256,4

[GitHub] nifi pull request #2392: NIFI-4759 Fixed a bug that left a hard-coded refere...

2018-01-12 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2392#discussion_r161213577 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/test/java/org/apache/nifi/processors/mongodb/PutMongoTest.java --- @@ -256,4

[GitHub] nifi pull request #2392: NIFI-4759 Fixed a bug that left a hard-coded refere...

2018-01-12 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2392#discussion_r161213509 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/test/java/org/apache/nifi/processors/mongodb/PutMongoTest.java --- @@ -166,6

[GitHub] nifi pull request #2394: NIFI-4764: Add tooltips to status bar icons

2018-01-11 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2394#discussion_r160996254 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-process-group.js --- @@ -847,6 +870,7

[GitHub] nifi pull request #2392: NIFI-4759 Fixed a bug that left a hard-coded refere...

2018-01-11 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2392#discussion_r160982784 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/test/java/org/apache/nifi/processors/mongodb/PutMongoTest.java --- @@ -166,6

[GitHub] nifi pull request #2392: NIFI-4759 Fixed a bug that left a hard-coded refere...

2018-01-11 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2392#discussion_r160975782 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/test/java/org/apache/nifi/processors/mongodb/PutMongoTest.java --- @@ -256,4

[GitHub] nifi pull request #2392: NIFI-4759 Fixed a bug that left a hard-coded refere...

2018-01-11 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2392#discussion_r160975388 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/test/java/org/apache/nifi/processors/mongodb/PutMongoTest.java --- @@ -256,4

[GitHub] nifi pull request #2392: NIFI-4759 Fixed a bug that left a hard-coded refere...

2018-01-11 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2392#discussion_r160975264 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/test/java/org/apache/nifi/processors/mongodb/PutMongoTest.java --- @@ -256,4

[GitHub] nifi pull request #2392: NIFI-4759 Fixed a bug that left a hard-coded refere...

2018-01-11 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2392#discussion_r160975171 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java --- @@ -173,13

[GitHub] nifi pull request #2392: NIFI-4759 Fixed a bug that left a hard-coded refere...

2018-01-11 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2392#discussion_r160974686 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java --- @@ -173,13

[GitHub] nifi pull request #2392: NIFI-4759 Fixed a bug that left a hard-coded refere...

2018-01-11 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2392#discussion_r160973857 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java --- @@ -173,13

[GitHub] nifi pull request #2392: NIFI-4759 Fixed a bug that left a hard-coded refere...

2018-01-11 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2392#discussion_r160973717 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java --- @@ -173,13

[GitHub] nifi pull request #2392: NIFI-4759 Fixed a bug that left a hard-coded refere...

2018-01-11 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2392#discussion_r160972295 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/test/java/org/apache/nifi/processors/mongodb/PutMongoTest.java --- @@ -256,4

[GitHub] nifi pull request #2392: NIFI-4759 Fixed a bug that left a hard-coded refere...

2018-01-11 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2392#discussion_r160971847 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/test/java/org/apache/nifi/processors/mongodb/PutMongoTest.java --- @@ -256,4

[GitHub] nifi issue #2394: NIFI-4764: Add tooltips to status bar icons

2018-01-11 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2394 thanks for your suggestions and help @mcgilman. I updated the PR accordingly. Thanks. ---

[GitHub] nifi issue #2394: NIFI-4764: Add tooltips to status bar icons

2018-01-10 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2394 @mcgilman yes, sure, thanks for your comment. Just one question before proceeding. Doing this might involve some refactoring/non-trivial js, since process groups are in the canvas and therefore

[GitHub] nifi pull request #2394: NIFI-4764: Add tooltips to status bar icons

2018-01-10 Thread mgaido91
GitHub user mgaido91 opened a pull request: https://github.com/apache/nifi/pull/2394 NIFI-4764: Add tooltips to status bar icons Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure

[GitHub] nifi pull request #2392: NIFI-4759 Fixed a bug that left a hard-coded refere...

2018-01-10 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2392#discussion_r160685547 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java --- @@ -155,12 +155,7

[GitHub] nifi issue #2363: NIFI-4726: Avoid concurrency issues in JoltTransformJSON

2018-01-09 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2363 sure, thanks @ijokarumawak and @joewitt. Sorry for the mistake and wasting your time. ---

[GitHub] nifi pull request #2363: NIFI-4726: Avoid concurrency issues in JoltTransfor...

2018-01-09 Thread mgaido91
Github user mgaido91 closed the pull request at: https://github.com/apache/nifi/pull/2363 ---

[GitHub] nifi pull request #2294: NIFI-3538 Added DeleteHBaseRow

2018-01-08 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2294#discussion_r160140592 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/DeleteHBaseRow.java --- @@ -0,0 +1,154

[GitHub] nifi issue #2363: NIFI-4726: Avoid concurrency issues in JoltTransformJSON

2018-01-04 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2363 Thanks for your suggestion @joewitt, I'll update this PR accordingly ASAP, thanks. ---

[GitHub] nifi issue #2363: NIFI-4726: Avoid concurrency issues in JoltTransformJSON

2018-01-03 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2363 Thanks for your comment @joewitt. I think we can't fix this in jolt since the root cause is our concurrent usage of their utilities and fixing it there seems an overkill to me. What do you think

[GitHub] nifi pull request #2294: NIFI-3538 Added DeleteHBaseRow

2017-12-29 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2294#discussion_r159047973 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/DeleteHBaseRow.java --- @@ -0,0 +1,158

[GitHub] nifi pull request #2294: NIFI-3538 Added DeleteHBaseRow

2017-12-29 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2294#discussion_r159047906 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/DeleteHBaseRow.java --- @@ -0,0 +1,158

[GitHub] nifi issue #2294: NIFI-3538 Added DeleteHBaseRow

2017-12-29 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2294 @MikeThomsen there are validation errors due to unused imports. May you please fix them? ``` [WARNING] src/main/java/org/apache/nifi/hbase/DeleteHBaseRow.java:[31,8] (imports

[GitHub] nifi pull request #2363: NIFI-4726: Avoid concurrency issues in JoltTransfor...

2017-12-29 Thread mgaido91
GitHub user mgaido91 opened a pull request: https://github.com/apache/nifi/pull/2363 NIFI-4726: Avoid concurrency issues in JoltTransformJSON Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi pull request #2356: NIFI-3660: Support schema containing a map with an ...

2017-12-21 Thread mgaido91
GitHub user mgaido91 opened a pull request: https://github.com/apache/nifi/pull/2356 NIFI-3660: Support schema containing a map with an array value in ConvertAvroToORC Thank you for submitting a contribution to Apache NiFi. In order to streamline the review

[GitHub] nifi issue #2343: NIFI-2169: Cache compiled regexp for RouteText

2017-12-20 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2343 @markap14 do you have further comments on this? Thanks ---

[GitHub] nifi pull request #2294: NIFI-3538 Added DeleteHBaseRow

2017-12-17 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2294#discussion_r157414765 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/DeleteHBaseRow.java --- @@ -0,0 +1,178

[GitHub] nifi issue #2344: NIFI-4619: Enable EL on AWSCredentialsProviderControllerSe...

2017-12-17 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2344 thank you for your review @jvwing! ---

[GitHub] nifi pull request #2294: NIFI-3538 Added DeleteHBaseRow

2017-12-17 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2294#discussion_r157377689 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/DeleteHBaseRow.java --- @@ -0,0 +1,178

[GitHub] nifi pull request #2294: NIFI-3538 Added DeleteHBaseRow

2017-12-15 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2294#discussion_r157258216 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/DeleteHBaseRow.java --- @@ -0,0 +1,178

[GitHub] nifi pull request #2294: NIFI-3538 Added DeleteHBaseRow

2017-12-15 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2294#discussion_r157257248 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/DeleteHBaseRow.java --- @@ -0,0 +1,178

[GitHub] nifi pull request #2294: NIFI-3538 Added DeleteHBaseRow

2017-12-15 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2294#discussion_r157256777 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/DeleteHBaseRow.java --- @@ -0,0 +1,178

[GitHub] nifi pull request #2294: NIFI-3538 Added DeleteHBaseRow

2017-12-15 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2294#discussion_r157256636 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/DeleteHBaseRow.java --- @@ -0,0 +1,178

[GitHub] nifi pull request #2294: NIFI-3538 Added DeleteHBaseRow

2017-12-15 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2294#discussion_r157256381 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/DeleteHBaseRow.java --- @@ -0,0 +1,178

[GitHub] nifi pull request #2294: NIFI-3538 Added DeleteHBaseRow

2017-12-15 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2294#discussion_r157255826 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/DeleteHBaseRow.java --- @@ -0,0 +1,178

[GitHub] nifi pull request #2343: NIFI-2169: Cache compiled regexp for RouteText

2017-12-15 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2343#discussion_r157242761 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RouteText.java --- @@ -209,6

[GitHub] nifi pull request #2343: NIFI-2169: Cache compiled regexp for RouteText

2017-12-15 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2343#discussion_r157241548 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RouteText.java --- @@ -209,6

[GitHub] nifi pull request #2343: NIFI-2169: Cache compiled regexp for RouteText

2017-12-15 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2343#discussion_r157241247 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RouteText.java --- @@ -209,6

  1   2   >