[GitHub] nifi issue #1108: NIFI-2565: add Grok parser

Github user selim-namsi commented on the issue: https://github.com/apache/nifi/pull/1108 @trixpan @joewitt Sorry for the long delay, I applied the changes that you suggested such as, adding the custom validator in the processor class, use the new version of grok and removing

[GitHub] nifi issue #1108: NIFI-2565: add Grok parser

Github user selim-namsi commented on the issue: https://github.com/apache/nifi/pull/1108 @trixpan @markap14 I pushed the new changes. Could you please check the changes ? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi pull request #1108: NIFI-2565: add Grok parser

Github user selim-namsi commented on a diff in the pull request: https://github.com/apache/nifi/pull/1108#discussion_r83729426 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestGrokParser.java

[GitHub] nifi issue #1108: NIFI-2565: add Grok parser

Github user selim-namsi commented on the issue: https://github.com/apache/nifi/pull/1108 @markap14 Thanks for all this suggestions, I'll update the code ASAP and push the changes! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi pull request #1108: NIFI-2565: add Grok parser

Github user selim-namsi commented on a diff in the pull request: https://github.com/apache/nifi/pull/1108#discussion_r83720911 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GrokParser.java --- @@ -0,0

[GitHub] nifi pull request #1108: NIFI-2565: add Grok parser

Github user selim-namsi commented on a diff in the pull request: https://github.com/apache/nifi/pull/1108#discussion_r83720540 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GrokParser.java --- @@ -0,0

[GitHub] nifi issue #1108: NIFI-2565: add Grok parser

Github user selim-namsi commented on the issue: https://github.com/apache/nifi/pull/1108 @trixpan I figured out how to rebase the pull request :) Cheers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi pull request #1108: NIFI-2565: add Grok parser

Github user selim-namsi closed the pull request at: https://github.com/apache/nifi/pull/1108 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi issue #1108: NIFI-2565: add Grok parser

Github user selim-namsi commented on the issue: https://github.com/apache/nifi/pull/1108 @trixpan could you please tell me how to rebase a PR ? I rebased my [branch](https://github.com/selim-namsi/nifi/commits/nifi-2565) but I didn't find how to rebase the PR. sorry

[GitHub] nifi issue #1108: NIFI-2565: add Grok parser

Github user selim-namsi commented on the issue: https://github.com/apache/nifi/pull/1108 @trixpan Thank you for all this useful feedback, I'll start working on these modifications. For the patterns, I hard coded the patterns because I was thinking about adding by default some

[GitHub] nifi pull request #1108: NIFI-2565: add Grok parser

GitHub user selim-namsi opened a pull request: https://github.com/apache/nifi/pull/1108 NIFI-2565: add Grok parser Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have