[GitHub] nifi issue #1125: NIFI-2872 Create PutCloudwatchMetric Processor

2016-10-13 Thread vegaed
Github user vegaed commented on the issue: https://github.com/apache/nifi/pull/1125 So I guess it ready to be merged then? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #1125: NIFI-2872 Create PutCloudwatchMetric Processor

2016-10-13 Thread vegaed
Github user vegaed commented on the issue: https://github.com/apache/nifi/pull/1125 @jvwing You know why the appveyor build is failing. I didn't touch any of the S2S code. Is it something I should worry about? --- If your project is set up for it, you can reply to this email

[GitHub] nifi issue #1125: NIFI-2872 Create PutCloudwatchMetric Processor

2016-10-13 Thread vegaed
Github user vegaed commented on the issue: https://github.com/apache/nifi/pull/1125 @jvwing Thanks for all the great suggestions and code. I moved the try up in order to catch those types of parsing exceptions so now they will route to failure. Good catch

[GitHub] nifi pull request #1125: NIFI-2872 Create PutCloudwatchMetric Processor

2016-10-13 Thread vegaed
Github user vegaed commented on a diff in the pull request: https://github.com/apache/nifi/pull/1125#discussion_r83200380 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/cloudwatch/PutCloudWatchMetric.java --- @@ -0,0

[GitHub] nifi issue #1125: NIFI-2872 Create PutCloudwatchMetric Processor

2016-10-11 Thread vegaed
Github user vegaed commented on the issue: https://github.com/apache/nifi/pull/1125 @jvwing Thanks for the review. Just fixed those issues up. Only reason I didn't use the RELs from AbstractAWSProcessor is because it is a deprecated class, but if it standard practice. --- If your

[GitHub] nifi pull request #1125: NIFI-2872 Create PutCloudwatchMetric Processor

2016-10-11 Thread vegaed
GitHub user vegaed opened a pull request: https://github.com/apache/nifi/pull/1125 NIFI-2872 Create PutCloudwatchMetric Processor https://issues.apache.org/jira/browse/NIFI-2872 You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] nifi pull request #1034: [NIFI-2810] Allow Content Type to be set in PutS3Ob...

2016-09-23 Thread vegaed
Github user vegaed commented on a diff in the pull request: https://github.com/apache/nifi/pull/1034#discussion_r80255627 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/test/java/org/apache/nifi/processors/aws/s3/ITPutS3Object.java --- @@ -238,6 +238,26

[GitHub] nifi pull request #1034: [NIFI-2810] Allow Content Type to be set in PutS3Ob...

2016-09-23 Thread vegaed
Github user vegaed commented on a diff in the pull request: https://github.com/apache/nifi/pull/1034#discussion_r80254681 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java --- @@ -132,6 +132,19

[GitHub] nifi issue #1049: [NIFI-2813] Fix for invalid M2_HOME directory in Appveyor

2016-09-23 Thread vegaed
Github user vegaed commented on the issue: https://github.com/apache/nifi/pull/1049 @trixpan Followed those directions should be good now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1049: [NIFI-2813] Fix for invalid M2_HOME directory in Appveyor

2016-09-23 Thread vegaed
Github user vegaed commented on the issue: https://github.com/apache/nifi/pull/1049 @trixpan I think I did what you wanted. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #1034: [NIFI-2810] Allow Content Type to be set in PutS3Object pr...

2016-09-22 Thread vegaed
Github user vegaed commented on the issue: https://github.com/apache/nifi/pull/1034 @pvillard31 I think I did it right should be good to go now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi pull request #1049: Fix for invalid M2_HOME directory in Appveyor

2016-09-22 Thread vegaed
GitHub user vegaed opened a pull request: https://github.com/apache/nifi/pull/1049 Fix for invalid M2_HOME directory in Appveyor Appveyor was given the following error: **ERROR: M2_HOME is set to an invalid directory. M2_HOME = "C:\Program Files (x86)\Apache\

[GitHub] nifi pull request #1048: Appveyor maven home fix

2016-09-22 Thread vegaed
Github user vegaed closed the pull request at: https://github.com/apache/nifi/pull/1048 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request #1048: Appveyor maven home fix

2016-09-22 Thread vegaed
GitHub user vegaed opened a pull request: https://github.com/apache/nifi/pull/1048 Appveyor maven home fix Appveyor was given the following error: **ERROR: M2_HOME is set to an invalid directory. M2_HOME = "C:\Program Files (x86)\Apache\Maven"

[GitHub] nifi issue #1034: Allow Content Type to be set in PutS3Object processor

2016-09-22 Thread vegaed
Github user vegaed commented on the issue: https://github.com/apache/nifi/pull/1034 @trixpan moved it out of this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi pull request #1034: Allow Content Type to be set in PutS3Object process...

2016-09-20 Thread vegaed
GitHub user vegaed opened a pull request: https://github.com/apache/nifi/pull/1034 Allow Content Type to be set in PutS3Object processor You can merge this pull request into a Git repository by running: $ git pull https://github.com/vegaed/nifi master Alternatively you can