[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #816: MINIFICPP-1261 - Refactor non-trivial usages of ScopeGuard class

hunyadi-dev commented on a change in pull request #816: URL: https://github.com/apache/nifi-minifi-cpp/pull/816#discussion_r446841984 ## File path: libminifi/include/io/tls/TLSSocket.h ## @@ -80,10 +77,13 @@ class TLSContext : public SocketContext { int16_t initialize(bool

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #816: MINIFICPP-1261 - Refactor non-trivial usages of ScopeGuard class

hunyadi-dev commented on a change in pull request #816: URL: https://github.com/apache/nifi-minifi-cpp/pull/816#discussion_r446854170 ## File path: libminifi/src/io/tls/TLSSocket.cpp ## @@ -120,35 +115,35 @@ int16_t TLSContext::initialize(bool server_method) {

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #816: MINIFICPP-1261 - Refactor non-trivial usages of ScopeGuard class

hunyadi-dev commented on a change in pull request #816: URL: https://github.com/apache/nifi-minifi-cpp/pull/816#discussion_r446848748 ## File path: libminifi/include/utils/ScopeGuard.h ## @@ -33,10 +33,6 @@ namespace utils { struct ScopeGuard : ::gsl::final_action> {

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #816: MINIFICPP-1261 - Refactor non-trivial usages of ScopeGuard class

hunyadi-dev commented on a change in pull request #816: URL: https://github.com/apache/nifi-minifi-cpp/pull/816#discussion_r446848748 ## File path: libminifi/include/utils/ScopeGuard.h ## @@ -33,10 +33,6 @@ namespace utils { struct ScopeGuard : ::gsl::final_action> {

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #816: MINIFICPP-1261 - Refactor non-trivial usages of ScopeGuard class

hunyadi-dev commented on a change in pull request #816: URL: https://github.com/apache/nifi-minifi-cpp/pull/816#discussion_r446841976 ## File path: libminifi/src/io/tls/TLSSocket.cpp ## @@ -72,30 +72,25 @@ int16_t TLSContext::initialize(bool server_method) { } const

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #816: MINIFICPP-1261 - Refactor non-trivial usages of ScopeGuard class

hunyadi-dev commented on a change in pull request #816: URL: https://github.com/apache/nifi-minifi-cpp/pull/816#discussion_r446055811 ## File path: extensions/rocksdb-repos/FlowFileRepository.cpp ## @@ -122,27 +122,26 @@ void FlowFileRepository::run() { } void