[GitHub] nifi-minifi pull request #34: MINIFI-82 Adding support for Processor 'Annota...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi-minifi/pull/34


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi pull request #34: MINIFI-82 Adding support for Processor 'Annota...

[apiri]

Github user apiri commented on a diff in the pull request:

https://github.com/apache/nifi-minifi/pull/34#discussion_r80102080
  
--- Diff: 
minifi-toolkit/minifi-toolkit-configuration/src/test/java/org/apache/nifi/minifi/toolkit/configuration/dto/ProcessorSchemaTest.java
 ---
@@ -45,6 +45,35 @@
 private final String testKey = "testKey";
 private final String testValue = "testValue";
 private final String testPenalizationPeriod = "55 s";
+private final String testAnnotationData = ">criteria\n" +
--- End diff --

Most certainly, just wanted to make sure I wasn't overlooking.  Will merge 
it in.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi pull request #34: MINIFI-82 Adding support for Processor 'Annota...

[JPercivall]

Github user JPercivall commented on a diff in the pull request:

https://github.com/apache/nifi-minifi/pull/34#discussion_r80100987
  
--- Diff: 
minifi-toolkit/minifi-toolkit-configuration/src/test/java/org/apache/nifi/minifi/toolkit/configuration/dto/ProcessorSchemaTest.java
 ---
@@ -45,6 +45,35 @@
 private final String testKey = "testKey";
 private final String testValue = "testValue";
 private final String testPenalizationPeriod = "55 s";
+private final String testAnnotationData = ">criteria\n" +
--- End diff --

Ah good catch, it should be removed. I mis-copied it from a the xml of a 
template. Could you just amend the commit to remove that? 

Sorry, I'm in the middle of debugging something else


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi pull request #34: MINIFI-82 Adding support for Processor 'Annota...

[apiri]

Github user apiri commented on a diff in the pull request:

https://github.com/apache/nifi-minifi/pull/34#discussion_r80084132
  
--- Diff: 
minifi-toolkit/minifi-toolkit-configuration/src/test/java/org/apache/nifi/minifi/toolkit/configuration/dto/ProcessorSchemaTest.java
 ---
@@ -45,6 +45,35 @@
 private final String testKey = "testKey";
 private final String testValue = "testValue";
 private final String testPenalizationPeriod = "55 s";
+private final String testAnnotationData = ">criteria\n" +
--- End diff --

Very minor, but Is the beginning '>' a typo? I realize it's just test data, 
but seems like it would be invalid.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi pull request #34: MINIFI-82 Adding support for Processor 'Annota...

[JPercivall]

GitHub user JPercivall opened a pull request:

https://github.com/apache/nifi-minifi/pull/34

MINIFI-82 Adding support for Processor 'Annotation Data'



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/JPercivall/nifi-minifi MINIFI-82

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi/pull/34.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #34


commit 1bafa4fcbf5ef198880536f2563f45ca0e0b11d8
Author: Joseph Percivall 
Date:   2016-09-21T20:32:35Z

MINIFI-82 Adding support for Processor 'Annotation Data'




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---