Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/1125
I expect so :). The latest changes look good, thanks for those. I'm going
to do a bit more testing, and if everything goes well, I'll merge it this
evening.
---
If your project is set up for it,
Github user vegaed commented on the issue:
https://github.com/apache/nifi/pull/1125
So I guess it ready to be merged then?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/1125
@vegaed I don't think you should worry, I do not believe the Appveyor build
is stable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user vegaed commented on the issue:
https://github.com/apache/nifi/pull/1125
@jvwing You know why the appveyor build is failing. I didn't touch any of
the S2S code. Is it something I should worry about?
---
If your project is set up for it, you can reply to this email and
Github user vegaed commented on the issue:
https://github.com/apache/nifi/pull/1125
@jvwing Thanks for all the great suggestions and code.
I moved the try up in order to catch those types of parsing exceptions so
now they will route to failure.
Good catch on the
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/1125
@vegaed Thanks for the updated code. The situation with
AbstractAWSProcessor is a bit odd. It's deprecated in that you should not
derive directly from it, but it still has live code we're definitely
Github user vegaed commented on the issue:
https://github.com/apache/nifi/pull/1125
@jvwing Thanks for the review. Just fixed those issues up. Only reason I
didn't use the RELs from AbstractAWSProcessor is because it is a deprecated
class, but if it standard practice.
---
If your
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/1125
@vegaed thanks for putting this together. I have a few initial suggestions
from a quick scan:
* Please run `mvn clean install -Pcontrib-check` - there are a few issues
with .* imports,
