[GitHub] nifi issue #2016: NIFI-4196 - Expose AWS proxy authentication settings

2018-05-16 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/2016 @trixpan Similar to #2018, I took the liberty of taking over this PR into #2704. By cherry-picking your commits into my branch, so that we can respect your work and, when mine is merged, this PR

[GitHub] nifi issue #2016: NIFI-4196 - Expose AWS proxy authentication settings

2018-04-24 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2016 @trixpan can you de-conflict? ---

[GitHub] nifi issue #2016: NIFI-4196 - Expose AWS proxy authentication settings

2018-04-09 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2016 in https://github.com/apache/nifi/pull/2588 I have done this as well, but only in my processor ( scope ). I would like to see this land. What can be done to move this forward? ---

[GitHub] nifi issue #2016: NIFI-4196 - Expose AWS proxy authentication settings

2018-03-16 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2016 How can these be tested? ---

[GitHub] nifi issue #2016: NIFI-4196 - Expose AWS proxy authentication settings

2018-01-21 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/2016 @pvillard31 will rebase and resubmit... ---

[GitHub] nifi issue #2016: NIFI-4196 - Expose AWS proxy authentication settings

2017-07-19 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2016 Thanks @trixpan, what about my comment on ``displayName``? I know this is kind of cosmetic but when using proper ``name``, it makes things easier when moving templates from one environment to

[GitHub] nifi issue #2016: NIFI-4196 - Expose AWS proxy authentication settings

2017-07-18 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/2016 hopefully fixed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] nifi issue #2016: NIFI-4196 - Expose AWS proxy authentication settings

2017-07-18 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2016 Hey @trixpan, regarding ``.displayName`` and ``.name``, I tend to think that we should use both for new properties in a processor, even though it is not the case for legacy properties.

[GitHub] nifi issue #2016: NIFI-4196 - Expose AWS proxy authentication settings

2017-07-18 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/2016 Please note the displayName settings were not added as most of the AWS related processors lack these --- If your project is set up for it, you can reply to this email and have your reply appear on