[GitHub] [nifi] ChrisSamo632 commented on pull request #6687: NIFI-10844 allow _source only output for GetElasticsearch and JsonQueryElasticsearch processors

2022-12-22 Thread GitBox
ChrisSamo632 commented on PR #6687: URL: https://github.com/apache/nifi/pull/6687#issuecomment-1363395679 @exceptionfactory refactored to use `DescribedValue` enums for the new and other existing properties in these processors - led to me uncovering the fact that I'd mistakenly not added

[GitHub] [nifi] ChrisSamo632 commented on pull request #6687: NIFI-10844 allow _source only output for GetElasticsearch and JsonQueryElasticsearch processors

2022-12-19 Thread GitBox
ChrisSamo632 commented on PR #6687: URL: https://github.com/apache/nifi/pull/6687#issuecomment-1358286729 > Thanks for the contribution @ChrisSamo632, this looks like a useful improvement. > > One implementation note, rather defining instances of `AllowableValue`, what do you think