[GitHub] [nifi] bbende commented on pull request #4358: NIFI-7578 nifi-toolkit CLI Process Group Create command

2020-06-30 Thread GitBox 


bbende commented on pull request #4358:
URL: https://github.com/apache/nifi/pull/4358#issuecomment-651803038


   Looks good, merged to master, thanks!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] bbende commented on pull request #4358: NIFI-7578 nifi-toolkit CLI Process Group Create command

2020-06-30 Thread GitBox 


bbende commented on pull request #4358:
URL: https://github.com/apache/nifi/pull/4358#issuecomment-651772910


   Not sure if this is the reason, but try running "install" instead of 
"compile".
   
   Here was the output for me:
   ```
   [INFO] --- maven-checkstyle-plugin:3.1.0:check (check-style) @ 
nifi-toolkit-cli ---
   [WARNING] 
src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/pg/PGCreate.java:[19,8]
 (imports) UnusedImports: Unused import - org.apache.commons.lang3.StringUtils.
   [WARNING] 
src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/pg/PGCreate.java:[29,8]
 (imports) UnusedImports: Unused import - 
org.apache.nifi.toolkit.cli.impl.result.nifi.ProcessGroupsResult.
   [WARNING] 
src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/pg/PGCreate.java:[31,8]
 (imports) UnusedImports: Unused import - org.apache.nifi.web.api.dto.UserDTO.
   [WARNING] 
src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/pg/PGCreate.java:[32,8]
 (imports) UnusedImports: Unused import - 
org.apache.nifi.web.api.dto.flow.FlowDTO.
   [WARNING] 
src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/pg/PGCreate.java:[33,8]
 (imports) UnusedImports: Unused import - 
org.apache.nifi.web.api.dto.flow.ProcessGroupFlowDTO.
   [WARNING] 
src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/pg/PGCreate.java:[34,8]
 (imports) UnusedImports: Unused import - 
org.apache.nifi.web.api.entity.ControllerServiceEntity.
   [WARNING] 
src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/pg/PGCreate.java:[36,8]
 (imports) UnusedImports: Unused import - 
org.apache.nifi.web.api.entity.ProcessGroupFlowEntity.
   [WARNING] 
src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/pg/PGCreate.java:[37,8]
 (imports) UnusedImports: Unused import - 
org.apache.nifi.web.api.entity.UserEntity.
   [WARNING] 
src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/pg/PGCreate.java:[40,8]
 (imports) UnusedImports: Unused import - java.util.ArrayList.
   [WARNING] 
src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/pg/PGCreate.java:[41,8]
 (imports) UnusedImports: Unused import - java.util.List.
   [WARNING] 
src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/pg/PGCreate.java:[49,23]
 (blocks) LeftCurly: '{' at column 23 should have line break after.
   [WARNING] 
src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/pg/PGCreate.java:[52,36]
 (blocks) LeftCurly: '{' at column 36 should have line break after.
   [WARNING] 
src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/pg/PGCreate.java:[55,50]
 (blocks) LeftCurly: '{' at column 50 should have line break after.
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] bbende commented on pull request #4358: NIFI-7578 nifi-toolkit CLI Process Group Create command

2020-06-29 Thread GitBox 


bbende commented on pull request #4358:
URL: https://github.com/apache/nifi/pull/4358#issuecomment-651336958


   Running a build inside `nifi-toolkit` with `-Pcontrib-check` shows some 
checkstyle errors that would need to be resolved. For some reason there is an 
issue where builds through Github Actions are not catching these so it shows 
everything as passing, we are looking into that.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org