[GitHub] [nifi] mattyb149 commented on pull request #4350: NIFI-6934 In PutDatabaseRecord added Postgres UPSERT support

2020-07-08 Thread GitBox
mattyb149 commented on pull request #4350: URL: https://github.com/apache/nifi/pull/4350#issuecomment-655679853 +1 LGTM, ran contrib-check and tested a few scenarios. @simonbence @turcsanyip Are your reviews complete? If so I can merge to main. Thanks for this improvement! It will also

[GitHub] [nifi] mattyb149 commented on pull request #4350: NIFI-6934 In PutDatabaseRecord added Postgres UPSERT support

2020-07-07 Thread GitBox
mattyb149 commented on pull request #4350: URL: https://github.com/apache/nifi/pull/4350#issuecomment-654910951 Can you please change the base branch of this PR to `main` and rebase against the latest `main` branch? That's the one we'll be using from now on. Thanks in advance!

[GitHub] [nifi] mattyb149 commented on pull request #4350: NIFI-6934 In PutDatabaseRecord added Postgres UPSERT support

2020-06-22 Thread GitBox
mattyb149 commented on pull request #4350: URL: https://github.com/apache/nifi/pull/4350#issuecomment-647661277 Looking and working good, just some comments on extending the documentation to make things as clear as possible, should be good to go after that