[GitHub] [nifi] sjyang18 commented on pull request #4630: NIFI-7924: add fallback claims for identifying user

2021-01-06 Thread GitBox
sjyang18 commented on pull request #4630: URL: https://github.com/apache/nifi/pull/4630#issuecomment-755729231 There are existing test cases that we need to update if we modify the semantics of existing property, and I choose not to modify existing semantics and logics.

[GitHub] [nifi] sjyang18 commented on pull request #4630: NIFI-7924: add fallback claims for identifying user

2021-01-05 Thread GitBox
sjyang18 commented on pull request #4630: URL: https://github.com/apache/nifi/pull/4630#issuecomment-754930724 > @sjyang18 Thank you for submitting this. I've reviewed it and the functionality LGTM. I verified I can log in with OIDC enabled and verified the tests will use the listed

[GitHub] [nifi] sjyang18 commented on pull request #4630: NIFI-7924: add fallback claims for identifying user

2021-01-05 Thread GitBox
sjyang18 commented on pull request #4630: URL: https://github.com/apache/nifi/pull/4630#issuecomment-754932330 @mtien-apache I have added the fallback property explanation to admin doc. Will this work? This is an