[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #918: MINIFICPP-1383 fix intdiv_ceil

2020-10-07 Thread GitBox
adamdebreceni commented on a change in pull request #918: URL: https://github.com/apache/nifi-minifi-cpp/pull/918#discussion_r501035283 ## File path: libminifi/test/unit/GeneralUtilsTest.cpp ## @@ -32,18 +32,20 @@ TEST_CASE("GeneralUtils::make_unique", "[make_unique]") {

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #918: MINIFICPP-1383 fix intdiv_ceil

2020-10-02 Thread GitBox
adamdebreceni commented on a change in pull request #918: URL: https://github.com/apache/nifi-minifi-cpp/pull/918#discussion_r498765811 ## File path: libminifi/test/unit/GeneralUtilsTest.cpp ## @@ -32,18 +32,20 @@ TEST_CASE("GeneralUtils::make_unique", "[make_unique]") {

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #918: MINIFICPP-1383 fix intdiv_ceil

2020-10-02 Thread GitBox
adamdebreceni commented on a change in pull request #918: URL: https://github.com/apache/nifi-minifi-cpp/pull/918#discussion_r498765811 ## File path: libminifi/test/unit/GeneralUtilsTest.cpp ## @@ -32,18 +32,20 @@ TEST_CASE("GeneralUtils::make_unique", "[make_unique]") {

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #918: MINIFICPP-1383 fix intdiv_ceil

2020-10-02 Thread GitBox
adamdebreceni commented on a change in pull request #918: URL: https://github.com/apache/nifi-minifi-cpp/pull/918#discussion_r498765811 ## File path: libminifi/test/unit/GeneralUtilsTest.cpp ## @@ -32,18 +32,20 @@ TEST_CASE("GeneralUtils::make_unique", "[make_unique]") {

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #918: MINIFICPP-1383 fix intdiv_ceil

2020-10-02 Thread GitBox
adamdebreceni commented on a change in pull request #918: URL: https://github.com/apache/nifi-minifi-cpp/pull/918#discussion_r498763931 ## File path: libminifi/test/unit/GeneralUtilsTest.cpp ## @@ -32,18 +32,20 @@ TEST_CASE("GeneralUtils::make_unique", "[make_unique]") {