arpadboda commented on a change in pull request #795:
URL: https://github.com/apache/nifi-minifi-cpp/pull/795#discussion_r430358167
##########
File path: extensions/standard-processors/processors/GetFile.cpp
##########
@@ -56,7 +56,7 @@ core::Property GetFile::BatchSize(
core::PropertyBuilder::createProperty("Batch Size")->withDescription("The
maximum number of files to pull in each
iteration")->withDefaultValue<uint32_t>(10)->build());
core::Property GetFile::Directory(
- core::PropertyBuilder::createProperty("Input
Directory")->withDescription("The input directory from which to pull
files")->isRequired(true)->supportsExpressionLanguage(true)->withDefaultValue(".")
+ core::PropertyBuilder::createProperty("Input
Directory")->withDescription("The input directory from which to pull
files")->isRequired(true)->supportsExpressionLanguage(true)
Review comment:
Could you add a testcase to that covers this? (The processor doesn't
start without setting the input dir)
##########
File path: extensions/standard-processors/processors/GetFile.cpp
##########
@@ -56,7 +56,7 @@ core::Property GetFile::BatchSize(
core::PropertyBuilder::createProperty("Batch Size")->withDescription("The
maximum number of files to pull in each
iteration")->withDefaultValue<uint32_t>(10)->build());
core::Property GetFile::Directory(
- core::PropertyBuilder::createProperty("Input
Directory")->withDescription("The input directory from which to pull
files")->isRequired(true)->supportsExpressionLanguage(true)->withDefaultValue(".")
+ core::PropertyBuilder::createProperty("Input
Directory")->withDescription("The input directory from which to pull
files")->isRequired(true)->supportsExpressionLanguage(true)
Review comment:
Could you add a testcase that covers this? (The processor doesn't start
without setting the input dir)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
