[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #870: MINIFICPP-1321 Support attribute strategies in MergeContent processor

2020-08-14 Thread GitBox
lordgamez commented on a change in pull request #870: URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r470530621 ## File path: extensions/libarchive/MergeContent.cpp ## @@ -342,6 +352,50 @@ std::shared_ptr ZipMerge::merge(core::ProcessContext *context, c

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #870: MINIFICPP-1321 Support attribute strategies in MergeContent processor

2020-08-14 Thread GitBox
lordgamez commented on a change in pull request #870: URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r470465347 ## File path: extensions/libarchive/MergeContent.cpp ## @@ -342,6 +352,50 @@ std::shared_ptr ZipMerge::merge(core::ProcessContext *context, c

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #870: MINIFICPP-1321 Support attribute strategies in MergeContent processor

2020-08-13 Thread GitBox
lordgamez commented on a change in pull request #870: URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r470070629 ## File path: extensions/libarchive/MergeContent.h ## @@ -259,20 +259,56 @@ class ZipMerge: public ArchiveMerge, public MergeBin { } };

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #870: MINIFICPP-1321 Support attribute strategies in MergeContent processor

2020-08-13 Thread GitBox
lordgamez commented on a change in pull request #870: URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r469899411 ## File path: extensions/libarchive/MergeContent.h ## @@ -259,20 +259,56 @@ class ZipMerge: public ArchiveMerge, public MergeBin { } };