[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1538: MINIFICPP-2073 Separate docker build from docker tests in CI

2023-04-13 Thread via GitHub
lordgamez commented on code in PR #1538: URL: https://github.com/apache/nifi-minifi-cpp/pull/1538#discussion_r1165506164 ## .github/workflows/ci.yml: ## Review Comment: @martinzink all right, I'm okay with that @szaszm unfortunately that will not work due to the

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1538: MINIFICPP-2073 Separate docker build from docker tests in CI

2023-04-13 Thread via GitHub
lordgamez commented on code in PR #1538: URL: https://github.com/apache/nifi-minifi-cpp/pull/1538#discussion_r1165231758 ## .github/workflows/ci.yml: ## Review Comment: I think it's good to separate the test jobs and the build jobs and it would be cool to have that for

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1538: MINIFICPP-2073 Separate docker build from docker tests in CI

2023-04-13 Thread via GitHub
lordgamez commented on code in PR #1538: URL: https://github.com/apache/nifi-minifi-cpp/pull/1538#discussion_r1165217460 ## .github/workflows/ci.yml: ## Review Comment: There is already a ticket for running tests in parallel, but as Martin mentioned it requires larger