lordgamez commented on code in PR #1616:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1616#discussion_r1301235162
##
extensions/libarchive/BinFiles.cpp:
##
@@ -203,93 +208,97 @@ bool BinManager::offer(const std::string , const
std::shared_ptr ,
const std::shared_ptr )
lordgamez commented on code in PR #1616:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1616#discussion_r1282896155
##
extensions/libarchive/BinFiles.h:
##
@@ -284,19 +285,24 @@ class BinFiles : public core::Processor {
protected:
// Allows general pre-processing of
lordgamez commented on code in PR #1616:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1616#discussion_r1280416004
##
extensions/libarchive/BinFiles.h:
##
@@ -284,19 +285,24 @@ class BinFiles : public core::Processor {
protected:
// Allows general pre-processing of
lordgamez commented on code in PR #1616:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1616#discussion_r1275933970
##
libminifi/src/core/ProcessSession.cpp:
##
@@ -1147,4 +1147,8 @@ bool ProcessSession::existsFlowFileInRelationship(const
Relationship
});
}
+bool
lordgamez commented on code in PR #1616:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1616#discussion_r1275836056
##
libminifi/src/io/StreamSlice.cpp:
##
@@ -23,7 +23,8 @@ namespace org::apache::nifi::minifi::io {
StreamSlice::StreamSlice(std::shared_ptr stream, size_t
