[GitHub] arpadboda commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication

2019-01-31 Thread GitBox
arpadboda commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication URL: https://github.com/apache/nifi-minifi-cpp/pull/470#discussion_r252667506 ## File path: libminifi/src/sitetosite/RawSocketProtocol.cpp ## @@ -395,97 +395,37 @@

[GitHub] arpadboda commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication

2019-01-31 Thread GitBox
arpadboda commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication URL: https://github.com/apache/nifi-minifi-cpp/pull/470#discussion_r252667506 ## File path: libminifi/src/sitetosite/RawSocketProtocol.cpp ## @@ -395,97 +395,37 @@

[GitHub] arpadboda commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication

2019-01-23 Thread GitBox
arpadboda commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication URL: https://github.com/apache/nifi-minifi-cpp/pull/470#discussion_r249948870 ## File path: libminifi/src/sitetosite/RawSocketProtocol.cpp ## @@ -395,97 +395,37 @@

[GitHub] arpadboda commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication

2019-01-18 Thread GitBox
arpadboda commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication URL: https://github.com/apache/nifi-minifi-cpp/pull/470#discussion_r249233347 ## File path: libminifi/include/sitetosite/SiteToSiteClient.h ## @@ -221,12 +221,8 @@

[GitHub] arpadboda commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication

2019-01-18 Thread GitBox
arpadboda commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication URL: https://github.com/apache/nifi-minifi-cpp/pull/470#discussion_r249233347 ## File path: libminifi/include/sitetosite/SiteToSiteClient.h ## @@ -221,12 +221,8 @@

[GitHub] arpadboda commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication

2019-01-18 Thread GitBox
arpadboda commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication URL: https://github.com/apache/nifi-minifi-cpp/pull/470#discussion_r249233347 ## File path: libminifi/include/sitetosite/SiteToSiteClient.h ## @@ -221,12 +221,8 @@

[GitHub] arpadboda commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication

2019-01-11 Thread GitBox
arpadboda commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication URL: https://github.com/apache/nifi-minifi-cpp/pull/470#discussion_r247095016 ## File path: libminifi/src/sitetosite/RawSocketProtocol.cpp ## @@ -394,98 +394,12 @@

[GitHub] arpadboda commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication

2019-01-11 Thread GitBox
arpadboda commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication URL: https://github.com/apache/nifi-minifi-cpp/pull/470#discussion_r247094612 ## File path: libminifi/include/sitetosite/RawSocketProtocol.h ## @@ -143,21 +140,21

[GitHub] arpadboda commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication

2019-01-11 Thread GitBox
arpadboda commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication URL: https://github.com/apache/nifi-minifi-cpp/pull/470#discussion_r247094612 ## File path: libminifi/include/sitetosite/RawSocketProtocol.h ## @@ -143,21 +140,21