[GitHub] nifi-minifi-cpp issue #247: MINIFICPP-378: Detach new threads if daemon thre...

2018-01-23 Thread apiri
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/247 Rebased on master and verified build/tests. Looks good and will merge. ---

[GitHub] nifi-minifi-cpp issue #247: MINIFICPP-378: Detach new threads if daemon thre...

2018-01-23 Thread apiri
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/247 @achristianson that was fixed with #248 ---

[GitHub] nifi-minifi-cpp issue #247: MINIFICPP-378: Detach new threads if daemon thre...

2018-01-23 Thread achristianson
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/247 Looks like a Travis failure? Not sure if related. ---

[GitHub] nifi-minifi-cpp issue #247: MINIFICPP-378: Detach new threads if daemon thre...

2018-01-23 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/247 performing additional testing verification... ---

[GitHub] nifi-minifi-cpp issue #247: MINIFICPP-378: Detach new threads if daemon thre...

2018-01-23 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/247 Currently testing something with this PR. will remove comment when ready to merge. ---