[GitHub] nifi-minifi-cpp issue #304: Providing fixes for sourcing RHEL based distribu...

2018-04-20 Thread apiri
Github user apiri commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/304
  
Updated the script to determine the directory in which it resides and then 
uses that to generate a full path for each environment file sourced.  
Verification on OS X looks like behavior remains constant and this additionally 
resolves the issues that were present in CentOS & Fedora.


---


[GitHub] nifi-minifi-cpp issue #304: Providing fixes for sourcing RHEL based distribu...

2018-04-20 Thread phrocker
Github user phrocker commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/304
  
@apiri looks good. will merge. 


---


[GitHub] nifi-minifi-cpp issue #304: Providing fixes for sourcing RHEL based distribu...

2018-04-20 Thread phrocker
Github user phrocker commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/304
  
These changes look good at face value. I'm going to try it across a few 
platforms and await travis completion before merging. Thanks!


---


[GitHub] nifi-minifi-cpp issue #304: Providing fixes for sourcing RHEL based distribu...

2018-04-20 Thread phrocker
Github user phrocker commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/304
  
@apiri what was the problem you were experiencing and on what distro 
specifically? I don't see an issue on the clean rhel distros I have running 
now, 


---