Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/236
---
Github user minifirocks commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/236#discussion_r161296430
--- Diff: libminifi/src/core/logging/LoggerConfiguration.cpp ---
@@ -110,6 +112,17 @@ std::shared_ptr
LoggerConfiguration::initialize_names
Github user minifirocks commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/236#discussion_r161295854
--- Diff: libminifi/src/core/logging/LoggerConfiguration.cpp ---
@@ -110,6 +112,17 @@ std::shared_ptr
LoggerConfiguration::initialize_names
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/236#discussion_r161024930
--- Diff: libminifi/src/core/logging/LoggerConfiguration.cpp ---
@@ -110,6 +112,17 @@ std::shared_ptr
LoggerConfiguration::initialize_names
GitHub user minifirocks opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/236
MINIFICPP-337: make default log directory as logs
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we
