[GitHub] nifi-minifi-cpp pull request #41: MINIFI-184: Add Security Support

Github user asfgit closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/41 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] nifi-minifi-cpp pull request #41: MINIFI-184: Add Security Support

Github user benqiu2016 commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/41#discussion_r99884121 --- Diff: libminifi/include/FlowController.h --- @@ -90,6 +93,25 @@ class FlowController } return _flowController;

[GitHub] nifi-minifi-cpp pull request #41: MINIFI-184: Add Security Support

Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/41#discussion_r99357721 --- Diff: libminifi/src/FlowController.cpp --- @@ -75,22 +78,123 @@ FlowController::FlowController(std::string name) } }

[GitHub] nifi-minifi-cpp pull request #41: MINIFI-184: Add Security Support

Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/41#discussion_r99357571 --- Diff: libminifi/include/FlowController.h --- @@ -90,6 +93,25 @@ class FlowController } return _flowController;

[GitHub] nifi-minifi-cpp pull request #41: MINIFI-184: Add Security Support

Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/41#discussion_r99357485 --- Diff: cmake/FindOpenSSL.cmake --- @@ -0,0 +1,28 @@ +# OPENSSL_ROOT_DIR - Set this variable to the root installation of OpenSSL +# +#

[GitHub] nifi-minifi-cpp pull request #41: MINIFI-184: Add Security Support

Github user benqiu2016 commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/41#discussion_r99379332 --- Diff: cmake/FindOpenSSL.cmake --- @@ -0,0 +1,28 @@ +# OPENSSL_ROOT_DIR - Set this variable to the root installation of OpenSSL --- End

[GitHub] nifi-minifi-cpp pull request #41: MINIFI-184: Add Security Support

Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/41#discussion_r98259383 --- Diff: libminifi/src/Configure.cpp --- @@ -29,6 +29,12 @@ const char *Configure::nifi_server_report_interval= "nifi.server.report.interval

[GitHub] nifi-minifi-cpp pull request #41: MINIFI-184: Add Security Support

Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/41#discussion_r98260259 --- Diff: README.md --- @@ -243,6 +245,26 @@ Additionally, users can utilize the MiNiFi Toolkit Converter (version 0.0.1 - sc

[GitHub] nifi-minifi-cpp pull request #41: MINIFI-184: Add Security Support

Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/41#discussion_r98259083 --- Diff: cmake/FindOpenSSL.cmake --- @@ -0,0 +1,28 @@ +# OPENSSL_ROOT_DIR - Set this variable to the root installation of OpenSSL --- End diff

[GitHub] nifi-minifi-cpp pull request #41: MINIFI-184: Add Security Support

Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/41#discussion_r98476688 --- Diff: libminifi/src/Site2SitePeer.cpp --- @@ -237,12 +271,31 @@ int Site2SitePeer::readData(uint8_t *buf, int buflen, CRC32 *crc)

[GitHub] nifi-minifi-cpp pull request #41: MINIFI-184: Add Security Support

Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/41#discussion_r98260232 --- Diff: libminifi/src/Configure.cpp --- @@ -29,6 +29,12 @@ const char *Configure::nifi_server_report_interval= "nifi.server.report.interval

[GitHub] nifi-minifi-cpp pull request #41: MINIFI-184: Add Security Support

Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/41#discussion_r98517708 --- Diff: README.md --- @@ -243,6 +245,26 @@ Additionally, users can utilize the MiNiFi Toolkit Converter (version 0.0.1 - sc

[GitHub] nifi-minifi-cpp pull request #41: MINIFI-184: Add Security Support

Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/41#discussion_r98259141 --- Diff: libminifi/src/Configure.cpp --- @@ -29,6 +29,12 @@ const char *Configure::nifi_server_report_interval= "nifi.server.report.interval

[GitHub] nifi-minifi-cpp pull request #41: MINIFI-184: Add Security Support

Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/41#discussion_r98476667 --- Diff: libminifi/src/Site2SitePeer.cpp --- @@ -237,12 +271,31 @@ int Site2SitePeer::readData(uint8_t *buf, int buflen, CRC32 *crc)

[GitHub] nifi-minifi-cpp pull request #41: MINIFI-184: Add Security Support

GitHub user benqiu2016 opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/41 MINIFI-184: Add Security Support You can merge this pull request into a Git repository by running: $ git pull https://github.com/benqiu2016/nifi-minifi-cpp master Alternatively