Github user kevdoran commented on the issue:
https://github.com/apache/nifi-registry/pull/112
Nice work @ijokarumawak and everyone who contributed to this. This is a
major feature to have as part of NiFi Registry and will certainly be useful.
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/112
@ijokarumawak thanks for the updates, everything looks good, going to
merge... thanks for all the work on this!
---
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi-registry/pull/112
@bbende I've addressed the final two items, updating migration guide and
added white space to invalid filename characters. Also, updated how NiFi
Registry username is used in Git
Github user alopresto commented on the issue:
https://github.com/apache/nifi-registry/pull/112
I vote for dropping spaces from the filename. Yes, it's technically valid,
but it's escaped differently on different OSes and will just cause problems.
There is no harm in removing it.
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/112
Async pushing looks good, so I think final two items are updating the
migration guidance and whether or not we want to leave spaces in the
bucket/flow names.
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/112
@ijokarumawak I agree about the email and author approach, after reading
what you wrote in the admin guide, it makes sense.
Thanks for pushing those changes. Will try them out shortly.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi-registry/pull/112
@bbende I've moved push to different thread. Now it only commits locally on
the web request handling thread. Used blocking queue to push fast enough but
keep the thread waiting until new
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/112
I noticed when I ran "git log" that the commit was made by "anonymous"
which is correct since I was in an unsecure instance, but the email address of
the commit ended up using the email from
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/112
Been testing this and has been looking good so far...
I was doing a test where I configured to push to a remote, but I didn't
supply a username/password because I honestly wasn't sure
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/112
Thanks @ijokarumawak ! Will review this soon.
---
10 matches
Mail list logo
