Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1107
@mathiastiberghien this is great work - sorry it took so long to get this
reviewed. All looks good, though. I have merged to master and will close the
JIRA as fixed. Thanks for the contribution!
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1107
@mathiastiberghien my apologies. I didn't see where @pvillard31 had
mentioned me. I'll review now & if all is good will merge to master this
afternoon. Thanks!
---
If your project is set up for
Github user mathiastiberghien commented on the issue:
https://github.com/apache/nifi/pull/1107
Hi,
I finally could build running all tests on my computer. I understood the
licence header system and also that my repository shouldn't contain space
otherwhise a lot o tests are
Github user mathiastiberghien commented on the issue:
https://github.com/apache/nifi/pull/1107
Sorry for the 2 commits but I realise that lowercasing the methods in
annotations changes a lot of files. I should have check before to commit but
I'm really used to Visual Studio renaming
Github user mathiastiberghien commented on the issue:
https://github.com/apache/nifi/pull/1107
I'll correct styles (I'm really newbie to java and open source).
I add issues to launch the styles tests so I hope I won't miss anything.
Sorry for the undesired change. I had to put
Github user mathiastiberghien commented on the issue:
https://github.com/apache/nifi/pull/1107
I've been able to find the problem with Dummy processors (the class were
declared in the test file which created an InstanciationException).
So I commited the code with style
Github user mathiastiberghien commented on the issue:
https://github.com/apache/nifi/pull/1107
Hello,
Thanks for the comments.
I have a question about unit test: I need to test the method
createProcessor of the FlowController so I guess I need to update the
