Github user b-long commented on the issue:
https://github.com/apache/nifi/pull/1156
@olegz @bbende , et al. Any insight on this ->
https://stackoverflow.com/questions/42938158/nifi-springcontextprocessor-using-configuration-instead-of-xml#comment84380723_42946116
?
---
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/1156
@bbende I now tend to agree. Per-lifecycle class loading is an edge case
and we only use it right now in SpringContextProcessor where it is required due
to the fact that Spring itself is a developer
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/1156
@olegz cool thanks! regarding the per-instance vs. per-lifecycle, in this
first pass we are basically loading the resources at the time the properties
are applied in order to be available during
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/1156
@bbende I am actually in the process of testing it now, but giving that
this is class loading, give till tomorrow and if all is good I'll merge. You
can squash now, I am good with the changes you've
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/1156
@olegz just pushed up a commit with some changes from the last round of
feedback (renaming jarFile, fixing empty catch block, fixing empty
IllegalArgumentException).
Have you had a chance to
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/1156
@bbende just left a few minor comments which probably all fall in the
category of stylistic, so it's up to you to decide if you want to change
anything.
Now I need to spend some time and play with
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/1156
@bbende thanks, will start looking
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/1156
@olegz I pushed up a second commit that with the change that I described
above, and also some of the changes from your feedback. Unfortunately I had
already rebased my branch before you had started
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/1156
@olegz thanks for reviewing, I posted a couple of replies to the inline
comments.
I also wanted to mention that after submitting this PR, I realized that a
slight modification to the approach
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/1156
@bbende While i am still reviewing and testing, I think it is worth
clarifying what per-instance really means. What I am trying to say is the fact
that property values can be changed multiple times per
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/1156
Reviewing. . .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
11 matches
Mail list logo
