[GitHub] nifi issue #1269: NIFI-3056 Updated User Guide screenshot and text with late...

2016-12-01 Thread thesolson
Github user thesolson commented on the issue:

https://github.com/apache/nifi/pull/1269
  
Hi Drew! These updates look great to me. Thanks for doing that. Please go 
ahead and merge as appropriate.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #1269: NIFI-3056 Updated User Guide screenshot and text with late...

2016-12-01 Thread andrewmlim
Github user andrewmlim commented on the issue:

https://github.com/apache/nifi/pull/1269
  
Incorporated some of my comments above and also added some additional 
screenshots to make PR complete.


[0001-NIFI-3056-Incorporated-feedback-and-added-additional.txt](https://github.com/apache/nifi/files/625776/0001-NIFI-3056-Incorporated-feedback-and-added-additional.txt)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #1269: NIFI-3056 Updated User Guide screenshot and text with late...

2016-12-01 Thread andrewmlim
Github user andrewmlim commented on the issue:

https://github.com/apache/nifi/pull/1269
  
nifi-toolbar-components.png also should not be replaced.  It is used to 
show a blank canvas, so with no processors, there is no need to update any 
colors. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #1269: NIFI-3056 Updated User Guide screenshot and text with late...

2016-11-23 Thread andrewmlim
Github user andrewmlim commented on the issue:

https://github.com/apache/nifi/pull/1269
  
I think these are great updates for the User Guide, but I don't this PR 
fully covers the intent of NIFI-3056.  There are Operate Palette and context 
menu buttons that still require creation/replacement in the doc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #1269: NIFI-3056 Updated User Guide screenshot and text with late...

2016-11-23 Thread andrewmlim
Github user andrewmlim commented on the issue:

https://github.com/apache/nifi/pull/1269
  
processor-connection-bubble.png also doesn't need an update


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #1269: NIFI-3056 Updated User Guide screenshot and text with late...

2016-11-23 Thread andrewmlim
Github user andrewmlim commented on the issue:

https://github.com/apache/nifi/pull/1269
  
I don't think we need to replace nifi-connection-bend-points.png.  It has 
been updated already for the color changes.  The 
nifi-connection-bend-points.png included with this PR also references 
"endpoints" instead of "bend points".

Also, I don't think nifi-connection.png needs to be replaced either.

These connection images were updated in 
https://github.com/apache/nifi/pull/1234 for NIFI-2985 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---