[GitHub] nifi issue #1382: NIFI-2860 Use different properties for JVM Heap Max and Mi...

2017-02-15 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1382 Thanks, I updated the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wish

[GitHub] nifi issue #1382: NIFI-2860 Use different properties for JVM Heap Max and Mi...

2017-02-15 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/1382 @pvillard31 @mattyb149 is right...if there are no uses in 1.x (and there should not be) then it can be removed in this PR too. Thanks --- If your project is set up for it, you can reply to this emai

[GitHub] nifi issue #1382: NIFI-2860 Use different properties for JVM Heap Max and Mi...

2017-02-15 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1382 @pvillard31 It might be in the 0.x branch but I wouldn't expect it in master since that's on Java 8 --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] nifi issue #1382: NIFI-2860 Use different properties for JVM Heap Max and Mi...

2017-02-15 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1382 @markap14, I agree. One question though: I was going to update ``nifi.jvm.permgen.mb`` as well but I didn't find any occurrence of this property. Should it be removed or did I miss it? --- If you

[GitHub] nifi issue #1382: NIFI-2860 Use different properties for JVM Heap Max and Mi...

2017-02-15 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1382 @pvillard31 I have no issues with the idea you're proposing here. I would suggest, though, that we should use properties like 512m instead of 512. There's no need to enforce that the units be in MB

[GitHub] nifi issue #1382: NIFI-2860 Use different properties for JVM Heap Max and Mi...

2017-02-14 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/1382 will review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the