[GitHub] nifi issue #1983: NiFi-2829: Add Date and Time Format Support for PutSQL

2017-07-17 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1983 As this PR is based on #1524 which was submitted by @patricker , I cherry-picked #1524 first, then cherry-picked this PR to give @patricker a credit. Thanks again! --- If your project is set

[GitHub] nifi issue #1983: NiFi-2829: Add Date and Time Format Support for PutSQL

2017-07-17 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1983 I've made a slight change to the documentation to state MySQL and Derby are some database engines that do not support milliseconds, but those may not be the only two. I am fine with not having

[GitHub] nifi issue #1983: NiFi-2829: Add Date and Time Format Support for PutSQL

2017-07-15 Thread yjhyjhyjh0
Github user yjhyjhyjh0 commented on the issue: https://github.com/apache/nifi/pull/1983 Thanks for the review and feedback. I’ve add your enhancement of handing time precision at milliseconds in PutSQL. Also I'm very willing to add a unit test for it. However after

[GitHub] nifi issue #1983: NiFi-2829: Add Date and Time Format Support for PutSQL

2017-07-12 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1983 @yjhyjhyjh0 Thanks for the updates! For AppVeyor test, it has been failing and Travis test failure is caused by nifi-persistent-provenance-repository, which has also been failing

[GitHub] nifi issue #1983: NiFi-2829: Add Date and Time Format Support for PutSQL

2017-07-12 Thread yjhyjhyjh0
Github user yjhyjhyjh0 commented on the issue: https://github.com/apache/nifi/pull/1983 Thanks for the reply and detail review. Just update the commit title, document part and remove unnecessary if condition. Seems AppVevor fail at same part. Travis CI only fail at

[GitHub] nifi issue #1983: NiFi-2829: Add Date and Time Format Support for PutSQL

2017-07-06 Thread yjhyjhyjh0
Github user yjhyjhyjh0 commented on the issue: https://github.com/apache/nifi/pull/1983 Well, lesson learned. Last build fail with Travis-CI is trailing whitespace problem. Just fix that and retry the PR. --- If your project is set up for it, you can reply to this email and