[GitHub] nifi issue #2065: NIFI-4255 - added flag to allow migration of existing (sou...

2017-08-23 Thread YolandaMDavis
Github user YolandaMDavis commented on the issue: https://github.com/apache/nifi/pull/2065 thank you @jtstorck ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishe

[GitHub] nifi issue #2065: NIFI-4255 - added flag to allow migration of existing (sou...

2017-08-23 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2065 +1 LGTM Made a few minor formatting changes, and moved the spock spec from src/test/java to src/test/groovy. To test this, I ran a KDC and ZK server in a docker container with two p

[GitHub] nifi issue #2065: NIFI-4255 - added flag to allow migration of existing (sou...

2017-08-22 Thread YolandaMDavis
Github user YolandaMDavis commented on the issue: https://github.com/apache/nifi/pull/2065 spoke with @jtstorck offline and we discussed refactoring a bit to ensure that the logic for determining acls are externalized and staged within the CompletableFuture chain. Committing those ch

[GitHub] nifi issue #2065: NIFI-4255 - added flag to allow migration of existing (sou...

2017-08-09 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2065 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th