[GitHub] nifi issue #2066: NIFI-4256 - Add support for all AWS S3 Encryption Options

2017-10-06 Thread baank
Github user baank commented on the issue: https://github.com/apache/nifi/pull/2066 Sure not a problem. I have already implemented his changes but just need to get a new PR approved and also there was a comment in JIRA regarding whether to include the client side S3 work at all. ---

[GitHub] nifi issue #2066: NIFI-4256 - Add support for all AWS S3 Encryption Options

2017-10-06 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2066 @baank will you be in a position to help work with @jvwing on review/contrib cycles? ---

[GitHub] nifi issue #2066: NIFI-4256 - Add support for all AWS S3 Encryption Options

2017-08-09 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/2066 @baank Thanks for putting together this PR, it looks like you put a lot of thought into covering all the possible encryption scenarios. I haven't run it yet, but I have a few starter questions after l

[GitHub] nifi issue #2066: NIFI-4256 - Add support for all AWS S3 Encryption Options

2017-08-09 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/2066 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the