[GitHub] nifi issue #2194: NIFI-4465 ConvertExcelToCSV Data Formatting and Delimiters

2017-10-17 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/2194 @patricker All LGTM, +1. Merged to master, thank you! ---

[GitHub] nifi issue #2194: NIFI-4465 ConvertExcelToCSV Data Formatting and Delimiters

2017-10-16 Thread patricker
Github user patricker commented on the issue: https://github.com/apache/nifi/pull/2194 @ijokarumawak Updated and squashed. ---

[GitHub] nifi issue #2194: NIFI-4465 ConvertExcelToCSV Data Formatting and Delimiters

2017-10-16 Thread patricker
Github user patricker commented on the issue: https://github.com/apache/nifi/pull/2194 @ijokarumawak I've made the updates we talked about and it's building and running now. ---

[GitHub] nifi issue #2194: NIFI-4465 ConvertExcelToCSV Data Formatting and Delimiters

2017-10-12 Thread patricker
Github user patricker commented on the issue: https://github.com/apache/nifi/pull/2194 @ijokarumawak Your code for doing the record reader was very creative. but I don't think I'm interested in using that approach, it makes me feel kind of dirty... ``` try {

[GitHub] nifi issue #2194: NIFI-4465 ConvertExcelToCSV Data Formatting and Delimiters

2017-10-10 Thread patricker
Github user patricker commented on the issue: https://github.com/apache/nifi/pull/2194 @ijokarumawak I made several changes, though not really what you asked for... I replied separately on data formatting. As for EL, see my comments below. I wanted to move towards generating

[GitHub] nifi issue #2194: NIFI-4465 ConvertExcelToCSV Data Formatting and Delimiters

2017-10-05 Thread patricker
Github user patricker commented on the issue: https://github.com/apache/nifi/pull/2194 @ijokarumawak After testing it out with a few other files I found that I really need to add an option to quote strings and escape delimiter characters when they appear in values. These are things

[GitHub] nifi issue #2194: NIFI-4465 ConvertExcelToCSV Data Formatting and Delimiters

2017-10-05 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/2194 @patricker Thanks! Sure, I'll review this PR. ---

[GitHub] nifi issue #2194: NIFI-4465 ConvertExcelToCSV Data Formatting and Delimiters

2017-10-04 Thread patricker
Github user patricker commented on the issue: https://github.com/apache/nifi/pull/2194 @ijokarumawak I saw that you made some changes to this processor back in July. I ended up gutting parts of it and using other parts of the Apache POI library so I could read formatted data. The