Github user sbouchex commented on the issue:
https://github.com/apache/nifi/pull/2276
Ok fine for me. I'll do thé ticket + PR soon
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2276
We only use swagger for documentation generation. Changing the resulting
value would break the current API that existing clients expect. I believe the
best path forward would be to fix the
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2276
I see. So the issue is with this annotation?
@ApiModelProperty(
value = "The state of the processor.",
allowableValues = "RUNNING, STOPPED, DISABLED,
Github user sbouchex commented on the issue:
https://github.com/apache/nifi/pull/2276
Yes, but the problem is the toString() which is not good :
ProcessorStatusSnapshotDTO is defining RUNNING but the call in DtoFactory
is setting "Running"
So the value is *not*
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2276
In some cases, human-readable labels are generated and other cases not.
Often times we defer to the `toString` of the enum to drive the resulting value.
---
Github user sbouchex commented on the issue:
https://github.com/apache/nifi/pull/2276
`.toUpperCase()` is probably missing...
---
Github user sbouchex commented on the issue:
https://github.com/apache/nifi/pull/2276
org.apache.nifi.controller.status.RunStatus contains lowercase characters
but org.apache.nifi.web.api.dto.status.ProcessorStatusSnapshotDTO (and probably
other classes) are defining UPPERCASE
Github user sbouchex commented on the issue:
https://github.com/apache/nifi/pull/2276
OK, the problem is not in the REST API which does contain the right value :
`"runStatus":"Running"`
However, the problem is in the generated code from swagger.io (or in Nifi)
: In
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2276
I'd suggest invoking the endpoints using curl or looking at Dev Tools in
your browser to verify that the issue is with NiFi.
---
Github user sbouchex commented on the issue:
https://github.com/apache/nifi/pull/2276
I'm running a build from the latest sources in standalone mode.
I have a process group with 4 processors all running (from the web ui pow)
and when I do retrieve the ProcessGroupStatusDTO of
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2276
@sbouchex What version of NiFi are you running? When endpoint are you
invoking that is not setting this value? Are you running standalone or
clustered?
---
Github user sbouchex commented on the issue:
https://github.com/apache/nifi/pull/2276
I open the issue as the issue is still there... the processor status is
reported as null instead of RUNNING
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2276
Thanks @sbouchex! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2276
@sbouchex This is a great catch and thanks for the contribution! Reviewing
the code it appears that the runStatus was moved into the status snapshot
likely during the 0.x -> 1.x transtion. This
14 matches
Mail list logo
