[GitHub] nifi issue #2468: NIFI-4849: Implemented REST Endpoint and associated backen...

2018-03-15 Thread mcgilman 
Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/2468
  
Thanks @markap14! This has been merged to master.


---

[GitHub] nifi issue #2468: NIFI-4849: Implemented REST Endpoint and associated backen...

2018-03-12 Thread markap14 
Github user markap14 commented on the issue:

https://github.com/apache/nifi/pull/2468
  
@mcgilman I have pushed a new commit that addresses above conversation.


---

[GitHub] nifi issue #2468: NIFI-4849: Implemented REST Endpoint and associated backen...

2018-03-12 Thread markap14 
Github user markap14 commented on the issue:

https://github.com/apache/nifi/pull/2468
  
I think at this point, after looking at the data model for 
JVMDiagnosticsSnapshotDTO we can probably just break this into 3 distinct 
fields: JVMSystemDiagnosticsSnapshotDTO, JVMControllerDiagnosticsDTO, 
JVMFlowDiagnosticsDTO. Then, it makes the filtering and the permissions (and 
likely the merging) a lot cleaner. Will head down that path and see if that 
cleans things up. Thanks for the review so far @mcgilman!


---

[GitHub] nifi issue #2468: NIFI-4849: Implemented REST Endpoint and associated backen...

2018-02-13 Thread mcgilman 
Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/2468
  
Will review...


---