[GitHub] nifi issue #2487: NIFI-4774: Allow user to choose which write-ahead log impl...

2018-03-13 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2487 +1 LGTM, I tested switching back and forth and everything looks good. Thanks for the improvement! Merging to master ---

[GitHub] nifi issue #2487: NIFI-4774: Allow user to choose which write-ahead log impl...

2018-03-13 Thread mosermw
Github user mosermw commented on the issue: https://github.com/apache/nifi/pull/2487 @mattyb149 and @markap14 with the 1.6.0 release approaching, do you think we've allowed enough time for review and testing? Is this good to go? Thanks. ---

[GitHub] nifi issue #2487: NIFI-4774: Allow user to choose which write-ahead log impl...

2018-03-06 Thread mosermw
Github user mosermw commented on the issue: https://github.com/apache/nifi/pull/2487 I tested this and I was able to switch back and forth between MinimalLockingWriteAheadLog and SequentialAccessWriteAheadLog. +1 from me. It's best to make this switch while there are 0 flowfiles in