Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2518
Forgot to mention that the NiFi Flow I used to test, is available here:
https://gist.github.com/ijokarumawak/c455075f7830935189e5efbd83e5d863
---
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2518
@bbende Thanks for your comment. That's true, we need to rename not only
NAR file but also component class names. I agree with staying 1.1.2 unless
there is no necessary updates.
@MikeTh
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2518
@MikeThomsen @ijokarumawak I'd say unless there is something in the 1.2
client that is needed to implement the visibility labels, then it might be
safer to just stay on 1.1.2, and hopefully soon we can
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2518
@ijokarumawak version reverted and building...
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2518
I'll add a patch to revert the version # on the client lib. Since HDP is on
1.1.2 and CDH 5.14 is still on 1.2, I don't think it's safe to jump up to
anything higher than a 1.2 client anyway.
--
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2518
@MikeThomsen Thanks for the updates. It mostly looks good. The only concern
I have is the gap between the name of NAR and the HBase client version. One
possible solution is to rename the NAR from
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2518
@ijokarumawak Anything left before you're comfortable merging this?
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2518
Added `additionalDetails` for `PutHBaseCell` and `PutHBaseRow`. Also fixed
up some of the behavior of the `pickVisibilityLabel` method.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2518
@ijokarumawak forgot the documentation...
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2518
@ijokarumawak I think it's all in now. I just finished the last change you
requested.
---
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2518
@joshelser Thanks for your prompt answer. I didn't know that different
values can be stored with the same key but different visibility label
expression. The explanation 'The expression also contr
Github user joshelser commented on the issue:
https://github.com/apache/nifi/pull/2518
> Would you please educate me why delete operation uses expression instead
of a comma separated labels as scan does
The general reasoning is this: you may have multiple "values" for the same
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2518
@MikeThomsen Thanks for the quick update, I will continue reviewing.
@bbende Thanks for the info. What I was wondering about is why HBase
requires a 'Visibility Label Expression' instead
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2518
@ijokarumawak pushed the documentation change you requested and switched
PutHBaseCell/JSON to use dynamic properties.
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2518
I think we are saying the same thing, the authorizations can come from
anywhere, but I was just using end-user as an example.
In Accumulo you would issue an operation and pass in an array of la
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2518
@MikeThomsen @bbende HBase allows user to set visibility label expression
using labels those are not associated to the user by default. There is a server
side configuration to strict this
`hbase
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2518
@bbende that is my understanding as well.
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2518
@MikeThomsen @ijokarumawak I haven't looked at how Hbase visibility labels
work compared to Accumulo, but in Accumulo you pass in the authorizations for
an operations which are then compared against th
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2518
@joshelser Quick question about Accumulo, does it require you to specify
the visibility string in a delete mutation?
---
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2518
@MikeThomsen Thanks for rebasing. I am now testing against my HBase
instance.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2518
@ijokarumawak changes pushed. Ready for review.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2518
@ijokarumawak Disregard that last comment. I apparently forgot to update
the EL support. Will get that done today.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2518
@ijokarumawak New build pushed. Sorry about the squash commit wiping out
the existing comments, but I had to do it in order to save time and stress on
integrating the EL changes and things like th
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2518
@MikeThomsen For upgrading HBase dependency version, I'd do create a new
NAR. So that people have dependency with HBase 1.1.x can keep using
HBase_1_1_2_ClientService. We do the same to support d
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2518
@bbende @ijokarumawak To move that IT into the client test package, I have
to upgrade the client's hbase-client dependency to 1.2.X from 1.1.X. Do you see
anything wrong with doing that? At this p
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2518
Thanks for jumping on this @ijokarumawak I'll try to find some time today
to resolve and push a fix.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2518
@bbende @ijokarumawak could you take a look at this once 1.6 is released?
---
Github user joshelser commented on the issue:
https://github.com/apache/nifi/pull/2518
> Would you be open to a code review in the future (months away at least)
if I were to start adding Accumulo support?
Feel free to hit me up :)
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2518
@joshelser Unrelated to this...
Would you be open to a code review in the future (months away at least) if
I were to start adding Accumulo support?
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2518
Had to rebase because of the commit that added `ScanHBase`. That doesn't
have visibility labels added to it yet. That needs to be done. Keeping this
ticket open because there's plenty that can be
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2518
This also adds a new processor: DeleteHBaseCells.
---
31 matches
Mail list logo
