Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2562
@MikeThomsen @joewitt - Thanks for your help in making this contribution
possible.
@timhallinflux - Please let me know if you have any additional enhancements
possible. I will contact
Github user timhallinflux commented on the issue:
https://github.com/apache/nifi/pull/2562
Yep. Working on a blog post to highlight both parts...writer and reader.
U is not really possible. For D, both DELETE and/or DROP statements are
allowed through InfluxQL.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2562
@timhallinflux Based on my extremely limited knowledge of what InfluxDB can
do, I don't know if even the U or D from CRUD are really applicable to InfluxDB
for example. What I'd like to see is
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2562
@timhallinflux if you don't mind, please take some time to think about
additional NiFi-related use cases and either post them to the dev mailing list
or add them as Jira tickets.
---
Github user timhallinflux commented on the issue:
https://github.com/apache/nifi/pull/2562
This is great! Thank you Mike and Mans. Mans if you reach out to me
at tim at influxdata dot com
we would be happy to send you some stickers and a hoodie in appreciation
for your
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2562
Approved and merged. Thanks @mans2singh
---
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2562
@MikeThomsen -
I've updated the code (added expression language scope and updated tests)
based your review comments. The integration tests are passing.
Please let me know if
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2562
@mans2singh I went to merge your changes this morning and found that you
have some integration tests that are broken now with the changes made to EL
support in the `PropertyDescriptor.Builder`
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2562
Thanks @MikeThomsen for your reveiw/advice. Also thanks @timhallinflux for
the pointers on influxdb sandbox.
Please let me know if there is other feedback.
Mans
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2562
Forgot to add that a link to a comprehensive sandbox is appreciated
@timhallinflux
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2562
@timhallinflux @mans2singh already provided a decent enough Docker Compose
test for it. So unless @joewitt or someone else sees something that I missed
that's a show stopper, I think we're good
Github user timhallinflux commented on the issue:
https://github.com/apache/nifi/pull/2562
@joewitt and @MikeThomsen -- you can also just quickly spin up the TICK
stack via the sandbox.
Have a look here... https://github.com/influxdata/sandbox
If @joewitt is no longer
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2562
@MikeThomsen -
I have updated the test cases regarding usage of assertions. Let me know
if there is anything else outstanding.
Thanks
---
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2562
@MikeThomsen -
I've updated the code based on your comments. Let me know if you have any
more recommendations.
Thanks
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2562
Verified that both flows work against the Docker Compose configuration.
Looking very good so far.
---
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2562
@MikeThomsen - I've updated the code based on your comments (added check
for query result null, changed scheduled query property name). One note, if we
use the influxdb-compose.xml file for
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2562
@joewitt @MikeThomsen -
I've updated the code based on your comments.
I've also added a docker gist
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2562
Hi @MikeThomsen - Thanks for your review and comments.
I will work on your and @joewitt 's recommendation this weekend.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2562
@mans2singh Have you had a chance to work on any of these?
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2562
@joewitt @mans2singh [Here's a starting
point](https://github.com/apache/nifi/pull/2101#issuecomment-361083921) on the
Docker/Docker Compose
---
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2562
@mans2singh thanks for contributing. What we need most right now is help
reviewing outstanding PRs. This involves reviewing code and validating as
possible whether things are actually functioning.
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2562
Hi Nifi Team:
Please let me know your suggestions/recommendations on this InfluxDB Query
Processsor.
Thanks
---
22 matches
Mail list logo
