Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2587
This is now merged to master. Thanks again for the contribution!
---
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2587
@JohannesDaniel that would be great! I think the Record attribute stuff
will significantly improve how we are able to handle XML-based records. But I
think the approach that you've taken here is a
Github user JohannesDaniel commented on the issue:
https://github.com/apache/nifi/pull/2587
@markap14 thanks for the help with the patch file. I am fine with it :)
If you have not planned to do that yourself, I would start implementing a
XMLWriter as soon as this has been
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2587
@JohannesDaniel this is great! I've been doing a good bit of testing to
ensure that everything works as expected. I had just a few more comments,
mostly around the descriptions in the property
Github user JohannesDaniel commented on the issue:
https://github.com/apache/nifi/pull/2587
@markap14
- Added EL for record format property
- Removed record tag validation
---
Github user JohannesDaniel commented on the issue:
https://github.com/apache/nifi/pull/2587
@markap14 thank you for the response.
I will simply remove that record tag validation as there are indeed many
ways to do that before the data is processed by this reader.
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2587
@JohannesDaniel thanks for the update! I commented above re: the use of
Expression Language in the property descriptor.
I do still feel like the check for 'record tag names' is unnecessary, as
Github user JohannesDaniel commented on the issue:
https://github.com/apache/nifi/pull/2587
@markap14 @pvillard31
- I refactored some code as the cases (coerce==true && drop==false) and
(coerce==false && drop==true) in some cases showed an unexpected behavior
- Data like
Github user JohannesDaniel commented on the issue:
https://github.com/apache/nifi/pull/2587
@markap14 thank you for the comprehensive review. I will start refactoring
the implementations with respect to the improvements that are clear.
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2587
Hey @JohannesDaniel - just made new tests and can't reproduce what I saw
previously... so let's forget about it :) (thanks for the unit tests though!)
I tested the EL support for tag
Github user JohannesDaniel commented on the issue:
https://github.com/apache/nifi/pull/2587
Can you maybe post the XML that led to the empty record?
---
Github user JohannesDaniel commented on the issue:
https://github.com/apache/nifi/pull/2587
Hi @pvillard31
thank you for your comments! I realized all your suggestions. I like your
news regarding the performance :-) Which kind of transformation did you test?
XML => Record
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2587
Thanks for pinging me @JohannesDaniel - I'll also try to have a look over
the WE / next week. It'd be a great addition!
---
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2587
@JohannesDaniel thanks for the contribution! This is definitely something
that I've been wanting to implement for a while but haven't had a chance yet.
Will be happy to review.
---
Github user JohannesDaniel commented on the issue:
https://github.com/apache/nifi/pull/2587
@pvillard31 here we go :)
---
15 matches
Mail list logo
